Re: [PATCH v1 1/6] spi: dt-bindings: qcom-qspi: Add QCS615 compatible

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 3/25/26 12:12 PM, Krzysztof Kozlowski wrote:
> On Tue, Mar 24, 2026 at 06:43:18PM +0530, Viken Dadhaniya wrote:
>> Add the "qcom,qcs615-qspi" compatible string to the Qualcomm QSPI device-
>> tree binding
> 
> ^^ Full stop
> 
>> to enable QCS615-based platforms to use the existing QSPI
>> controller binding.
> 
> That's obvious, no need to state it. Writing longer texts without actual
> useful message is not helpful.
> 
>>
>> Signed-off-by: Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>
>> ---
>>  Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
>> index 1696ac46a660..d9aac33b695b 100644
>> --- a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
>> +++ b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
>> @@ -20,6 +20,7 @@ properties:
>>    compatible:
>>      items:
>>        - enum:
>> +          - qcom,qcs615-qspi
> 
> Existing bindings allow flexible interconnects, but it should be
> constrained. At least for new variants. Please move allOf: to the bottom
> (after required:) and add there if:then: requiring min two interconnects
> for qcs615.

FWIW they should have never been flexible on any platform

Konrad