[PATCH v3 0/2] Update section header name check

[PATCH v3 0/2] Update section header name check

[Srinivasa Rao Mandadapu]

Update section header name check and corresponding documentation.
Changes since v2:
    -- Update the commit message with example.
    -- Update the documentation text appropriately.
Changes since v1:
    -- Update the commit message.
    -- Use strstarts instead of strstr.
    -- Update documentation file.

Srinivasa Rao Mandadapu (2):
  remoteproc: elf_loader: Update resource table name check
  docs: remoteproc: Update section header name requirement

 Documentation/staging/remoteproc.rst       | 5 ++++-
 drivers/remoteproc/remoteproc_elf_loader.c | 2 +-
 2 files changed, 5 insertions(+), 2 deletions(-)

-- 
2.7.4

[PATCH v3 1/2] remoteproc: elf_loader: Update resource table name check

[Srinivasa Rao Mandadapu]

Update the way of checking resource table name with prefix
substring search instead of complete string search.
In general Qualcomm DSP binary is prepared by combining different ELFs',
hence section header name (e.g. .resource_table), appended with ELF name
to differentiate with same section(e.g. resource_table.ac_bin_process) of
different ELFs'.
Example readelf output of DSP binary:
    [60] .start.ac_bin_process PROGBITS
    [61] .resource_table.ac_bin_process PROGBITS
    [62] .comment.ac_bin_process PROGBITS

Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
---
 drivers/remoteproc/remoteproc_elf_loader.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/remoteproc/remoteproc_elf_loader.c b/drivers/remoteproc/remoteproc_elf_loader.c
index 5a412d7..77330d6 100644
--- a/drivers/remoteproc/remoteproc_elf_loader.c
+++ b/drivers/remoteproc/remoteproc_elf_loader.c
@@ -272,7 +272,7 @@ find_table(struct device *dev, const struct firmware *fw)
 		u64 offset = elf_shdr_get_sh_offset(class, shdr);
 		u32 name = elf_shdr_get_sh_name(class, shdr);
 
-		if (strcmp(name_table + name, ".resource_table"))
+		if (!strstarts(name_table + name, ".resource_table"))
 			continue;
 
 		table = (struct resource_table *)(elf_data + offset);
-- 
2.7.4

Re: [PATCH v3 1/2] remoteproc: elf_loader: Update resource table name check

[Mukesh Ojha]

Hi,

On 12/20/2022 1:31 PM, Srinivasa Rao Mandadapu wrote:
> Update the way of checking resource table name with prefix
> substring search instead of complete string search.
> In general Qualcomm DSP binary is prepared by combining different ELFs',
> hence section header name (e.g. .resource_table), appended with ELF name
> to differentiate with same section(e.g. resource_table.ac_bin_process) of
> different ELFs'.
> Example readelf output of DSP binary:
>      [60] .start.ac_bin_process PROGBITS
>      [61] .resource_table.ac_bin_process PROGBITS
>      [62] .comment.ac_bin_process PROGBITS
> 

Could we rephrase above like below ? It could be also taken why applying 
the patch.

Update the way of checking resource table name with prefix substring 
search instead of complete string search.

In general, Qualcomm DSP binary is prepared by combining different 
ELF's. Hence, section header name (e.g. .resource_table), appended
with ELF name to differentiate with same section(e.g. 
resource_table.ac_bin_process) of different ELFs'.

Example readelf output of DSP binary:
       [60] .start.ac_bin_process PROGBITS
       [61] .resource_table.ac_bin_process PROGBITS
       [62] .comment.ac_bin_process PROGBITS


Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>

Otherwise, LGTM.
Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>

-Mukesh
> ---
>   drivers/remoteproc/remoteproc_elf_loader.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/remoteproc/remoteproc_elf_loader.c b/drivers/remoteproc/remoteproc_elf_loader.c
> index 5a412d7..77330d6 100644
> --- a/drivers/remoteproc/remoteproc_elf_loader.c
> +++ b/drivers/remoteproc/remoteproc_elf_loader.c
> @@ -272,7 +272,7 @@ find_table(struct device *dev, const struct firmware *fw)
>   		u64 offset = elf_shdr_get_sh_offset(class, shdr);
>   		u32 name = elf_shdr_get_sh_name(class, shdr);
>   
> -		if (strcmp(name_table + name, ".resource_table"))
> +		if (!strstarts(name_table + name, ".resource_table"))
>   			continue;
>   
>   		table = (struct resource_table *)(elf_data + offset);

Re: [PATCH v3 1/2] remoteproc: elf_loader: Update resource table name check

[Philippe Mathieu-Daudé]

On 20/12/22 13:50, Mukesh Ojha wrote:
> Hi,
> 
> On 12/20/2022 1:31 PM, Srinivasa Rao Mandadapu wrote:
>> Update the way of checking resource table name with prefix
>> substring search instead of complete string search.
>> In general Qualcomm DSP binary is prepared by combining different ELFs',
>> hence section header name (e.g. .resource_table), appended with ELF name
>> to differentiate with same section(e.g. resource_table.ac_bin_process) of
>> different ELFs'.
>> Example readelf output of DSP binary:
>>      [60] .start.ac_bin_process PROGBITS
>>      [61] .resource_table.ac_bin_process PROGBITS
>>      [62] .comment.ac_bin_process PROGBITS
>>
> 
> Could we rephrase above like below ?

FWIW I agree :) I assumed Srinivasa was using a broken email client
that strips newlines and packs everything.

> It could be also taken why applying 
> the patch.
> 
> Update the way of checking resource table name with prefix substring 
> search instead of complete string search.
> 
> In general, Qualcomm DSP binary is prepared by combining different 
> ELF's. Hence, section header name (e.g. .resource_table), appended
> with ELF name to differentiate with same section(e.g. 
> resource_table.ac_bin_process) of different ELFs'.
> 
> Example readelf output of DSP binary:
>        [60] .start.ac_bin_process PROGBITS
>        [61] .resource_table.ac_bin_process PROGBITS
>        [62] .comment.ac_bin_process PROGBITS
> 
> 
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> 
> Otherwise, LGTM.
> Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>
> 
> -Mukesh
>> ---
>>   drivers/remoteproc/remoteproc_elf_loader.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/remoteproc/remoteproc_elf_loader.c 
>> b/drivers/remoteproc/remoteproc_elf_loader.c
>> index 5a412d7..77330d6 100644
>> --- a/drivers/remoteproc/remoteproc_elf_loader.c
>> +++ b/drivers/remoteproc/remoteproc_elf_loader.c
>> @@ -272,7 +272,7 @@ find_table(struct device *dev, const struct 
>> firmware *fw)
>>           u64 offset = elf_shdr_get_sh_offset(class, shdr);
>>           u32 name = elf_shdr_get_sh_name(class, shdr);
>> -        if (strcmp(name_table + name, ".resource_table"))
>> +        if (!strstarts(name_table + name, ".resource_table"))
>>               continue;
>>           table = (struct resource_table *)(elf_data + offset);

Re: [PATCH v3 1/2] remoteproc: elf_loader: Update resource table name check

[Mukesh Ojha]

Hi,

On 12/20/2022 6:20 PM, Mukesh Ojha wrote:
> Hi,
> 
> On 12/20/2022 1:31 PM, Srinivasa Rao Mandadapu wrote:
>> Update the way of checking resource table name with prefix
>> substring search instead of complete string search.
>> In general Qualcomm DSP binary is prepared by combining different ELFs',
>> hence section header name (e.g. .resource_table), appended with ELF name
>> to differentiate with same section(e.g. resource_table.ac_bin_process) of
>> different ELFs'.
>> Example readelf output of DSP binary:
>>      [60] .start.ac_bin_process PROGBITS
>>      [61] .resource_table.ac_bin_process PROGBITS
>>      [62] .comment.ac_bin_process PROGBITS
>>
> 
> Could we rephrase above like below ? It could be also taken why applying 
> the patch.
> 
> Update the way of checking resource table name with prefix substring 
> search instead of complete string search.
> 
> In general, Qualcomm DSP binary is prepared by combining different 
> ELF's. Hence, section header name (e.g. .resource_table), appended
> with ELF name to differentiate with same section(e.g. 
> resource_table.ac_bin_process) of different ELFs'.
> 
> Example readelf output of DSP binary:
>        [60] .start.ac_bin_process PROGBITS
>        [61] .resource_table.ac_bin_process PROGBITS
>        [62] .comment.ac_bin_process PROGBITS
> 
> 

Looks like my email client did not honour new line
put by me in rephrased text. Sorry for that.

Please run checkpatch.pl before sending the patch.

-Mukesh

> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> 
> Otherwise, LGTM.
> Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>
> 
> -Mukesh
>> ---
>>   drivers/remoteproc/remoteproc_elf_loader.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/remoteproc/remoteproc_elf_loader.c 
>> b/drivers/remoteproc/remoteproc_elf_loader.c
>> index 5a412d7..77330d6 100644
>> --- a/drivers/remoteproc/remoteproc_elf_loader.c
>> +++ b/drivers/remoteproc/remoteproc_elf_loader.c
>> @@ -272,7 +272,7 @@ find_table(struct device *dev, const struct 
>> firmware *fw)
>>           u64 offset = elf_shdr_get_sh_offset(class, shdr);
>>           u32 name = elf_shdr_get_sh_name(class, shdr);
>> -        if (strcmp(name_table + name, ".resource_table"))
>> +        if (!strstarts(name_table + name, ".resource_table"))
>>               continue;
>>           table = (struct resource_table *)(elf_data + offset);

Re: [PATCH v3 1/2] remoteproc: elf_loader: Update resource table name check

[Srinivasa Rao Mandadapu]

On 12/20/2022 6:20 PM, Mukesh Ojha wrote:
Thanks for your time Mukesh!!!
> Hi,
>
> On 12/20/2022 1:31 PM, Srinivasa Rao Mandadapu wrote:
>> Update the way of checking resource table name with prefix
>> substring search instead of complete string search.
>> In general Qualcomm DSP binary is prepared by combining different ELFs',
>> hence section header name (e.g. .resource_table), appended with ELF name
>> to differentiate with same section(e.g. 
>> resource_table.ac_bin_process) of
>> different ELFs'.
>> Example readelf output of DSP binary:
>>      [60] .start.ac_bin_process PROGBITS
>>      [61] .resource_table.ac_bin_process PROGBITS
>>      [62] .comment.ac_bin_process PROGBITS
>>
>
> Could we rephrase above like below ? It could be also taken why 
> applying the patch.
>
> Update the way of checking resource table name with prefix substring 
> search instead of complete string search.
>
> In general, Qualcomm DSP binary is prepared by combining different 
> ELF's. Hence, section header name (e.g. .resource_table), appended
> with ELF name to differentiate with same section(e.g. 
> resource_table.ac_bin_process) of different ELFs'.
>
> Example readelf output of DSP binary:
>       [60] .start.ac_bin_process PROGBITS
>       [61] .resource_table.ac_bin_process PROGBITS
>       [62] .comment.ac_bin_process PROGBITS
>
Okay. will change accordingly.
>
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
>
> Otherwise, LGTM.
> Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>
>
> -Mukesh
>> ---
>>   drivers/remoteproc/remoteproc_elf_loader.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/remoteproc/remoteproc_elf_loader.c 
>> b/drivers/remoteproc/remoteproc_elf_loader.c
>> index 5a412d7..77330d6 100644
>> --- a/drivers/remoteproc/remoteproc_elf_loader.c
>> +++ b/drivers/remoteproc/remoteproc_elf_loader.c
>> @@ -272,7 +272,7 @@ find_table(struct device *dev, const struct 
>> firmware *fw)
>>           u64 offset = elf_shdr_get_sh_offset(class, shdr);
>>           u32 name = elf_shdr_get_sh_name(class, shdr);
>>   -        if (strcmp(name_table + name, ".resource_table"))
>> +        if (!strstarts(name_table + name, ".resource_table"))
>>               continue;
>>             table = (struct resource_table *)(elf_data + offset);

[PATCH v3 2/2] docs: remoteproc: Update section header name requirement

[Srinivasa Rao Mandadapu]

Add section header name requirement specification in elf segments.

Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
---
 Documentation/staging/remoteproc.rst | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/staging/remoteproc.rst b/Documentation/staging/remoteproc.rst
index 348ee7e..0c9c10a 100644
--- a/Documentation/staging/remoteproc.rst
+++ b/Documentation/staging/remoteproc.rst
@@ -244,7 +244,10 @@ according to the specified device address (might be a physical address
 if the remote processor is accessing memory directly).
 
 In addition to the standard ELF segments, most remote processors would
-also include a special section which we call "the resource table".
+also include a special section which we call the "resource table".
+A "resource table" section name must start with the ".resource_table" prefix,
+optionally having a more descriptive string appended. For example,
+".resource_table.my_rproc" is a valid section name.
 
 The resource table contains system resources that the remote processor
 requires before it should be powered on, such as allocation of physically
-- 
2.7.4

Re: [PATCH v3 2/2] docs: remoteproc: Update section header name requirement

[Mukesh Ojha]

Hi,

On 12/20/2022 1:31 PM, Srinivasa Rao Mandadapu wrote:
> Add section header name requirement specification in elf segments.
> 
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>


LGTM.
Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>

-Mukesh
> ---
>   Documentation/staging/remoteproc.rst | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/staging/remoteproc.rst b/Documentation/staging/remoteproc.rst
> index 348ee7e..0c9c10a 100644
> --- a/Documentation/staging/remoteproc.rst
> +++ b/Documentation/staging/remoteproc.rst
> @@ -244,7 +244,10 @@ according to the specified device address (might be a physical address
>   if the remote processor is accessing memory directly).
>   
>   In addition to the standard ELF segments, most remote processors would
> -also include a special section which we call "the resource table".
> +also include a special section which we call the "resource table".
> +A "resource table" section name must start with the ".resource_table" prefix,
> +optionally having a more descriptive string appended. For example,
> +".resource_table.my_rproc" is a valid section name.
>   
>   The resource table contains system resources that the remote processor
>   requires before it should be powered on, such as allocation of physically

Re: [PATCH v3 0/2] Update section header name check

[Philippe Mathieu-Daudé]

On 20/12/22 09:01, Srinivasa Rao Mandadapu wrote:

> Srinivasa Rao Mandadapu (2):
>    remoteproc: elf_loader: Update resource table name check
>    docs: remoteproc: Update section header name requirement

Series:
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>