From: Markus Elfring <Markus.Elfring@web.de>
To: Jie Gan <quic_jiegan@quicinc.com>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
James Clark <james.clark@arm.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Mike Leach <mike.leach@linaro.org>, Rob Herring <robh@kernel.org>,
Suzuki Poulouse <suzuki.poulose@arm.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Jinlong Mao <quic_jinlmao@quicinc.com>,
Leo Yan <leo.yan@linaro.org>,
Song Chai <quic_songchai@quicinc.com>,
Tao Zhang <quic_taozha@quicinc.com>,
Tingwei Zhang <quic_tingweiz@quicinc.com>,
Trilok Soni <quic_tsoni@quicinc.com>,
Yuanfang Zhang <quic_yuanfang@quicinc.com>
Subject: Re: [PATCH v2 3/4] Coresight: Add Coresight Control Unit driver
Date: Mon, 8 Jul 2024 14:56:17 +0200 [thread overview]
Message-ID: <10cff397-af4f-4649-994f-309203376f42@web.de> (raw)
In-Reply-To: <20240705090049.1656986-4-quic_jiegan@quicinc.com>
…
> Disabling source device resets the bit according to the source device's trace ID.
How do you think about to improve such a change description with imperative wordings?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc7#n94
…
> +++ b/drivers/hwtracing/coresight/coresight-ccu.c
> @@ -0,0 +1,290 @@
…
> +static int __ccu_set_etr_traceid(struct coresight_device *csdev,
> + uint32_t traceid, bool enable)
> +{
…
> + spin_lock_irqsave(&drvdata->spin_lock, flags);
> + CS_UNLOCK(drvdata->base);
…
> + ccu_writel(drvdata, val, reg_offset);
> +
> + CS_LOCK(drvdata->base);
> + spin_unlock_irqrestore(&drvdata->spin_lock, flags);
> + return 0;
> +}
…
Under which circumstances would you become interested to apply a statement
like “guard(spinlock_irqsave)(&drvdata->spin_lock);”?
https://elixir.bootlin.com/linux/v6.10-rc7/source/include/linux/spinlock.h#L574
Regards,
Markus
next prev parent reply other threads:[~2024-07-08 12:56 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-05 9:00 [PATCH v2 0/4] Coresight: Add Coresight Control Unit driver Jie Gan
2024-07-05 9:00 ` [PATCH v2 1/4] Coresight: Add trace_id function to collect trace ID Jie Gan
2024-07-08 12:36 ` Markus Elfring
2024-07-23 10:30 ` Mike Leach
2024-07-24 7:00 ` JieGan
2024-08-07 1:32 ` JieGan
2024-07-05 9:00 ` [PATCH v2 2/4] dt-bindings: arm: Add binding document for Coresight Control Unit device Jie Gan
2024-07-05 9:07 ` Krzysztof Kozlowski
2024-07-08 0:47 ` JieGan
2024-07-18 2:35 ` JieGan
2024-07-05 10:38 ` Rob Herring (Arm)
2024-07-08 9:41 ` Suzuki K Poulose
2024-07-08 10:10 ` JieGan
2024-07-08 10:25 ` JieGan
2024-07-08 12:50 ` Suzuki K Poulose
2024-07-09 6:00 ` JieGan
2024-07-11 8:36 ` JieGan
2024-07-11 9:32 ` Suzuki K Poulose
2024-07-15 8:46 ` JieGan
2024-07-05 9:00 ` [PATCH v2 3/4] Coresight: Add Coresight Control Unit driver Jie Gan
2024-07-05 9:11 ` Krzysztof Kozlowski
2024-07-08 3:16 ` JieGan
2024-07-08 10:44 ` Krzysztof Kozlowski
2024-07-09 4:05 ` JieGan
2024-07-08 12:56 ` Markus Elfring [this message]
2024-07-05 9:00 ` [PATCH v2 4/4] arm64: dts: qcom: Add CCU and ETR nodes for SA8775p Jie Gan
2024-07-05 9:08 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10cff397-af4f-4649-994f-309203376f42@web.de \
--to=markus.elfring@web.de \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=james.clark@arm.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=quic_jiegan@quicinc.com \
--cc=quic_jinlmao@quicinc.com \
--cc=quic_songchai@quicinc.com \
--cc=quic_taozha@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=quic_yuanfang@quicinc.com \
--cc=robh@kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox