From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: JieGan <quic_jiegan@quicinc.com>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Mike Leach <mike.leach@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
James Clark <james.clark@arm.com>,
Jinlong Mao <quic_jinlmao@quicinc.com>,
Leo Yan <leo.yan@linaro.org>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Tingwei Zhang <quic_tingweiz@quicinc.com>,
Yuanfang Zhang <quic_yuanfang@quicinc.com>,
Tao Zhang <quic_taozha@quicinc.com>,
Trilok Soni <quic_tsoni@quicinc.com>,
Song Chai <quic_songchai@quicinc.com>,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 3/4] Coresight: Add Coresight Control Unit driver
Date: Mon, 8 Jul 2024 12:44:43 +0200 [thread overview]
Message-ID: <afd3c7b3-9d12-4ece-a938-c99bf9c5bb7b@linaro.org> (raw)
In-Reply-To: <ZotaBxRpv29crRHV@jiegan-gv.ap.qualcomm.com>
On 08/07/2024 05:16, JieGan wrote:
>
>>
>>> +
>>> + drvdata->base = devm_ioremap(dev, res->start, resource_size(res));
>>
>> Use proper wrapper for this two.
> Replaced by:
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> drvdata->base = devm_ioremap_resource(dev, res);
Why?
Use the wrapper.
...
>>> +
>>> +static struct platform_driver ccu_driver = {
>>> + .probe = ccu_probe,
>>> + .remove = ccu_remove,
>>> + .driver = {
>>> + .name = "coresight-ccu",
>>> + .of_match_table = ccu_match,
>>> + .suppress_bind_attrs = true,
>>
>> Why?
> Sorry, I dont get the point here.
You do not get the point why I am asking "why?"?
Why do you need it?
> We dont need automatic bind/unbind, so the suppress_bind_attrs sets to true.
But I need it...
> We need configure some settings before we register the device.
Hm, is this expected for coresight devices?
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-08 10:44 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-05 9:00 [PATCH v2 0/4] Coresight: Add Coresight Control Unit driver Jie Gan
2024-07-05 9:00 ` [PATCH v2 1/4] Coresight: Add trace_id function to collect trace ID Jie Gan
2024-07-08 12:36 ` Markus Elfring
2024-07-23 10:30 ` Mike Leach
2024-07-24 7:00 ` JieGan
2024-08-07 1:32 ` JieGan
2024-07-05 9:00 ` [PATCH v2 2/4] dt-bindings: arm: Add binding document for Coresight Control Unit device Jie Gan
2024-07-05 9:07 ` Krzysztof Kozlowski
2024-07-08 0:47 ` JieGan
2024-07-18 2:35 ` JieGan
2024-07-05 10:38 ` Rob Herring (Arm)
2024-07-08 9:41 ` Suzuki K Poulose
2024-07-08 10:10 ` JieGan
2024-07-08 10:25 ` JieGan
2024-07-08 12:50 ` Suzuki K Poulose
2024-07-09 6:00 ` JieGan
2024-07-11 8:36 ` JieGan
2024-07-11 9:32 ` Suzuki K Poulose
2024-07-15 8:46 ` JieGan
2024-07-05 9:00 ` [PATCH v2 3/4] Coresight: Add Coresight Control Unit driver Jie Gan
2024-07-05 9:11 ` Krzysztof Kozlowski
2024-07-08 3:16 ` JieGan
2024-07-08 10:44 ` Krzysztof Kozlowski [this message]
2024-07-09 4:05 ` JieGan
2024-07-08 12:56 ` Markus Elfring
2024-07-05 9:00 ` [PATCH v2 4/4] arm64: dts: qcom: Add CCU and ETR nodes for SA8775p Jie Gan
2024-07-05 9:08 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afd3c7b3-9d12-4ece-a938-c99bf9c5bb7b@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=james.clark@arm.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=quic_jiegan@quicinc.com \
--cc=quic_jinlmao@quicinc.com \
--cc=quic_songchai@quicinc.com \
--cc=quic_taozha@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=quic_yuanfang@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox