[PATCH v3] dt-bindings: arm: qcom: add SA8255p Ride board

[PATCH v3] dt-bindings: arm: qcom: add SA8255p Ride board

[Deepti Jaggi]

From: Nikunj Kela <quic_nkela@quicinc.com>

Document the SA8255p SoC and its reference board: sa8255p-ride.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Nikunj Kela <quic_nkela@quicinc.com>
Signed-off-by: Deepti Jaggi <quic_djaggi@quicinc.com>
---
Changes in v3:
	Removed the patches from original series[1]

Changes in v2:
	Added Reviewed-by tag

[1]: https://lore.kernel.org/all/20240903220240.2594102-1-quic_nkela@quicinc.com/
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 08c329b1e919..5fe098566979 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -64,6 +64,7 @@ description: |
         qrb4210
         qru1000
         sa8155p
+        sa8255p
         sa8540p
         sa8775p
         sar2130p
@@ -948,6 +949,11 @@ properties:
               - qcom,sa8155p-adp
           - const: qcom,sa8155p
 
+      - items:
+          - enum:
+              - qcom,sa8255p-ride
+          - const: qcom,sa8255p
+
       - items:
           - enum:
               - qcom,sa8295p-adp
-- 
2.25.1

Re: [PATCH v3] dt-bindings: arm: qcom: add SA8255p Ride board

[Krzysztof Kozlowski]

On 23/04/2025 02:38, Deepti Jaggi wrote:
> From: Nikunj Kela <quic_nkela@quicinc.com>
> 
> Document the SA8255p SoC and its reference board: sa8255p-ride.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Nikunj Kela <quic_nkela@quicinc.com>
> Signed-off-by: Deepti Jaggi <quic_djaggi@quicinc.com>
> ---
> Changes in v3:
> 	Removed the patches from original series[1]

Why? This makes no sense on its own. Binding goes with the user. No
user? No binding.

Best regards,
Krzysztof

Re: [PATCH v3] dt-bindings: arm: qcom: add SA8255p Ride board

[Deepti Jaggi]

On 4/23/25 05:00, Krzysztof Kozlowski wrote:
> On 23/04/2025 02:38, Deepti Jaggi wrote:
>> From: Nikunj Kela <quic_nkela@quicinc.com>
>>
>> Document the SA8255p SoC and its reference board: sa8255p-ride.
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Signed-off-by: Nikunj Kela <quic_nkela@quicinc.com>
>> Signed-off-by: Deepti Jaggi <quic_djaggi@quicinc.com>
>> ---
>> Changes in v3:
>> 	Removed the patches from original series[1]
> 
> Why? This makes no sense on its own. Binding goes with the user. No
> user? No binding.

Thanks for taking the time to review the patch.
All the bindings that were initially included in the original series [1]
were removed and posted as individual patches.
devicetree has been posted as a separate patch :
Link: https://lore.kernel.org/all/20250422231249.871995-1-quic_djaggi@quicinc.com
If necessary, I can consolidate the bindings and dt into a single series
for the next version.

> 
> Best regards,
> Krzysztof

--
Regards,
Deepti

Re: [PATCH v3] dt-bindings: arm: qcom: add SA8255p Ride board

[Krzysztof Kozlowski]

On 24/04/2025 01:54, Deepti Jaggi wrote:
> 
> On 4/23/25 05:00, Krzysztof Kozlowski wrote:
>> On 23/04/2025 02:38, Deepti Jaggi wrote:
>>> From: Nikunj Kela <quic_nkela@quicinc.com>
>>>
>>> Document the SA8255p SoC and its reference board: sa8255p-ride.
>>>
>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> Signed-off-by: Nikunj Kela <quic_nkela@quicinc.com>
>>> Signed-off-by: Deepti Jaggi <quic_djaggi@quicinc.com>
>>> ---
>>> Changes in v3:
>>> 	Removed the patches from original series[1]
>>
>> Why? This makes no sense on its own. Binding goes with the user. No
>> user? No binding.
> 
> Thanks for taking the time to review the patch.
> All the bindings that were initially included in the original series [1]
> were removed and posted as individual patches.
> devicetree has been posted as a separate patch :
> Link: https://lore.kernel.org/all/20250422231249.871995-1-quic_djaggi@quicinc.com
> If necessary, I can consolidate the bindings and dt into a single series
> for the next version.
I asked why and that's not the answer to why. That's description of what
you did, but we see it here. Anyway, I explained you the process.

Best regards,
Krzysztof

Re: [PATCH v3] dt-bindings: arm: qcom: add SA8255p Ride board

[Deepti Jaggi]

On 4/23/25 23:17, Krzysztof Kozlowski wrote:
> On 24/04/2025 01:54, Deepti Jaggi wrote:
>>
>> On 4/23/25 05:00, Krzysztof Kozlowski wrote:
>>> On 23/04/2025 02:38, Deepti Jaggi wrote:
>>>> From: Nikunj Kela <quic_nkela@quicinc.com>
>>>>
>>>> Document the SA8255p SoC and its reference board: sa8255p-ride.
>>>>
>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>> Signed-off-by: Nikunj Kela <quic_nkela@quicinc.com>
>>>> Signed-off-by: Deepti Jaggi <quic_djaggi@quicinc.com>
>>>> ---
>>>> Changes in v3:
>>>> 	Removed the patches from original series[1]
>>>
>>> Why? This makes no sense on its own. Binding goes with the user. No
>>> user? No binding.
>>
>> Thanks for taking the time to review the patch.
>> All the bindings that were initially included in the original series [1]
>> were removed and posted as individual patches.
>> devicetree has been posted as a separate patch :
>> Link: https://lore.kernel.org/all/20250422231249.871995-1-quic_djaggi@quicinc.com
>> If necessary, I can consolidate the bindings and dt into a single series
>> for the next version.
> I asked why and that's not the answer to why. That's description of what
> you did, but we see it here. Anyway, I explained you the process.

By examining other patches that were split from the series by the author, 
it appears that it was advised to split the patches based on subsystem.
However, I do not have any further details.

I followed the approach used for other bindings [1] [2] [3], which were part
of the original series and were sent as separate patches and accepted.
I misjudged that the SoC binding could also be sent as a 
separate patch. I will combine the remaining bindings along with 
the device tree (DT) into a single series in the next revision.

[1]: https://lore.kernel.org/all/20240910165926.2408630-1-quic_nkela@quicinc.com/ 
[2]: https://lore.kernel.org/all/20240910171534.2412263-1-quic_nkela@quicinc.com/ 
[3]: https://lore.kernel.org/all/20240905194741.3803345-1-quic_nkela@quicinc.com/ 

> 
> Best regards,
> Krzysztof