From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Imran Shaik <imran.shaik@oss.qualcomm.com>,
Luca Weiss <luca.weiss@fairphone.com>,
Bryan O'Donoghue <bod@kernel.org>, Robert Foss <rfoss@kernel.org>,
Todor Tomov <todor.too@gmail.com>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Taniya Das <taniya.das@oss.qualcomm.com>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/3] Add CAMSS support for SM6350
Date: Tue, 17 Feb 2026 13:01:15 +0100 [thread overview]
Message-ID: <124c661b-db25-466a-a163-99ca336a3e70@oss.qualcomm.com> (raw)
In-Reply-To: <caa870e2-3795-40bc-9f0e-c93e313c8c6e@oss.qualcomm.com>
On 2/17/26 12:56 PM, Imran Shaik wrote:
>
>
> On 16-02-2026 04:34 pm, Konrad Dybcio wrote:
>> On 2/13/26 2:15 PM, Luca Weiss wrote:
>>> Add bindings, driver and dts to support the Camera Subsystem on the
>>> SM6350 SoC.
>>>
>>> These patches were tested on a Fairphone 4 smartphone with WIP sensor
>>> drivers (Sony IMX576 and IMX582), the camera pipeline works properly as
>>> far as I can tell.
>>>
>>> Though when stopping the camera stream, the following clock warning
>>> appears in dmesg. But it does not interfere with any functionality,
>>> starting and stopping the stream works and debugcc is showing 426.4 MHz
>>> while the clock is on, and 'off' while it's off.
>>>
>>> Any suggestion how to fix this, is appreciated.
>>>
>>> [ 5738.590980] ------------[ cut here ]------------
>>> [ 5738.591009] gcc_camera_axi_clk status stuck at 'on'
>>
>> FWIW 845 has .halt_check = BRANCH_VOTED here, which translates into
>> 'dont check the state at disable', this one has BRANCH_HALT (i.e. spin
>> and keep checking the hw state)
>>
>> +Taniya would BRANCH_VOTED be fitting for 6350 too? ^
>>
>
> The parent RCG of this clock is under NoC control, and seems like there is no vote on the NoC while disabling this clock, hence this issue is observed.
>
> The BRANCH_HALT_VOTED/BRANCH_HALT_SKIP should help, or if the NoC voting is removed after the clock disable then also this issue should be resolved.
This is very useful, thanks for the insight!
Is any of these solutions specifically preferred from your side?
Konrad
next prev parent reply other threads:[~2026-02-17 12:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-13 13:15 [PATCH v3 0/3] Add CAMSS support for SM6350 Luca Weiss
2026-02-13 13:15 ` [PATCH v3 1/3] dt-bindings: media: camss: Add qcom,sm6350-camss Luca Weiss
2026-02-14 8:37 ` Krzysztof Kozlowski
2026-02-14 13:05 ` Bryan O'Donoghue
2026-02-17 22:18 ` Vijay Kumar Tumati
2026-02-18 20:10 ` Krzysztof Kozlowski
2026-02-18 20:47 ` Vijay Kumar Tumati
2026-02-26 9:44 ` Krzysztof Kozlowski
2026-02-13 13:15 ` [PATCH v3 2/3] media: qcom: camss: Add SM6350 support Luca Weiss
2026-02-14 13:08 ` Bryan O'Donoghue
2026-02-15 12:46 ` David Heidelberg
2026-02-16 10:02 ` Bryan O'Donoghue
2026-02-13 13:15 ` [PATCH v3 3/3] arm64: dts: qcom: sm6350: Add CAMSS node Luca Weiss
2026-02-16 11:04 ` [PATCH v3 0/3] Add CAMSS support for SM6350 Konrad Dybcio
2026-02-17 11:56 ` Imran Shaik
2026-02-17 12:01 ` Konrad Dybcio [this message]
2026-02-18 18:12 ` Imran Shaik
2026-02-24 13:43 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=124c661b-db25-466a-a163-99ca336a3e70@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bod@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imran.shaik@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=mchehab@kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=taniya.das@oss.qualcomm.com \
--cc=todor.too@gmail.com \
--cc=vladimir.zapolskiy@linaro.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox