From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Luca Weiss <luca.weiss@fairphone.com>,
Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] media: qcom: camss: Add SM6350 support
Date: Sat, 14 Feb 2026 13:08:01 +0000 [thread overview]
Message-ID: <2f8a6e03-b056-451f-a1b9-ec5fd160eabd@linaro.org> (raw)
In-Reply-To: <20260213-sm6350-camss-v3-2-30a845b0b7cc@fairphone.com>
On 13/02/2026 13:15, Luca Weiss wrote:
> Add the necessary support for CAMSS on the SM6350 SoC.
>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> .../platform/qcom/camss/camss-csiphy-3ph-1-0.c | 125 ++++++++++
> drivers/media/platform/qcom/camss/camss-vfe.c | 2 +
> drivers/media/platform/qcom/camss/camss.c | 261 +++++++++++++++++++++
> drivers/media/platform/qcom/camss/camss.h | 1 +
> 4 files changed, 389 insertions(+)
>
> diff --git a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
> index 415483274552..2b0c21c90e30 100644
> --- a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
> +++ b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
> @@ -399,6 +399,126 @@ csiphy_lane_regs lane_regs_sm8250[] = {
> {0x0884, 0x01, 0x00, CSIPHY_DEFAULT_PARAMS},
> };
>
> +/* GEN2 1.2.3 2PH */
> +static const struct
> +csiphy_lane_regs lane_regs_sm6350[] = {
> + {0x0030, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0904, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0910, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0900, 0x0F, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0908, 0x06, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0904, 0x07, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x002C, 0x01, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0034, 0x0F, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0010, 0x50, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x001C, 0x0A, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0014, 0x60, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0028, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x003C, 0xB8, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0000, 0x91, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0004, 0x0C, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0020, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0008, 0x10, 0x00, CSIPHY_SETTLE_CNT_LOWER_BYTE},
> + {0x0010, 0x52, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0038, 0xFE, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x005C, 0xC0, 0x00, CSIPHY_SKEW_CAL},
> + {0x0060, 0x0D, 0x00, CSIPHY_SKEW_CAL},
> + {0x0800, 0x02, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0000, 0x00, 0x00, CSIPHY_DNP_PARAMS},
> + {0x0730, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0C84, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0C90, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0C80, 0x0F, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0C88, 0x06, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0C84, 0x07, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x072C, 0x01, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0734, 0x0F, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0710, 0x50, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x071C, 0x0A, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0714, 0x60, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0728, 0x04, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x073C, 0xB8, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0700, 0x80, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0704, 0x0C, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0720, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0708, 0x04, 0x00, CSIPHY_SETTLE_CNT_LOWER_BYTE},
> + {0x070c, 0xFF, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0710, 0x52, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0738, 0x1F, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0800, 0x02, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0000, 0x00, 0x00, CSIPHY_DNP_PARAMS},
> + {0x0000, 0x00, 0x00, CSIPHY_DNP_PARAMS},
> + {0x0230, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0A04, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0A10, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0A00, 0x0F, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0A08, 0x06, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0A04, 0x07, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x022C, 0x01, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0234, 0x0F, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0210, 0x50, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x021C, 0x0A, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0214, 0x60, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0228, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x023C, 0xB8, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0200, 0x91, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0204, 0x0C, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0220, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0208, 0x04, 0x00, CSIPHY_SETTLE_CNT_LOWER_BYTE},
> + {0x0210, 0x52, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0238, 0xFE, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x025C, 0xC0, 0x00, CSIPHY_SKEW_CAL},
> + {0x0260, 0x0D, 0x00, CSIPHY_SKEW_CAL},
> + {0x0800, 0x02, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0000, 0x00, 0x00, CSIPHY_DNP_PARAMS},
> + {0x0430, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0B04, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0B10, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0B00, 0x0F, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0B08, 0x06, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0B04, 0x07, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x042C, 0x01, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0434, 0x0F, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0410, 0x50, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x041C, 0x0A, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0414, 0x60, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0428, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x043C, 0xB8, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0400, 0x91, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0404, 0x0C, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0420, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0408, 0x04, 0x00, CSIPHY_SETTLE_CNT_LOWER_BYTE},
> + {0x0410, 0x52, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0438, 0xFE, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x045C, 0xC0, 0x00, CSIPHY_SKEW_CAL},
> + {0x0460, 0x0D, 0x00, CSIPHY_SKEW_CAL},
> + {0x0800, 0x02, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0000, 0x00, 0x00, CSIPHY_DNP_PARAMS},
> + {0x0630, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0C04, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0C10, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0C00, 0x0F, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0C08, 0x06, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0C04, 0x07, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x062C, 0x01, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0634, 0x0F, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0610, 0x50, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x061C, 0x0A, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0614, 0x60, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0628, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x063C, 0xB8, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0600, 0x91, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0604, 0x0C, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0620, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0608, 0x04, 0x00, CSIPHY_SETTLE_CNT_LOWER_BYTE},
> + {0x0610, 0x52, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0638, 0xFE, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x065C, 0xC0, 0x00, CSIPHY_SKEW_CAL},
> + {0x0660, 0x0D, 0x00, CSIPHY_SKEW_CAL},
> + {0x0800, 0x02, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0000, 0x00, 0x00, CSIPHY_DNP_PARAMS},
> +};
> +
> /* 14nm 2PH v 2.0.1 2p5Gbps 4 lane DPHY mode */
> static const struct
> csiphy_lane_regs lane_regs_qcm2290[] = {
> @@ -1011,6 +1131,7 @@ static bool csiphy_is_gen2(u32 version)
> switch (version) {
> case CAMSS_2290:
> case CAMSS_6150:
> + case CAMSS_6350:
> case CAMSS_7280:
> case CAMSS_8250:
> case CAMSS_8280XP:
> @@ -1105,6 +1226,10 @@ static int csiphy_init(struct csiphy_device *csiphy)
> regs->lane_regs = &lane_regs_qcm2290[0];
> regs->lane_array_size = ARRAY_SIZE(lane_regs_qcm2290);
> break;
> + case CAMSS_6350:
> + regs->lane_regs = &lane_regs_sm6350[0];
> + regs->lane_array_size = ARRAY_SIZE(lane_regs_sm6350);
> + break;
> case CAMSS_7280:
> case CAMSS_8250:
> regs->lane_regs = &lane_regs_sm8250[0];
> diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c
> index 5baf0e3d4bc4..7dc937d018f6 100644
> --- a/drivers/media/platform/qcom/camss/camss-vfe.c
> +++ b/drivers/media/platform/qcom/camss/camss-vfe.c
> @@ -343,6 +343,7 @@ static u32 vfe_src_pad_code(struct vfe_line *line, u32 sink_code,
> case CAMSS_660:
> case CAMSS_2290:
> case CAMSS_6150:
> + case CAMSS_6350:
> case CAMSS_7280:
> case CAMSS_8x96:
> case CAMSS_8250:
> @@ -2003,6 +2004,7 @@ static int vfe_bpl_align(struct vfe_device *vfe)
>
> switch (vfe->camss->res->version) {
> case CAMSS_6150:
> + case CAMSS_6350:
> case CAMSS_7280:
> case CAMSS_8250:
> case CAMSS_8280XP:
> diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
> index 00b87fd9afbd..b53fb94ab54a 100644
> --- a/drivers/media/platform/qcom/camss/camss.c
> +++ b/drivers/media/platform/qcom/camss/camss.c
> @@ -1703,6 +1703,253 @@ static const struct resources_icc icc_res_sm6150[] = {
> },
> };
>
> +static const struct camss_subdev_resources csiphy_res_sm6350[] = {
> + /* CSIPHY0 */
> + {
> + .regulators = {
> + { .supply = "vdd-csiphy0-0p9", .init_load_uA = 80000 },
> + { .supply = "vdd-csiphy0-1p25", .init_load_uA = 80000 },
> + },
> + .clock = { "csiphy0", "csiphy0_timer" },
> + .clock_rate = { { 300000000, 384000000, 400000000 },
> + { 300000000 } },
> + .reg = { "csiphy0" },
> + .interrupt = { "csiphy0" },
> + .csiphy = {
> + .id = 0,
> + .hw_ops = &csiphy_ops_3ph_1_0,
> + .formats = &csiphy_formats_sdm845
> + }
> + },
> + /* CSIPHY1 */
> + {
> + .regulators = {
> + { .supply = "vdd-csiphy1-0p9", .init_load_uA = 80000 },
> + { .supply = "vdd-csiphy1-1p25", .init_load_uA = 80000 },
> + },
> + .clock = { "csiphy1", "csiphy1_timer" },
> + .clock_rate = { { 300000000, 384000000, 400000000 },
> + { 300000000 } },
> + .reg = { "csiphy1" },
> + .interrupt = { "csiphy1" },
> + .csiphy = {
> + .id = 1,
> + .hw_ops = &csiphy_ops_3ph_1_0,
> + .formats = &csiphy_formats_sdm845
> + }
> + },
> + /* CSIPHY2 */
> + {
> + .regulators = {
> + { .supply = "vdd-csiphy2-0p9", .init_load_uA = 80000 },
> + { .supply = "vdd-csiphy2-1p25", .init_load_uA = 80000 },
> + },
> + .clock = { "csiphy2", "csiphy2_timer" },
> + .clock_rate = { { 300000000, 384000000, 400000000 },
> + { 300000000 } },
> + .reg = { "csiphy2" },
> + .interrupt = { "csiphy2" },
> + .csiphy = {
> + .id = 2,
> + .hw_ops = &csiphy_ops_3ph_1_0,
> + .formats = &csiphy_formats_sdm845
> + }
> + },
> + /* CSIPHY3 */
> + {
> + .regulators = {
> + { .supply = "vdd-csiphy3-0p9", .init_load_uA = 80000 },
> + { .supply = "vdd-csiphy3-1p25", .init_load_uA = 80000 },
> + },
> + .clock = { "csiphy3", "csiphy3_timer" },
> + .clock_rate = { { 300000000, 384000000, 400000000 },
> + { 300000000 } },
> + .reg = { "csiphy3" },
> + .interrupt = { "csiphy3" },
> + .csiphy = {
> + .id = 3,
> + .hw_ops = &csiphy_ops_3ph_1_0,
> + .formats = &csiphy_formats_sdm845
> + }
> + }
> +};
> +
> +static const struct camss_subdev_resources csid_res_sm6350[] = {
> + /* CSID0 */
> + {
> + .regulators = {},
> + .clock = { "vfe0_csid", "vfe0_cphy_rx", "vfe0" },
> + .clock_rate = { { 300000000, 384000000, 400000000 },
> + { 0 },
> + { 320000000, 404000000, 480000000, 600000000 } },
> + .reg = { "csid0" },
> + .interrupt = { "csid0" },
> + .csid = {
> + .hw_ops = &csid_ops_gen2,
> + .parent_dev_ops = &vfe_parent_dev_ops,
> + .formats = &csid_formats_gen2
> + }
> + },
> + /* CSID1 */
> + {
> + .regulators = {},
> + .clock = { "vfe1_csid", "vfe1_cphy_rx", "vfe1" },
> + .clock_rate = { { 300000000, 384000000, 400000000 },
> + { 0 },
> + { 320000000, 404000000, 480000000, 600000000 } },
> + .reg = { "csid1" },
> + .interrupt = { "csid1" },
> + .csid = {
> + .hw_ops = &csid_ops_gen2,
> + .parent_dev_ops = &vfe_parent_dev_ops,
> + .formats = &csid_formats_gen2
> + }
> + },
> + /* CSID2 */
> + {
> + .regulators = {},
> + .clock = { "vfe2_csid", "vfe2_cphy_rx", "vfe2" },
> + .clock_rate = { { 300000000, 384000000, 400000000 },
> + { 0 },
> + { 320000000, 404000000, 480000000, 600000000 } },
> + .reg = { "csid2" },
> + .interrupt = { "csid2" },
> + .csid = {
> + .hw_ops = &csid_ops_gen2,
> + .parent_dev_ops = &vfe_parent_dev_ops,
> + .formats = &csid_formats_gen2
> + }
> + },
> + /* CSID3 (lite) */
> + {
> + .regulators = {},
> + .clock = { "vfe_lite_csid", "vfe_lite_cphy_rx", "vfe_lite" },
> + .clock_rate = { { 300000000, 384000000, 400000000 },
> + { 0 },
> + { 400000000, 480000000 } },
> + .reg = { "csid_lite" },
> + .interrupt = { "csid_lite" },
> + .csid = {
> + .is_lite = true,
> + .hw_ops = &csid_ops_gen2,
> + .parent_dev_ops = &vfe_parent_dev_ops,
> + .formats = &csid_formats_gen2
> + }
> + }
> +};
> +
> +static const struct camss_subdev_resources vfe_res_sm6350[] = {
> + /* VFE0 */
> + {
> + .regulators = {},
> + .clock = { "cpas_ahb", "camnoc_axi", "vfe0",
> + "vfe0_axi", "cam_axi", "soc_ahb" },
> + .clock_rate = { { 19200000 },
> + { 0 },
> + { 320000000, 404000000, 480000000, 600000000 },
> + { 0 },
> + { 0 },
> + { 0 } },
> + .reg = { "vfe0" },
> + .interrupt = { "vfe0" },
> + .vfe = {
> + .line_num = 3,
> + .has_pd = true,
> + .pd_name = "ife0",
> + .hw_ops = &vfe_ops_170,
> + .formats_rdi = &vfe_formats_rdi_845,
> + .formats_pix = &vfe_formats_pix_845
> + }
> + },
> + /* VFE1 */
> + {
> + .regulators = {},
> + .clock = { "cpas_ahb", "camnoc_axi", "vfe1",
> + "vfe1_axi", "cam_axi", "soc_ahb" },
> + .clock_rate = { { 19200000 },
> + { 0 },
> + { 320000000, 404000000, 480000000, 600000000 },
> + { 0 },
> + { 0 },
> + { 0 } },
> + .reg = { "vfe1" },
> + .interrupt = { "vfe1" },
> + .vfe = {
> + .line_num = 3,
> + .has_pd = true,
> + .pd_name = "ife1",
> + .hw_ops = &vfe_ops_170,
> + .formats_rdi = &vfe_formats_rdi_845,
> + .formats_pix = &vfe_formats_pix_845
> + }
> + },
> + /* VFE2 */
> + {
> + .regulators = {},
> + .clock = { "cpas_ahb", "camnoc_axi", "vfe2",
> + "vfe2_axi", "cam_axi", "soc_ahb" },
> + .clock_rate = { { 19200000 },
> + { 0 },
> + { 320000000, 404000000, 480000000, 600000000 },
> + { 0 },
> + { 0 },
> + { 0 } },
> + .reg = { "vfe2" },
> + .interrupt = { "vfe2" },
> + .vfe = {
> + .line_num = 3,
> + .has_pd = true,
> + .pd_name = "ife2",
> + .hw_ops = &vfe_ops_170,
> + .formats_rdi = &vfe_formats_rdi_845,
> + .formats_pix = &vfe_formats_pix_845
> + }
> + },
> + /* VFE3 (lite) */
> + {
> + .regulators = {},
> + .clock = { "cpas_ahb", "camnoc_axi", "vfe_lite",
> + "cam_axi", "soc_ahb" },
> + .clock_rate = { { 19200000 },
> + { 0 },
> + { 400000000, 480000000 },
> + { 0 },
> + { 0 } },
> + .reg = { "vfe_lite" },
> + .interrupt = { "vfe_lite" },
> + .vfe = {
> + .is_lite = true,
> + .line_num = 4,
> + .hw_ops = &vfe_ops_170,
> + .formats_rdi = &vfe_formats_rdi_845,
> + .formats_pix = &vfe_formats_pix_845
> + }
> + },
> +};
> +
> +static const struct resources_icc icc_res_sm6350[] = {
> + {
> + .name = "ahb",
> + .icc_bw_tbl.avg = 0,
> + .icc_bw_tbl.peak = 300000,
> + },
> + {
> + .name = "hf_mnoc",
> + .icc_bw_tbl.avg = 2097152,
> + .icc_bw_tbl.peak = 2097152,
> + },
> + {
> + .name = "sf_mnoc",
> + .icc_bw_tbl.avg = 2097152,
> + .icc_bw_tbl.peak = 2097152,
> + },
> + {
> + .name = "sf_icp_mnoc",
> + .icc_bw_tbl.avg = 2097152,
> + .icc_bw_tbl.peak = 2097152,
> + },
> +};
> +
> static const struct camss_subdev_resources csiphy_res_8250[] = {
> /* CSIPHY0 */
> {
> @@ -5233,6 +5480,19 @@ static const struct camss_resources sm6150_resources = {
> .vfe_num = ARRAY_SIZE(vfe_res_sm6150),
> };
>
> +static const struct camss_resources sm6350_resources = {
> + .version = CAMSS_6350,
> + .pd_name = "top",
> + .csiphy_res = csiphy_res_sm6350,
> + .csid_res = csid_res_sm6350,
> + .vfe_res = vfe_res_sm6350,
> + .icc_res = icc_res_sm6350,
> + .icc_path_num = ARRAY_SIZE(icc_res_sm6350),
> + .csiphy_num = ARRAY_SIZE(csiphy_res_sm6350),
> + .csid_num = ARRAY_SIZE(csid_res_sm6350),
> + .vfe_num = ARRAY_SIZE(vfe_res_sm6350),
> +};
> +
> static const struct camss_resources sm8250_resources = {
> .version = CAMSS_8250,
> .pd_name = "top",
> @@ -5329,6 +5589,7 @@ static const struct of_device_id camss_dt_match[] = {
> { .compatible = "qcom,sdm670-camss", .data = &sdm670_resources },
> { .compatible = "qcom,sdm845-camss", .data = &sdm845_resources },
> { .compatible = "qcom,sm6150-camss", .data = &sm6150_resources },
> + { .compatible = "qcom,sm6350-camss", .data = &sm6350_resources },
> { .compatible = "qcom,sm8250-camss", .data = &sm8250_resources },
> { .compatible = "qcom,sm8550-camss", .data = &sm8550_resources },
> { .compatible = "qcom,sm8650-camss", .data = &sm8650_resources },
> diff --git a/drivers/media/platform/qcom/camss/camss.h b/drivers/media/platform/qcom/camss/camss.h
> index 6d048414c919..d323c105d185 100644
> --- a/drivers/media/platform/qcom/camss/camss.h
> +++ b/drivers/media/platform/qcom/camss/camss.h
> @@ -81,6 +81,7 @@ enum camss_version {
> CAMSS_660,
> CAMSS_2290,
> CAMSS_6150,
> + CAMSS_6350,
> CAMSS_7280,
> CAMSS_8x16,
> CAMSS_8x39,
>
> --
> 2.53.0
>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
next prev parent reply other threads:[~2026-02-14 13:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-13 13:15 [PATCH v3 0/3] Add CAMSS support for SM6350 Luca Weiss
2026-02-13 13:15 ` [PATCH v3 1/3] dt-bindings: media: camss: Add qcom,sm6350-camss Luca Weiss
2026-02-14 8:37 ` Krzysztof Kozlowski
2026-02-14 13:05 ` Bryan O'Donoghue
2026-02-17 22:18 ` Vijay Kumar Tumati
2026-02-18 20:10 ` Krzysztof Kozlowski
2026-02-18 20:47 ` Vijay Kumar Tumati
2026-02-26 9:44 ` Krzysztof Kozlowski
2026-02-13 13:15 ` [PATCH v3 2/3] media: qcom: camss: Add SM6350 support Luca Weiss
2026-02-14 13:08 ` Bryan O'Donoghue [this message]
2026-02-15 12:46 ` David Heidelberg
2026-02-16 10:02 ` Bryan O'Donoghue
2026-02-13 13:15 ` [PATCH v3 3/3] arm64: dts: qcom: sm6350: Add CAMSS node Luca Weiss
2026-02-16 11:04 ` [PATCH v3 0/3] Add CAMSS support for SM6350 Konrad Dybcio
2026-02-17 11:56 ` Imran Shaik
2026-02-17 12:01 ` Konrad Dybcio
2026-02-18 18:12 ` Imran Shaik
2026-02-24 13:43 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f8a6e03-b056-451f-a1b9-ec5fd160eabd@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=mchehab@kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=todor.too@gmail.com \
--cc=vladimir.zapolskiy@linaro.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox