From: Daniel Walker <dwalker@codeaurora.org>
To: Tomasz Sterna <tomek@xiaoka.com>
Cc: linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] [Streak] Add workaround for TTY kernel OOPS at the cost of performance.
Date: Thu, 30 Sep 2010 16:04:14 -0700 [thread overview]
Message-ID: <1285887854.14953.46.camel@c-dwalke-linux.qualcomm.com> (raw)
In-Reply-To: <1285886565.11486.26.camel@wing>
On Fri, 2010-10-01 at 00:42 +0200, Tomasz Sterna wrote:
> The current framebuffer driver oopses when used as a console (kernel
> parameter: console=tty ).
> Here is a patch that makes it work - at the cost of performance.
>
> Signed-off-by: Bradley Smith <brad@brad-smith.co.uk>
> (cherry picked from commit 28d06a6366c851c6e0c5b954353bf82cb641d4e7)
Your submitting this for Bradley? If so you need to have a line like
this at the top,
From: Bradley Smith <brad@brad-smith.co.uk>
That denotes that your not the author of the commit..
Also this is against v2.6.36-rcX right ?
> ---
> drivers/video/msm/Kconfig | 4 ++++
> drivers/video/msm/mdp.c | 20 ++++++++++++++++++++
> drivers/video/msm/mdp.h | 3 +++
> drivers/video/msm/mdp_dma.c | 15 +++++++++++++++
> drivers/video/msm/mdp_dma_s.c | 28 ++++++++++++++++++++++++++++
> drivers/video/msm/msm_fb.c | 2 ++
> drivers/video/msm/msm_fb.h | 14 ++++++++++++++
> 7 files changed, 86 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/video/msm/Kconfig b/drivers/video/msm/Kconfig
> index e887a2d..cff8435 100644
> --- a/drivers/video/msm/Kconfig
> +++ b/drivers/video/msm/Kconfig
> @@ -14,3 +14,7 @@ config FB_MSM_LCDC
> depends on FB_MSM && MSM_MDP31
> default y
>
> +config MSM_FB_TTY_WORKAROUND
> + bool "Workaround TTY kernel OOPS at the cost of performance"
> + depends on FB_MSM
> + default n
We can't have this selectable , especially if the kernel will OOPS if
it's off ..
I need a better description of the problem. What was the oops? This
looks DMA related, is that accurate and could you expand on why DMA was
causing a problem?
Daniel
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2010-09-30 23:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-30 22:42 [PATCH] [Streak] Add workaround for TTY kernel OOPS at the cost of performance Tomasz Sterna
2010-09-30 23:04 ` Daniel Walker [this message]
2010-10-01 8:52 ` Tomasz Sterna
2010-10-01 15:47 ` Daniel Walker
2010-10-01 20:07 ` Tomasz Sterna
2010-10-02 0:26 ` Daniel Walker
2010-10-01 21:11 ` Tomasz Sterna
[not found] ` <AANLkTimVpsmWLpXwuLyFgC3sOSMVCbF38DNRL13_5bgk@mail.gmail.com>
2010-10-02 10:14 ` Bradley Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285887854.14953.46.camel@c-dwalke-linux.qualcomm.com \
--to=dwalker@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=tomek@xiaoka.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox