* [PATCH v2 0/3] Add ethernet dts schema for qcs615/qcs8300
@ 2024-10-17 9:52 Yijie Yang
2024-10-17 9:52 ` [PATCH v2 1/3] dt-bindings: net: qcom,ethqos: add description for qcs615 Yijie Yang
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Yijie Yang @ 2024-10-17 9:52 UTC (permalink / raw)
To: Vinod Koul, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bhupesh Sharma, Kishon Vijay Abraham I, Bartosz Golaszewski
Cc: netdev, linux-arm-msm, devicetree, linux-kernel, linux-phy,
quic_tingweiz, quic_aiquny, Yijie Yang, Krzysztof Kozlowski
Document the ethernet and SerDes compatible for qcs8300. This platform
shares the same EMAC and SerDes as sa8775p, so the compatible fallback to
it.
Document the ethernet compatible for qcs615. This platform shares the
same EMAC as sm8150, so the compatible fallback to it.
Document the compatible for revision 2 of the qcs8300-ride board.
Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com>
---
This patch series depends on below patch series:
https://lore.kernel.org/all/20240925-qcs8300_initial_dtsi-v2-0-494c40fa2a42@quicinc.com/
https://lore.kernel.org/all/20240926-add_initial_support_for_qcs615-v3-0-e37617e91c62@quicinc.com/
Changes in v2:
- Adjust the position of the EMAC compatible fallback for qcs8300 in the YAML file according to the order.
- Link to v1: https://lore.kernel.org/r/20241010-schema-v1-0-98b2d0a2f7a2@quicinc.com
---
Yijie Yang (3):
dt-bindings: net: qcom,ethqos: add description for qcs615
dt-bindings: phy: describe the Qualcomm SGMII PHY
dt-bindings: net: qcom,ethqos: add description for qcs8300
.../devicetree/bindings/net/qcom,ethqos.yaml | 19 ++++++++++++++-----
.../bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml | 7 ++++++-
2 files changed, 20 insertions(+), 6 deletions(-)
---
base-commit: 40e0c9d414f57d450e3ad03c12765e797fc3fede
change-id: 20241010-schema-50b0b777c28b
Best regards,
--
Yijie Yang <quic_yijiyang@quicinc.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 1/3] dt-bindings: net: qcom,ethqos: add description for qcs615
2024-10-17 9:52 [PATCH v2 0/3] Add ethernet dts schema for qcs615/qcs8300 Yijie Yang
@ 2024-10-17 9:52 ` Yijie Yang
2024-10-17 9:52 ` [PATCH v2 2/3] dt-bindings: phy: describe the Qualcomm SGMII PHY Yijie Yang
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Yijie Yang @ 2024-10-17 9:52 UTC (permalink / raw)
To: Vinod Koul, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bhupesh Sharma, Kishon Vijay Abraham I, Bartosz Golaszewski
Cc: netdev, linux-arm-msm, devicetree, linux-kernel, linux-phy,
quic_tingweiz, quic_aiquny, Yijie Yang, Krzysztof Kozlowski
Add compatible for the MAC controller on qcs615 platform.
Since qcs615 shares the same EMAC as sm8150, so it fallback to that
compatible.
Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
index 6672327358bc13f4a464c845d242d32569bf66a7..8cf29493b8228967156758c0363a978daec84152 100644
--- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
+++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
@@ -18,11 +18,16 @@ allOf:
properties:
compatible:
- enum:
- - qcom,qcs404-ethqos
- - qcom,sa8775p-ethqos
- - qcom,sc8280xp-ethqos
- - qcom,sm8150-ethqos
+ oneOf:
+ - items:
+ - enum:
+ - qcom,qcs615-ethqos
+ - const: qcom,sm8150-ethqos
+ - enum:
+ - qcom,qcs404-ethqos
+ - qcom,sa8775p-ethqos
+ - qcom,sc8280xp-ethqos
+ - qcom,sm8150-ethqos
reg:
maxItems: 2
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 2/3] dt-bindings: phy: describe the Qualcomm SGMII PHY
2024-10-17 9:52 [PATCH v2 0/3] Add ethernet dts schema for qcs615/qcs8300 Yijie Yang
2024-10-17 9:52 ` [PATCH v2 1/3] dt-bindings: net: qcom,ethqos: add description for qcs615 Yijie Yang
@ 2024-10-17 9:52 ` Yijie Yang
2024-10-17 9:52 ` [PATCH v2 3/3] dt-bindings: net: qcom,ethqos: add description for qcs8300 Yijie Yang
2024-10-28 11:04 ` [PATCH v2 0/3] Add ethernet dts schema for qcs615/qcs8300 Krzysztof Kozlowski
3 siblings, 0 replies; 6+ messages in thread
From: Yijie Yang @ 2024-10-17 9:52 UTC (permalink / raw)
To: Vinod Koul, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bhupesh Sharma, Kishon Vijay Abraham I, Bartosz Golaszewski
Cc: netdev, linux-arm-msm, devicetree, linux-kernel, linux-phy,
quic_tingweiz, quic_aiquny, Yijie Yang, Krzysztof Kozlowski
Describe the SGMII/SerDes PHY present on the qcs8300 platforms. Since
qcs8300 shares the same SerDes as sa8775p, so it fallback to the
compatible.
Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml
index b9107759b2a51738d884f6bdce16bf0bff644056..90fc8c039219c739eae05cc17108a9a2fc6193df 100644
--- a/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml
@@ -15,7 +15,12 @@ description:
properties:
compatible:
- const: qcom,sa8775p-dwmac-sgmii-phy
+ oneOf:
+ - items:
+ - enum:
+ - qcom,qcs8300-dwmac-sgmii-phy
+ - const: qcom,sa8775p-dwmac-sgmii-phy
+ - const: qcom,sa8775p-dwmac-sgmii-phy
reg:
items:
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 3/3] dt-bindings: net: qcom,ethqos: add description for qcs8300
2024-10-17 9:52 [PATCH v2 0/3] Add ethernet dts schema for qcs615/qcs8300 Yijie Yang
2024-10-17 9:52 ` [PATCH v2 1/3] dt-bindings: net: qcom,ethqos: add description for qcs615 Yijie Yang
2024-10-17 9:52 ` [PATCH v2 2/3] dt-bindings: phy: describe the Qualcomm SGMII PHY Yijie Yang
@ 2024-10-17 9:52 ` Yijie Yang
2024-10-28 11:04 ` [PATCH v2 0/3] Add ethernet dts schema for qcs615/qcs8300 Krzysztof Kozlowski
3 siblings, 0 replies; 6+ messages in thread
From: Yijie Yang @ 2024-10-17 9:52 UTC (permalink / raw)
To: Vinod Koul, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bhupesh Sharma, Kishon Vijay Abraham I, Bartosz Golaszewski
Cc: netdev, linux-arm-msm, devicetree, linux-kernel, linux-phy,
quic_tingweiz, quic_aiquny, Yijie Yang, Krzysztof Kozlowski
Add compatible for the MAC controller on qcs8300 platforms.
Since qcs8300 shares the same EMAC as sa8775p, so it fallback to the
compatible.
Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
index 8cf29493b8228967156758c0363a978daec84152..0bcd593a7bd093d4475908d82585c36dd6b3a284 100644
--- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
+++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
@@ -19,6 +19,10 @@ allOf:
properties:
compatible:
oneOf:
+ - items:
+ - enum:
+ - qcom,qcs8300-ethqos
+ - const: qcom,sa8775p-ethqos
- items:
- enum:
- qcom,qcs615-ethqos
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 0/3] Add ethernet dts schema for qcs615/qcs8300
2024-10-17 9:52 [PATCH v2 0/3] Add ethernet dts schema for qcs615/qcs8300 Yijie Yang
` (2 preceding siblings ...)
2024-10-17 9:52 ` [PATCH v2 3/3] dt-bindings: net: qcom,ethqos: add description for qcs8300 Yijie Yang
@ 2024-10-28 11:04 ` Krzysztof Kozlowski
2024-10-29 2:17 ` Yijie Yang
3 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2024-10-28 11:04 UTC (permalink / raw)
To: Yijie Yang, Vinod Koul, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bhupesh Sharma, Kishon Vijay Abraham I,
Bartosz Golaszewski
Cc: netdev, linux-arm-msm, devicetree, linux-kernel, linux-phy,
quic_tingweiz, quic_aiquny, Krzysztof Kozlowski
On 17/10/2024 11:52, Yijie Yang wrote:
> Document the ethernet and SerDes compatible for qcs8300. This platform
> shares the same EMAC and SerDes as sa8775p, so the compatible fallback to
> it.
> Document the ethernet compatible for qcs615. This platform shares the
> same EMAC as sm8150, so the compatible fallback to it.
> Document the compatible for revision 2 of the qcs8300-ride board.
>
> Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com>
> ---
> This patch series depends on below patch series:
> https://lore.kernel.org/all/20240925-qcs8300_initial_dtsi-v2-0-494c40fa2a42@quicinc.com/
> https://lore.kernel.org/all/20240926-add_initial_support_for_qcs615-v3-0-e37617e91c62@quicinc.com/
So it cannot be merged...
Instead please decouple your works. I don't get why do you claim there
is dependency in the first place, but anyway. Fix up your patchsets to
fix that (if there is something to fix).
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 0/3] Add ethernet dts schema for qcs615/qcs8300
2024-10-28 11:04 ` [PATCH v2 0/3] Add ethernet dts schema for qcs615/qcs8300 Krzysztof Kozlowski
@ 2024-10-29 2:17 ` Yijie Yang
0 siblings, 0 replies; 6+ messages in thread
From: Yijie Yang @ 2024-10-29 2:17 UTC (permalink / raw)
To: Krzysztof Kozlowski, Vinod Koul, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bhupesh Sharma, Kishon Vijay Abraham I,
Bartosz Golaszewski
Cc: netdev, linux-arm-msm, devicetree, linux-kernel, linux-phy,
quic_tingweiz, quic_aiquny, Krzysztof Kozlowski
On 2024-10-28 19:04, Krzysztof Kozlowski wrote:
> On 17/10/2024 11:52, Yijie Yang wrote:
>> Document the ethernet and SerDes compatible for qcs8300. This platform
>> shares the same EMAC and SerDes as sa8775p, so the compatible fallback to
>> it.
>> Document the ethernet compatible for qcs615. This platform shares the
>> same EMAC as sm8150, so the compatible fallback to it.
>> Document the compatible for revision 2 of the qcs8300-ride board.
>>
>> Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com>
>> ---
>> This patch series depends on below patch series:
>> https://lore.kernel.org/all/20240925-qcs8300_initial_dtsi-v2-0-494c40fa2a42@quicinc.com/
>> https://lore.kernel.org/all/20240926-add_initial_support_for_qcs615-v3-0-e37617e91c62@quicinc.com/
>
> So it cannot be merged...
>
> Instead please decouple your works. I don't get why do you claim there
> is dependency in the first place, but anyway. Fix up your patchsets to
> fix that (if there is something to fix).
>
Actually, the dependency is unnecessary here. I will remove it together
with the merged patch in the upcoming version.
> Best regards,
> Krzysztof
>
--
Best Regards,
Yijie
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-10-29 2:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-17 9:52 [PATCH v2 0/3] Add ethernet dts schema for qcs615/qcs8300 Yijie Yang
2024-10-17 9:52 ` [PATCH v2 1/3] dt-bindings: net: qcom,ethqos: add description for qcs615 Yijie Yang
2024-10-17 9:52 ` [PATCH v2 2/3] dt-bindings: phy: describe the Qualcomm SGMII PHY Yijie Yang
2024-10-17 9:52 ` [PATCH v2 3/3] dt-bindings: net: qcom,ethqos: add description for qcs8300 Yijie Yang
2024-10-28 11:04 ` [PATCH v2 0/3] Add ethernet dts schema for qcs615/qcs8300 Krzysztof Kozlowski
2024-10-29 2:17 ` Yijie Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox