From: Tirupathi Reddy <tirupath@codeaurora.org>
To: broonie@kernel.org, lgirdwood@gmail.com
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Tirupathi Reddy <tirupath@codeaurora.org>
Subject: [PATCH V1] regulator: core: Fix voltage change propagations to supply regulators
Date: Thu, 25 May 2017 15:33:17 +0530 [thread overview]
Message-ID: <1495706597-10605-1-git-send-email-tirupath@codeaurora.org> (raw)
Some regulators support get_voltage and some support get_voltage_sel
operations. Do voltage change propagation only when the current
regulator has a minimum dropout voltage specified or if the current
regulator lacks both get_voltage and get_voltage_sel operations.
Signed-off-by: Tirupathi Reddy <tirupath@codeaurora.org>
---
drivers/regulator/core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index c0d9ae8..9fecbd4 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -2938,7 +2938,8 @@ static int regulator_set_voltage_unlocked(struct regulator *regulator,
if (rdev->supply &&
regulator_ops_is_valid(rdev->supply->rdev,
REGULATOR_CHANGE_VOLTAGE) &&
- (rdev->desc->min_dropout_uV || !rdev->desc->ops->get_voltage)) {
+ (rdev->desc->min_dropout_uV || !(rdev->desc->ops->get_voltage ||
+ rdev->desc->ops->get_voltage_sel))) {
int current_supply_uV;
int selector;
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
next reply other threads:[~2017-05-25 10:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-25 10:03 Tirupathi Reddy [this message]
2017-06-05 10:36 ` [PATCH V1] regulator: core: Fix voltage change propagations to supply regulators Tirupathi Reddy T
2017-06-06 15:41 ` Mark Brown
2017-06-28 19:49 ` Applied "regulator: core: Fix voltage change propagations to supply regulators" to the regulator tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495706597-10605-1-git-send-email-tirupath@codeaurora.org \
--to=tirupath@codeaurora.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox