Re: [PATCH v2 09/14] ASoC: dt-bindings: qcom,q6dsp-lpass-ports: Add Senary MI2S port

[Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>]

On 2/24/26 7:14 AM, Krzysztof Kozlowski wrote:
> On Mon, Feb 23, 2026 at 06:07:35PM +0000, Srinivas Kandagatla wrote:
>> From: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
>>
>> Qualcomm platforms support the Senary MI2S interface for audio playback
>> and capture. Add a new definitions for the Senary MI2S RX and TX ports,
>> which are required for boards that utilize the Senary MI2S interface
>> for audio routing.
>>
>> Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
>> ---
>>  include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h | 2 ++
>>  sound/soc/qcom/common.h                            | 2 +-
>>  2 files changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h b/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h
>> index e27a31ece1f2..45850f2d4342 100644
>> --- a/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h
>> +++ b/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h
>> @@ -150,6 +150,8 @@
>>  #define LPI_MI2S_TX_3		144
>>  #define LPI_MI2S_RX_4		145
>>  #define LPI_MI2S_TX_4		146
>> +#define SENARY_MI2S_RX		147
>> +#define SENARY_MI2S_TX		148
>>  
>>  #define LPASS_CLK_ID_PRI_MI2S_IBIT	1
>>  #define LPASS_CLK_ID_PRI_MI2S_EBIT	2
>> diff --git a/sound/soc/qcom/common.h b/sound/soc/qcom/common.h
>> index 85ca73408151..ee6662885593 100644
>> --- a/sound/soc/qcom/common.h
>> +++ b/sound/soc/qcom/common.h
>> @@ -7,7 +7,7 @@
>>  #include <dt-bindings/sound/qcom,q6afe.h>
>>  #include <sound/soc.h>
>>  
>> -#define LPASS_MAX_PORT			(LPI_MI2S_TX_4 + 1)
>> +#define LPASS_MAX_PORT			(SENARY_MI2S_TX + 1)
> 
> Same problem as v1. You already changed this. Don't change the same line
> multiple times.
> 
> Anyway, this belongs to the code patch which uses the new LPASS_MAX_PORT
> (e.g. ues new SENARY bindings).

I understand your concern the reason this was changed in same series is
because the patches are from different team members and I did want to
keep them separate. I was also hoping that this patch would provide a
reference to anyone who is adding new ports, so that they do not forget
to update MAX_PORT.

I will move the defination of max to last patch, also remove this change
as part of dt-bindings patch.


--srini
> 
> Best regards,
> Krzysztof
>