From: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org
Cc: mohammad.rafi.shaik@oss.qualcomm.com,
linux-sound@vger.kernel.org, lgirdwood@gmail.com, perex@perex.cz,
tiwai@suse.com, johan@kernel.org,
dmitry.baryshkov@oss.qualcomm.com, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
srini@kernel.org
Subject: Re: [PATCH v2 11/14] ASoC: qcom: qdapm-lpass-dai: correct the error message
Date: Wed, 4 Mar 2026 11:11:19 +0000 [thread overview]
Message-ID: <263d4c1a-caa8-4870-b95b-fde7a11d2a6d@oss.qualcomm.com> (raw)
In-Reply-To: <c6ceab84-899d-476a-b2d8-e57028cc91dd@oss.qualcomm.com>
On 2/24/26 10:12 AM, Konrad Dybcio wrote:
> On 2/23/26 7:07 PM, Srinivas Kandagatla wrote:
>> Fix the error message to reflect the actual graph stop error
>> instead of graph close error.
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
>> ---
>> sound/soc/qcom/qdsp6/q6apm-lpass-dais.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c b/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c
>> index f68d4b4974f3..fc246485e326 100644
>> --- a/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c
>> +++ b/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c
>> @@ -150,7 +150,7 @@ static void q6apm_lpass_dai_shutdown(struct snd_pcm_substream *substream, struct
>> rc = q6apm_graph_stop(dai_data->graph[dai->id]);
>> dai_data->is_port_started[dai->id] = false;
>> if (rc < 0)
>> - dev_err(dai->dev, "fail to close APM port (%d)\n", rc);
>> + dev_err(dai->dev, "fail to stop APM port (%d)\n", rc);
>
> Might also make it "failed" while at it?
>
Yep
--srini
> Konrad
next prev parent reply other threads:[~2026-03-04 11:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 18:07 [PATCH v2 00/14] ASoC: qcom: q6dsp: few fixes and enhancements Srinivas Kandagatla
2026-02-23 18:07 ` [PATCH v2 01/14] ASoC: qcom: q6apm: move component registration to unmanaged version Srinivas Kandagatla
2026-02-23 18:07 ` [PATCH v2 02/14] ASoC: qcom: q6apm: remove child devices when apm is removed Srinivas Kandagatla
2026-02-23 18:07 ` [PATCH v2 03/14] ASoC: qcom: qdsp6: topology: check widget type before accessing data Srinivas Kandagatla
2026-02-23 18:07 ` [PATCH v2 04/14] ASoC: qcom: q6apm-lpass-dai: Fix multiple graph opens Srinivas Kandagatla
2026-02-23 18:07 ` [PATCH v2 05/14] ASoC: qcom: q6apm-dai: reset queue ptr on trigger stop Srinivas Kandagatla
2026-02-23 18:07 ` [PATCH v2 06/14] ASoC: qcom: common: validate cpu dai id during parsing Srinivas Kandagatla
2026-02-23 18:07 ` [PATCH v2 07/14] ASoC: dt-bindings: qcom: add LPASS LPI MI2S dai ids Srinivas Kandagatla
2026-02-24 7:13 ` Krzysztof Kozlowski
2026-02-24 7:15 ` Krzysztof Kozlowski
2026-02-23 18:07 ` [PATCH v2 08/14] ASoC: qcom: qdsp6: lpass-ports: add support for LPASS LPI MI2S dais Srinivas Kandagatla
2026-02-23 18:07 ` [PATCH v2 09/14] ASoC: dt-bindings: qcom,q6dsp-lpass-ports: Add Senary MI2S port Srinivas Kandagatla
2026-02-24 7:14 ` Krzysztof Kozlowski
2026-03-04 11:14 ` Srinivas Kandagatla
2026-02-23 18:07 ` [PATCH v2 10/14] ASoC: qcom: q6dsp: Add Senary MI2S audio interface support Srinivas Kandagatla
2026-02-23 18:07 ` [PATCH v2 11/14] ASoC: qcom: qdapm-lpass-dai: correct the error message Srinivas Kandagatla
2026-02-24 10:12 ` Konrad Dybcio
2026-03-04 11:11 ` Srinivas Kandagatla [this message]
2026-02-23 18:07 ` [PATCH v2 12/14] ASoC: qcom: q6apm-lpass-dai: move graph start to trigger Srinivas Kandagatla
2026-02-23 18:07 ` [PATCH v2 13/14] ASoC: qcom: qdsp6: remove search for module iid in hot path Srinivas Kandagatla
2026-02-23 18:07 ` [PATCH v2 14/14] ASoC: qcom: q6apm: Add support for early buffer mapping on DSP Srinivas Kandagatla
2026-02-24 10:16 ` Konrad Dybcio
2026-03-04 11:10 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=263d4c1a-caa8-4870-b95b-fde7a11d2a6d@oss.qualcomm.com \
--to=srinivas.kandagatla@oss.qualcomm.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=johan@kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mohammad.rafi.shaik@oss.qualcomm.com \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=srini@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox