[DPU PATCH] drm/msm/dsi: set encoder mode for DRM bridge explicitly

[DPU PATCH] drm/msm/dsi: set encoder mode for DRM bridge explicitly

[Abhinav Kumar]

Currently, DRM bridge for DPU relies on the default video
mode setting to set the encoder mode.

Add an explicit call to set the encoder mode for bridges.

Signed-off-by: Abhinav Kumar <abhinavk@codeaurora.org>
---
 drivers/gpu/drm/msm/dsi/dsi_manager.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/msm/dsi/dsi_manager.c b/drivers/gpu/drm/msm/dsi/dsi_manager.c
index 4cb1cb6..0607ad0 100644
--- a/drivers/gpu/drm/msm/dsi/dsi_manager.c
+++ b/drivers/gpu/drm/msm/dsi/dsi_manager.c
@@ -836,6 +836,7 @@ void msm_dsi_manager_attach_dsi_device(int id, u32 device_flags)
 	struct msm_drm_private *priv;
 	struct msm_kms *kms;
 	struct drm_encoder *encoder;
+	bool cmd_mode;
 
 	/*
 	 * drm_device pointer is assigned to msm_dsi only in the modeset_init
@@ -850,10 +851,11 @@ void msm_dsi_manager_attach_dsi_device(int id, u32 device_flags)
 	priv = dev->dev_private;
 	kms = priv->kms;
 	encoder = msm_dsi_get_encoder(msm_dsi);
+	cmd_mode = !(device_flags &
+				 MIPI_DSI_MODE_VIDEO);
 
 	if (encoder && kms->funcs->set_encoder_mode)
-		if (!(device_flags & MIPI_DSI_MODE_VIDEO))
-			kms->funcs->set_encoder_mode(kms, encoder, true);
+		kms->funcs->set_encoder_mode(kms, encoder, cmd_mode);
 }
 
 int msm_dsi_manager_register(struct msm_dsi *msm_dsi)
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [DPU PATCH] drm/msm/dsi: set encoder mode for DRM bridge explicitly

[Archit Taneja]

On Saturday 16 June 2018 11:26 AM, Abhinav Kumar wrote:
> Currently, DRM bridge for DPU relies on the default video
> mode setting to set the encoder mode.
> 
> Add an explicit call to set the encoder mode for bridges.

Reviewed-by: Archit Taneja <architt@codeauorora.org>

> 
> Signed-off-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
>   drivers/gpu/drm/msm/dsi/dsi_manager.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_manager.c b/drivers/gpu/drm/msm/dsi/dsi_manager.c
> index 4cb1cb6..0607ad0 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi_manager.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi_manager.c
> @@ -836,6 +836,7 @@ void msm_dsi_manager_attach_dsi_device(int id, u32 device_flags)
>   	struct msm_drm_private *priv;
>   	struct msm_kms *kms;
>   	struct drm_encoder *encoder;
> +	bool cmd_mode;
>   
>   	/*
>   	 * drm_device pointer is assigned to msm_dsi only in the modeset_init
> @@ -850,10 +851,11 @@ void msm_dsi_manager_attach_dsi_device(int id, u32 device_flags)
>   	priv = dev->dev_private;
>   	kms = priv->kms;
>   	encoder = msm_dsi_get_encoder(msm_dsi);
> +	cmd_mode = !(device_flags &
> +				 MIPI_DSI_MODE_VIDEO);
>   
>   	if (encoder && kms->funcs->set_encoder_mode)
> -		if (!(device_flags & MIPI_DSI_MODE_VIDEO))
> -			kms->funcs->set_encoder_mode(kms, encoder, true);
> +		kms->funcs->set_encoder_mode(kms, encoder, cmd_mode);
>   }
>   
>   int msm_dsi_manager_register(struct msm_dsi *msm_dsi)
> 
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno