public inbox for linux-arm-msm@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeffrey Hugo <jhugo@codeaurora.org>
To: andy.gross@linaro.org, david.brown@linaro.org
Cc: bjorn.andersson@linaro.org, robh+dt@kernel.org,
	mark.rutland@arm.com, linux-arm-msm@vger.kernel.org,
	linux-soc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Jeffrey Hugo <jhugo@codeaurora.org>
Subject: [PATCH v2 1/3] arm64: dts: qcom: msm8998: correct xo clock name
Date: Thu, 15 Nov 2018 13:44:53 -0700	[thread overview]
Message-ID: <1542314695-24071-2-git-send-email-jhugo@codeaurora.org> (raw)
In-Reply-To: <1542314695-24071-1-git-send-email-jhugo@codeaurora.org>

The root parent clock of most msm8998 clock is the "xo" clock.  The DT node
is incorrectly named "xo_board", which prevents Linux from correctly
parsing the clock tree, resulting in most clocks being unparented and
unable to be manipulated.  The end result is that we can't turn on clocks
for peripherals like SD, so init usually fails.

Fixes: 4807c71cc688 (arm64: dts: Add msm8998 SoC and MTP board support)
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
---
 arch/arm64/boot/dts/qcom/msm8998.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
index 78227cc..a948d4b 100644
--- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
@@ -53,7 +53,7 @@
 	};
 
 	clocks {
-		xo_board {
+		xo {
 			compatible = "fixed-clock";
 			#clock-cells = <0>;
 			clock-frequency = <19200000>;
-- 
Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.

  reply	other threads:[~2018-11-15 20:44 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-15 20:44 [PATCH v2 0/3] Enable SD card slot on msm8998 MTP Jeffrey Hugo
2018-11-15 20:44 ` Jeffrey Hugo [this message]
2018-12-05 16:12   ` [PATCH v2 1/3] arm64: dts: qcom: msm8998: correct xo clock name Marc Gonzalez
2018-12-05 16:38     ` Jeffrey Hugo
2018-12-05 16:48       ` Bjorn Andersson
2018-12-05 17:03         ` Jeffrey Hugo
2018-12-05 21:04           ` Stephen Boyd
2018-12-05 21:20             ` Jeffrey Hugo
2018-12-05 21:42               ` Stephen Boyd
2018-12-05 23:04                 ` Jeffrey Hugo
2018-12-06 18:34                   ` Stephen Boyd
2018-12-07  9:03                     ` Marc Gonzalez
2018-12-07 14:58                       ` Jeffrey Hugo
2018-12-07 18:23                         ` Andy Gross
2018-11-15 20:44 ` [PATCH v2 2/3] arm64: dts: qcom: msm8998: Add SDCC2 Jeffrey Hugo
2018-11-15 20:44 ` [PATCH v2 3/3] arm64: dts: qcom: msm8998-mtp: Add external SD Jeffrey Hugo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1542314695-24071-2-git-send-email-jhugo@codeaurora.org \
    --to=jhugo@codeaurora.org \
    --cc=andy.gross@linaro.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=david.brown@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox