Re: [PATCH v2 1/3] arm64: dts: qcom: msm8998: correct xo clock name

[Jeffrey Hugo <jhugo@codeaurora.org>]

On 12/5/2018 9:12 AM, Marc Gonzalez wrote:
> On 15/11/2018 21:44, Jeffrey Hugo wrote:
> 
>> The root parent clock of most msm8998 clock is the "xo" clock.  The DT node
>> is incorrectly named "xo_board", which prevents Linux from correctly
>> parsing the clock tree, resulting in most clocks being unparented and
>> unable to be manipulated.  The end result is that we can't turn on clocks
>> for peripherals like SD, so init usually fails.
>>
>> Fixes: 4807c71cc688 (arm64: dts: Add msm8998 SoC and MTP board support)
>> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>> Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
>> ---
>>   arch/arm64/boot/dts/qcom/msm8998.dtsi | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
>> index 78227cc..a948d4b 100644
>> --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
>> @@ -53,7 +53,7 @@
>>   	};
>>   
>>   	clocks {
>> -		xo_board {
>> +		xo {
>>   			compatible = "fixed-clock";
>>   			#clock-cells = <0>;
>>   			clock-frequency = <19200000>;
>>
> 
> Isn't there going to be a problem for msm8998 in drivers/clk/qcom/clk-smd-rpm.c
> which uses "xo_board" for parent_names?

Looks like you are right.  This doesn't seem to be the correct way to 
address the issue then.  I'll have to dig in and take another look.


-- 
Jeffrey Hugo
Qualcomm Datacenter Technologies as an affiliate of Qualcomm 
Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.