* [PATCH] arm64: dts: qcom: sc7180: Drop pinconf on dp_hot_plug_det
@ 2020-12-15 2:00 Stephen Boyd
2020-12-15 16:48 ` Doug Anderson
2020-12-29 20:15 ` patchwork-bot+linux-arm-msm
0 siblings, 2 replies; 3+ messages in thread
From: Stephen Boyd @ 2020-12-15 2:00 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson
Cc: linux-kernel, linux-arm-msm, Douglas Anderson, Tanmay Shah
We shouldn't put any pinconf here in case someone decides to invert this
HPD signal or remove an external pull-down. It's better to leave that to
the board pinconf nodes, so drop it here.
Reported-by: Douglas Anderson <dianders@chromium.org>
Cc: Tanmay Shah <tanmay@codeaurora.org>
Fixes: 681a607ad21a ("arm64: dts: qcom: sc7180: Add DisplayPort HPD pin dt node")
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
---
arch/arm64/boot/dts/qcom/sc7180.dtsi | 6 ------
1 file changed, 6 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index 22b832fc62e3..268fa40a1774 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -1468,12 +1468,6 @@ pinmux {
pins = "gpio117";
function = "dp_hot";
};
-
- pinconf {
- pins = "gpio117";
- bias-disable;
- input-enable;
- };
};
qspi_clk: qspi-clk {
--
https://chromeos.dev
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: qcom: sc7180: Drop pinconf on dp_hot_plug_det
2020-12-15 2:00 [PATCH] arm64: dts: qcom: sc7180: Drop pinconf on dp_hot_plug_det Stephen Boyd
@ 2020-12-15 16:48 ` Doug Anderson
2020-12-29 20:15 ` patchwork-bot+linux-arm-msm
1 sibling, 0 replies; 3+ messages in thread
From: Doug Anderson @ 2020-12-15 16:48 UTC (permalink / raw)
To: Stephen Boyd
Cc: Andy Gross, Bjorn Andersson, LKML, linux-arm-msm, Tanmay Shah
Hi,
On Mon, Dec 14, 2020 at 6:00 PM Stephen Boyd <swboyd@chromium.org> wrote:
>
> We shouldn't put any pinconf here in case someone decides to invert this
> HPD signal or remove an external pull-down. It's better to leave that to
> the board pinconf nodes, so drop it here.
>
> Reported-by: Douglas Anderson <dianders@chromium.org>
> Cc: Tanmay Shah <tanmay@codeaurora.org>
> Fixes: 681a607ad21a ("arm64: dts: qcom: sc7180: Add DisplayPort HPD pin dt node")
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 6 ------
> 1 file changed, 6 deletions(-)
Reviewed-by: Douglas Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: qcom: sc7180: Drop pinconf on dp_hot_plug_det
2020-12-15 2:00 [PATCH] arm64: dts: qcom: sc7180: Drop pinconf on dp_hot_plug_det Stephen Boyd
2020-12-15 16:48 ` Doug Anderson
@ 2020-12-29 20:15 ` patchwork-bot+linux-arm-msm
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+linux-arm-msm @ 2020-12-29 20:15 UTC (permalink / raw)
To: Stephen Boyd; +Cc: linux-arm-msm
Hello:
This patch was applied to qcom/linux.git (refs/heads/for-next):
On Mon, 14 Dec 2020 18:00:04 -0800 you wrote:
> We shouldn't put any pinconf here in case someone decides to invert this
> HPD signal or remove an external pull-down. It's better to leave that to
> the board pinconf nodes, so drop it here.
>
> Reported-by: Douglas Anderson <dianders@chromium.org>
> Cc: Tanmay Shah <tanmay@codeaurora.org>
> Fixes: 681a607ad21a ("arm64: dts: qcom: sc7180: Add DisplayPort HPD pin dt node")
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
>
> [...]
Here is the summary with links:
- arm64: dts: qcom: sc7180: Drop pinconf on dp_hot_plug_det
https://git.kernel.org/qcom/c/8d079bf20410
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-29 20:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-15 2:00 [PATCH] arm64: dts: qcom: sc7180: Drop pinconf on dp_hot_plug_det Stephen Boyd
2020-12-15 16:48 ` Doug Anderson
2020-12-29 20:15 ` patchwork-bot+linux-arm-msm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox