Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
* [PATCH] drm/msm/a5xx: Allow all patchid for A540 chip
@ 2021-01-09 13:40 AngeloGioacchino Del Regno
  2021-03-01 19:59 ` patchwork-bot+linux-arm-msm
  0 siblings, 1 reply; 2+ messages in thread
From: AngeloGioacchino Del Regno @ 2021-01-09 13:40 UTC (permalink / raw)
  To: linux-arm-msm
  Cc: konrad.dybcio, marijn.suijten, martin.botka, phone-devel,
	robdclark, sean, jcrouse, dri-devel, freedreno, linux-kernel,
	AngeloGioacchino Del Regno

On at least MSM8998 it's possible to find Adreno 540.0 and 540.1
but I have never found any 540.2. In any case, the patchids 0-1
for A540 are completely supported by this driver and there is no
reason to disallow probing them (as they also share the same
firmware names).

Besides that, the patchid number is also used in the a5xx_power.c
function a540_lm_setup to disable the battery current limiter,
which makes faking the Adreno patchid to .2 (which would anyway
be sad) useless and even producing breakages.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
---
 drivers/gpu/drm/msm/adreno/adreno_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c
index 76a89a8175f8..133e3c15a1b7 100644
--- a/drivers/gpu/drm/msm/adreno/adreno_device.c
+++ b/drivers/gpu/drm/msm/adreno/adreno_device.c
@@ -216,7 +216,7 @@ static const struct adreno_info gpulist[] = {
 		.init = a5xx_gpu_init,
 		.zapfw = "a530_zap.mdt",
 	}, {
-		.rev = ADRENO_REV(5, 4, 0, 2),
+		.rev = ADRENO_REV(5, 4, 0, ANY_ID),
 		.revn = 540,
 		.name = "A540",
 		.fw = {
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/msm/a5xx: Allow all patchid for A540 chip
  2021-01-09 13:40 [PATCH] drm/msm/a5xx: Allow all patchid for A540 chip AngeloGioacchino Del Regno
@ 2021-03-01 19:59 ` patchwork-bot+linux-arm-msm
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+linux-arm-msm @ 2021-03-01 19:59 UTC (permalink / raw)
  To: AngeloGioacchino Del Regno; +Cc: linux-arm-msm

Hello:

This patch was applied to qcom/linux.git (refs/heads/for-next):

On Sat,  9 Jan 2021 14:40:44 +0100 you wrote:
> On at least MSM8998 it's possible to find Adreno 540.0 and 540.1
> but I have never found any 540.2. In any case, the patchids 0-1
> for A540 are completely supported by this driver and there is no
> reason to disallow probing them (as they also share the same
> firmware names).
> 
> Besides that, the patchid number is also used in the a5xx_power.c
> function a540_lm_setup to disable the battery current limiter,
> which makes faking the Adreno patchid to .2 (which would anyway
> be sad) useless and even producing breakages.
> 
> [...]

Here is the summary with links:
  - drm/msm/a5xx: Allow all patchid for A540 chip
    https://git.kernel.org/qcom/c/4f2cf99d542c

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-03-01 20:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-09 13:40 [PATCH] drm/msm/a5xx: Allow all patchid for A540 chip AngeloGioacchino Del Regno
2021-03-01 19:59 ` patchwork-bot+linux-arm-msm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox