* [PATCH] rpmsg: glink: add a header file
@ 2021-01-05 23:55 Alex Elder
2021-01-06 2:42 ` kernel test robot
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Alex Elder @ 2021-01-05 23:55 UTC (permalink / raw)
To: bjorn.andersson, agross, ohad
Cc: linux-arm-msm, linux-remoteproc, linux-kernel
With an x86_64 architecture W=1 build, qcom_glink_ssr_notify() is
reported as having no previous prototype. The prototype is found in
"qcom_glink.h", so we just need "qcom_glink_ssr.c" to include that
file.
Signed-off-by: Alex Elder <elder@linaro.org>
---
drivers/rpmsg/qcom_glink_ssr.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/rpmsg/qcom_glink_ssr.c b/drivers/rpmsg/qcom_glink_ssr.c
index dcd1ce6169747..4da6c7d985568 100644
--- a/drivers/rpmsg/qcom_glink_ssr.c
+++ b/drivers/rpmsg/qcom_glink_ssr.c
@@ -8,6 +8,7 @@
#include <linux/module.h>
#include <linux/notifier.h>
#include <linux/rpmsg.h>
+#include <linux/rpmsg/qcom_glink.h>
#include <linux/remoteproc/qcom_rproc.h>
/**
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] rpmsg: glink: add a header file
2021-01-05 23:55 [PATCH] rpmsg: glink: add a header file Alex Elder
@ 2021-01-06 2:42 ` kernel test robot
[not found] ` <X/U2MmdpU96WdUGw@builder.lan>
2021-01-06 7:27 ` kernel test robot
2021-03-01 19:59 ` patchwork-bot+linux-arm-msm
2 siblings, 1 reply; 6+ messages in thread
From: kernel test robot @ 2021-01-06 2:42 UTC (permalink / raw)
To: Alex Elder, bjorn.andersson, agross, ohad
Cc: kbuild-all, linux-arm-msm, linux-remoteproc, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 3168 bytes --]
Hi Alex,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.11-rc2 next-20210104]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Alex-Elder/rpmsg-glink-add-a-header-file/20210106-080024
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git e71ba9452f0b5b2e8dc8aa5445198cd9214a6a62
config: x86_64-randconfig-s021-20210106 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-208-g46a52ca4-dirty
# https://github.com/0day-ci/linux/commit/333b19e6f90b89d18b94be972c0823959373dad8
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Alex-Elder/rpmsg-glink-add-a-header-file/20210106-080024
git checkout 333b19e6f90b89d18b94be972c0823959373dad8
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/rpmsg/qcom_glink_ssr.c:65:6: error: redefinition of 'qcom_glink_ssr_notify'
65 | void qcom_glink_ssr_notify(const char *ssr_name)
| ^~~~~~~~~~~~~~~~~~~~~
In file included from drivers/rpmsg/qcom_glink_ssr.c:11:
include/linux/rpmsg/qcom_glink.h:27:20: note: previous definition of 'qcom_glink_ssr_notify' was here
27 | static inline void qcom_glink_ssr_notify(const char *ssr_name) {}
| ^~~~~~~~~~~~~~~~~~~~~
vim +/qcom_glink_ssr_notify +65 drivers/rpmsg/qcom_glink_ssr.c
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22 60
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22 61 /**
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22 62 * qcom_glink_ssr_notify() - notify GLINK SSR about stopped remoteproc
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22 63 * @ssr_name: name of the remoteproc that has been stopped
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22 64 */
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22 @65 void qcom_glink_ssr_notify(const char *ssr_name)
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22 66 {
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22 67 blocking_notifier_call_chain(&ssr_notifiers, 0, (void *)ssr_name);
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22 68 }
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22 69 EXPORT_SYMBOL_GPL(qcom_glink_ssr_notify);
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22 70
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 37288 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] rpmsg: glink: add a header file
2021-01-05 23:55 [PATCH] rpmsg: glink: add a header file Alex Elder
2021-01-06 2:42 ` kernel test robot
@ 2021-01-06 7:27 ` kernel test robot
2021-03-01 19:59 ` patchwork-bot+linux-arm-msm
2 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2021-01-06 7:27 UTC (permalink / raw)
To: Alex Elder, bjorn.andersson, agross, ohad
Cc: kbuild-all, clang-built-linux, linux-arm-msm, linux-remoteproc,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 3293 bytes --]
Hi Alex,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.11-rc2 next-20210104]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Alex-Elder/rpmsg-glink-add-a-header-file/20210106-080024
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git e71ba9452f0b5b2e8dc8aa5445198cd9214a6a62
config: x86_64-randconfig-a015-20210106 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 5c951623bc8965fa1e89660f2f5f4a2944e4981a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/333b19e6f90b89d18b94be972c0823959373dad8
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Alex-Elder/rpmsg-glink-add-a-header-file/20210106-080024
git checkout 333b19e6f90b89d18b94be972c0823959373dad8
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/rpmsg/qcom_glink_ssr.c:65:6: error: redefinition of 'qcom_glink_ssr_notify'
void qcom_glink_ssr_notify(const char *ssr_name)
^
include/linux/rpmsg/qcom_glink.h:27:20: note: previous definition is here
static inline void qcom_glink_ssr_notify(const char *ssr_name) {}
^
1 error generated.
vim +/qcom_glink_ssr_notify +65 drivers/rpmsg/qcom_glink_ssr.c
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22 60
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22 61 /**
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22 62 * qcom_glink_ssr_notify() - notify GLINK SSR about stopped remoteproc
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22 63 * @ssr_name: name of the remoteproc that has been stopped
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22 64 */
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22 @65 void qcom_glink_ssr_notify(const char *ssr_name)
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22 66 {
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22 67 blocking_notifier_call_chain(&ssr_notifiers, 0, (void *)ssr_name);
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22 68 }
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22 69 EXPORT_SYMBOL_GPL(qcom_glink_ssr_notify);
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22 70
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33263 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] rpmsg: glink: add a header file
2021-01-05 23:55 [PATCH] rpmsg: glink: add a header file Alex Elder
2021-01-06 2:42 ` kernel test robot
2021-01-06 7:27 ` kernel test robot
@ 2021-03-01 19:59 ` patchwork-bot+linux-arm-msm
2 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+linux-arm-msm @ 2021-03-01 19:59 UTC (permalink / raw)
To: Alex Elder; +Cc: linux-arm-msm
Hello:
This patch was applied to qcom/linux.git (refs/heads/for-next):
On Tue, 5 Jan 2021 17:55:28 -0600 you wrote:
> With an x86_64 architecture W=1 build, qcom_glink_ssr_notify() is
> reported as having no previous prototype. The prototype is found in
> "qcom_glink.h", so we just need "qcom_glink_ssr.c" to include that
> file.
>
> Signed-off-by: Alex Elder <elder@linaro.org>
>
> [...]
Here is the summary with links:
- rpmsg: glink: add a header file
https://git.kernel.org/qcom/c/3e35772bc1e4
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-03-01 20:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-05 23:55 [PATCH] rpmsg: glink: add a header file Alex Elder
2021-01-06 2:42 ` kernel test robot
[not found] ` <X/U2MmdpU96WdUGw@builder.lan>
2021-01-06 4:19 ` Alex Elder
2021-01-06 4:23 ` Bjorn Andersson
2021-01-06 7:27 ` kernel test robot
2021-03-01 19:59 ` patchwork-bot+linux-arm-msm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox