From: Rajendra Nayak <rnayak@codeaurora.org>
To: agross@kernel.org, bjorn.andersson@linaro.org
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
swboyd@chromium.org, Rajendra Nayak <rnayak@codeaurora.org>
Subject: [PATCH 2/2] soc: qcom: rpmhpd: Make mx as a parent of cx only for sdm845
Date: Tue, 16 Nov 2021 10:56:22 +0530 [thread overview]
Message-ID: <1637040382-22987-2-git-send-email-rnayak@codeaurora.org> (raw)
In-Reply-To: <1637040382-22987-1-git-send-email-rnayak@codeaurora.org>
The requirement to specify the active + sleep and active-only MX power
domains as the parents of the corresponding CX power domains is applicable
only on the sdm845 SoC. With the same struct definition reused for all the
SoCs this condition was wrongly applied to all those SoCs as well, which
isn't needed. Define new sdm845 specific structures to manage this
dependency and remove the parent assignements from the common structure.
Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
---
drivers/soc/qcom/rpmhpd.c | 22 ++++++++++++++++++----
1 file changed, 18 insertions(+), 4 deletions(-)
diff --git a/drivers/soc/qcom/rpmhpd.c b/drivers/soc/qcom/rpmhpd.c
index c71481d..12d8ce9 100644
--- a/drivers/soc/qcom/rpmhpd.c
+++ b/drivers/soc/qcom/rpmhpd.c
@@ -108,7 +108,6 @@ static struct rpmhpd cx_ao;
static struct rpmhpd cx = {
.pd = { .name = "cx", },
.peer = &cx_ao,
- .parent = &mx.pd,
.res_name = "cx.lvl",
};
@@ -116,7 +115,6 @@ static struct rpmhpd cx_ao = {
.pd = { .name = "cx_ao", },
.active_only = true,
.peer = &cx,
- .parent = &mx_ao.pd,
.res_name = "cx.lvl",
};
@@ -149,12 +147,28 @@ static struct rpmhpd mxc_ao = {
};
/* SDM845 RPMH powerdomains */
+static struct rpmhpd sdm845_cx_ao;
+static struct rpmhpd sdm845_cx = {
+ .pd = { .name = "cx", },
+ .peer = &sdm845_cx_ao,
+ .parent = &mx.pd,
+ .res_name = "cx.lvl",
+};
+
+static struct rpmhpd sdm845_cx_ao = {
+ .pd = { .name = "cx_ao", },
+ .active_only = true,
+ .peer = &sdm845_cx,
+ .parent = &mx_ao.pd,
+ .res_name = "cx.lvl",
+};
+
static struct rpmhpd *sdm845_rpmhpds[] = {
[SDM845_EBI] = &ebi,
[SDM845_MX] = &mx,
[SDM845_MX_AO] = &mx_ao,
- [SDM845_CX] = &cx,
- [SDM845_CX_AO] = &cx_ao,
+ [SDM845_CX] = &sdm845_cx,
+ [SDM845_CX_AO] = &sdm845_cx_ao,
[SDM845_LMX] = &lmx,
[SDM845_LCX] = &lcx,
[SDM845_GFX] = &gfx,
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2021-11-16 5:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 5:26 [PATCH 1/2] soc: qcom: rpmhpd: Rename rpmhpd struct names Rajendra Nayak
2021-11-16 5:26 ` Rajendra Nayak [this message]
2021-11-19 3:19 ` [PATCH 2/2] soc: qcom: rpmhpd: Make mx as a parent of cx only for sdm845 Bjorn Andersson
2021-11-23 7:15 ` Rajendra Nayak
2021-12-02 7:48 ` Rajendra Nayak
2021-11-18 18:26 ` [PATCH 1/2] soc: qcom: rpmhpd: Rename rpmhpd struct names Matthias Kaehlcke
2021-11-19 3:11 ` Bjorn Andersson
2021-12-01 20:44 ` Stephen Boyd
2021-12-15 22:27 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1637040382-22987-2-git-send-email-rnayak@codeaurora.org \
--to=rnayak@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox