From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 19/27] ARM: dts: qcom: pm8058: use defined IRQ flags
Date: Mon, 3 Jul 2023 13:53:03 +0200 [thread overview]
Message-ID: <165cc1e2-5604-3ae5-b303-fdfe8119bfcd@linaro.org> (raw)
In-Reply-To: <20230702134320.98831-20-dmitry.baryshkov@linaro.org>
On 2.07.2023 15:43, Dmitry Baryshkov wrote:
> Use symbolic names for IRQ flags instead of using the numeric values.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm/boot/dts/qcom/pm8058.dtsi | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom/pm8058.dtsi b/arch/arm/boot/dts/qcom/pm8058.dtsi
> index 913a511719fa..3683d7b60918 100644
> --- a/arch/arm/boot/dts/qcom/pm8058.dtsi
> +++ b/arch/arm/boot/dts/qcom/pm8058.dtsi
> @@ -12,7 +12,8 @@ pwrkey@1c {
> compatible = "qcom,pm8058-pwrkey";
> reg = <0x1c>;
> interrupt-parent = <&pm8058>;
> - interrupts = <50 1>, <51 1>;
> + interrupts = <50 IRQ_TYPE_EDGE_RISING>,
> + <51 IRQ_TYPE_EDGE_RISING>;
> debounce = <15625>;
> pull-up;
> };
> @@ -61,7 +62,8 @@ pm8058_keypad: keypad@148 {
> compatible = "qcom,pm8058-keypad";
> reg = <0x148>;
> interrupt-parent = <&pm8058>;
> - interrupts = <74 1>, <75 1>;
> + interrupts = <74 IRQ_TYPE_EDGE_RISING>,
> + <75 IRQ_TYPE_EDGE_RISING>;
> debounce = <15>;
> scan-delay = <32>;
> row-hold = <91500>;
> @@ -135,7 +137,7 @@ rtc@1e8 {
> compatible = "qcom,pm8058-rtc";
> reg = <0x1e8>;
> interrupt-parent = <&pm8058>;
> - interrupts = <39 1>;
> + interrupts = <39 IRQ_TYPE_EDGE_RISING>;
> allow-set-time;
> };
> };
next prev parent reply other threads:[~2023-07-03 11:53 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-02 13:42 [PATCH v2 00/27] ARM: dts: qcom: cleanup PMIC usage Dmitry Baryshkov
2023-07-02 13:42 ` [PATCH v2 01/27] ARM: dts: qcom: apq8064: correct XOADC register address Dmitry Baryshkov
2023-07-02 13:42 ` [PATCH v2 02/27] ARM: dts: qcom: msm8960: introduce label for PMIC keypad Dmitry Baryshkov
2023-07-02 13:42 ` [PATCH v2 03/27] ARM: dts: qcom: msm8660-surf: use keypad label directly Dmitry Baryshkov
2023-07-02 13:42 ` [PATCH v2 04/27] ARM: dts: qcom: apq8064-nexus7: move sdcc1 node to proper place Dmitry Baryshkov
2023-07-02 13:42 ` [PATCH v2 05/27] ARM: dts: qcom: mdm9615-wp8548-mangoh-green: group include clauses Dmitry Baryshkov
2023-07-02 13:42 ` [PATCH v2 06/27] ARM: dts: qcom: strip prefix from PMIC files Dmitry Baryshkov
2023-07-02 13:43 ` [PATCH v2 07/27] ARM: dts: qcom: apq8064: fix PMIC node labels Dmitry Baryshkov
2023-07-03 11:46 ` Konrad Dybcio
2023-07-02 13:43 ` [PATCH v2 08/27] ARM: dts: qcom: mdm9615: " Dmitry Baryshkov
2023-07-03 11:46 ` Konrad Dybcio
2023-07-02 13:43 ` [PATCH v2 09/27] ARM: dts: qcom: msm8660: " Dmitry Baryshkov
2023-07-03 11:47 ` Konrad Dybcio
2023-07-02 13:43 ` [PATCH v2 10/27] ARM: dts: qcom: msm8960: " Dmitry Baryshkov
2023-07-03 11:47 ` Konrad Dybcio
2023-07-02 13:43 ` [PATCH v2 11/27] ARM: dts: qcom: msm8960: split PMIC to separate dtsi files Dmitry Baryshkov
2023-07-03 11:49 ` Konrad Dybcio
2023-07-02 13:43 ` [PATCH v2 12/27] ARM: dts: qcom: apq8064: split PMICs " Dmitry Baryshkov
2023-07-02 13:43 ` [PATCH v2 13/27] ARM: dts: qcom: mdm9615: split PMIC " Dmitry Baryshkov
2023-07-02 13:43 ` [PATCH v2 14/27] ARM: dts: qcom: msm8660: " Dmitry Baryshkov
2023-07-02 13:43 ` [PATCH v2 15/27] ARM: dts: qcom: pm8058: reorder nodes Dmitry Baryshkov
2023-07-03 11:51 ` Konrad Dybcio
2023-07-02 13:43 ` [PATCH v2 16/27] ARM: dts: qcom: pm8921: " Dmitry Baryshkov
2023-07-03 11:52 ` Konrad Dybcio
2023-07-02 13:43 ` [PATCH v2 17/27] ARM: dts: qcom: pm8018: move reg property Dmitry Baryshkov
2023-07-03 11:52 ` Konrad Dybcio
2023-07-02 13:43 ` [PATCH v2 18/27] ARM: dts: qcom: pm8921: " Dmitry Baryshkov
2023-07-03 11:52 ` Konrad Dybcio
2023-07-02 13:43 ` [PATCH v2 19/27] ARM: dts: qcom: pm8058: use defined IRQ flags Dmitry Baryshkov
2023-07-03 11:53 ` Konrad Dybcio [this message]
2023-07-02 13:43 ` [PATCH v2 20/27] ARM: dts: qcom: pm8921: switch to interrupts-extended Dmitry Baryshkov
2023-07-03 11:53 ` Konrad Dybcio
2023-07-02 13:43 ` [PATCH v2 21/27] ARM: dts: qcom: pm8018: " Dmitry Baryshkov
2023-07-03 11:53 ` Konrad Dybcio
2023-07-02 13:43 ` [PATCH v2 22/27] ARM: dts: qcom: pm8058: " Dmitry Baryshkov
2023-07-03 11:54 ` Konrad Dybcio
2023-07-02 13:43 ` [PATCH v2 23/27] ARM: dts: qcom: apq8064: move RPM regulators to board files Dmitry Baryshkov
2023-07-02 13:43 ` [PATCH v2 24/27] ARM: dts: qcom: mdm9615: " Dmitry Baryshkov
2023-07-02 13:43 ` [PATCH v2 25/27] ARM: dts: qcom: msm8660: " Dmitry Baryshkov
2023-07-02 13:43 ` [PATCH v2 26/27] ARM: dts: qcom: msm8960: drop useless rpm regulators node Dmitry Baryshkov
2023-07-02 13:43 ` [PATCH v2 27/27] ARM: dts: qcom: msm8974: move regulators to board files Dmitry Baryshkov
2023-07-04 14:08 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165cc1e2-5604-3ae5-b303-fdfe8119bfcd@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox