From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 27/27] ARM: dts: qcom: msm8974: move regulators to board files
Date: Tue, 4 Jul 2023 16:08:10 +0200 [thread overview]
Message-ID: <399f29d0-ca1e-932c-6d7f-e07d6d0c0159@linaro.org> (raw)
In-Reply-To: <20230702134320.98831-28-dmitry.baryshkov@linaro.org>
On 2.07.2023 15:43, Dmitry Baryshkov wrote:
> The vph-pwr and boost regulators (even if they are unified by design)
> are not a property of SoC, so move them to board files.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> .../dts/qcom/qcom-apq8074-dragonboard.dts | 27 +++++++++++++++++++
> .../qcom-msm8974-lge-nexus5-hammerhead.dts | 27 +++++++++++++++++++
> .../qcom/qcom-msm8974-sony-xperia-rhine.dtsi | 27 +++++++++++++++++++
> arch/arm/boot/dts/qcom/qcom-msm8974.dtsi | 27 -------------------
> .../qcom/qcom-msm8974pro-fairphone-fp2.dts | 27 +++++++++++++++++++
> .../qcom/qcom-msm8974pro-oneplus-bacon.dts | 27 +++++++++++++++++++
> .../dts/qcom/qcom-msm8974pro-samsung-klte.dts | 10 ++++++-
> ...-msm8974pro-sony-xperia-shinano-castor.dts | 27 +++++++++++++++++++
> 8 files changed, 171 insertions(+), 28 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom/qcom-apq8074-dragonboard.dts b/arch/arm/boot/dts/qcom/qcom-apq8074-dragonboard.dts
> index 5a8af16bf02d..3e5311e7196e 100644
> --- a/arch/arm/boot/dts/qcom/qcom-apq8074-dragonboard.dts
> +++ b/arch/arm/boot/dts/qcom/qcom-apq8074-dragonboard.dts
> @@ -49,6 +49,33 @@ mpss_region: mpss@ac00000 {
> no-map;
> };
> };
> +
> + vreg_boost: vreg-boost {
> + compatible = "regulator-fixed";
> +
> + regulator-name = "vreg-boost";
> + regulator-min-microvolt = <3150000>;
> + regulator-max-microvolt = <3150000>;
> +
> + regulator-always-on;
> + regulator-boot-on;
> +
> + gpio = <&pm8941_gpios 21 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&boost_bypass_n_pin>;
> + };
> +
> + vreg_vph_pwr: vreg-vph-pwr {
> + compatible = "regulator-fixed";
> + regulator-name = "vph-pwr";
> +
> + regulator-min-microvolt = <3600000>;
> + regulator-max-microvolt = <3600000>;
> +
> + regulator-always-on;
> + };
> };
>
> &blsp1_uart2 {
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts b/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts
> index da99f770d4f5..ca402b4a68bd 100644
> --- a/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts
> @@ -60,6 +60,33 @@ vibrator {
> enable-gpios = <&tlmm 60 GPIO_ACTIVE_HIGH>;
> };
>
> + vreg_boost: vreg-boost {
> + compatible = "regulator-fixed";
> +
> + regulator-name = "vreg-boost";
> + regulator-min-microvolt = <3150000>;
> + regulator-max-microvolt = <3150000>;
> +
> + regulator-always-on;
> + regulator-boot-on;
> +
> + gpio = <&pm8941_gpios 21 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&boost_bypass_n_pin>;
> + };
> +
> + vreg_vph_pwr: vreg-vph-pwr {
> + compatible = "regulator-fixed";
> + regulator-name = "vph-pwr";
> +
> + regulator-min-microvolt = <3600000>;
> + regulator-max-microvolt = <3600000>;
> +
> + regulator-always-on;
> + };
> +
> vreg_wlan: wlan-regulator {
> compatible = "regulator-fixed";
>
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974-sony-xperia-rhine.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8974-sony-xperia-rhine.dtsi
> index 23ae474698aa..a43341ae4495 100644
> --- a/arch/arm/boot/dts/qcom/qcom-msm8974-sony-xperia-rhine.dtsi
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8974-sony-xperia-rhine.dtsi
> @@ -65,6 +65,33 @@ ramoops@3e8e0000 {
> pmsg-size = <0x80000>;
> };
> };
> +
> + vreg_boost: vreg-boost {
> + compatible = "regulator-fixed";
> +
> + regulator-name = "vreg-boost";
> + regulator-min-microvolt = <3150000>;
> + regulator-max-microvolt = <3150000>;
> +
> + regulator-always-on;
> + regulator-boot-on;
> +
> + gpio = <&pm8941_gpios 21 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&boost_bypass_n_pin>;
> + };
> +
> + vreg_vph_pwr: vreg-vph-pwr {
> + compatible = "regulator-fixed";
> + regulator-name = "vph-pwr";
> +
> + regulator-min-microvolt = <3600000>;
> + regulator-max-microvolt = <3600000>;
> +
> + regulator-always-on;
> + };
> };
>
> &blsp1_i2c2 {
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi
> index aeca504918a0..a4ff1fe63903 100644
> --- a/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi
> @@ -2376,31 +2376,4 @@ timer {
> <GIC_PPI 1 0xf08>;
> clock-frequency = <19200000>;
> };
> -
> - vreg_boost: vreg-boost {
> - compatible = "regulator-fixed";
> -
> - regulator-name = "vreg-boost";
> - regulator-min-microvolt = <3150000>;
> - regulator-max-microvolt = <3150000>;
> -
> - regulator-always-on;
> - regulator-boot-on;
> -
> - gpio = <&pm8941_gpios 21 GPIO_ACTIVE_HIGH>;
> - enable-active-high;
> -
> - pinctrl-names = "default";
> - pinctrl-0 = <&boost_bypass_n_pin>;
> - };
> -
> - vreg_vph_pwr: vreg-vph-pwr {
> - compatible = "regulator-fixed";
> - regulator-name = "vph-pwr";
> -
> - regulator-min-microvolt = <3600000>;
> - regulator-max-microvolt = <3600000>;
> -
> - regulator-always-on;
> - };
> };
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974pro-fairphone-fp2.dts b/arch/arm/boot/dts/qcom/qcom-msm8974pro-fairphone-fp2.dts
> index 24f9521a0be6..9cbdfe62051e 100644
> --- a/arch/arm/boot/dts/qcom/qcom-msm8974pro-fairphone-fp2.dts
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8974pro-fairphone-fp2.dts
> @@ -57,6 +57,33 @@ vibrator {
> enable-gpios = <&tlmm 86 GPIO_ACTIVE_HIGH>;
> vcc-supply = <&pm8941_l18>;
> };
> +
> + vreg_boost: vreg-boost {
> + compatible = "regulator-fixed";
> +
> + regulator-name = "vreg-boost";
> + regulator-min-microvolt = <3150000>;
> + regulator-max-microvolt = <3150000>;
> +
> + regulator-always-on;
> + regulator-boot-on;
> +
> + gpio = <&pm8941_gpios 21 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&boost_bypass_n_pin>;
> + };
> +
> + vreg_vph_pwr: vreg-vph-pwr {
> + compatible = "regulator-fixed";
> + regulator-name = "vph-pwr";
> +
> + regulator-min-microvolt = <3600000>;
> + regulator-max-microvolt = <3600000>;
> +
> + regulator-always-on;
> + };
> };
>
> &blsp1_i2c2 {
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974pro-oneplus-bacon.dts b/arch/arm/boot/dts/qcom/qcom-msm8974pro-oneplus-bacon.dts
> index c0ca264d8140..6d1412aec45a 100644
> --- a/arch/arm/boot/dts/qcom/qcom-msm8974pro-oneplus-bacon.dts
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8974pro-oneplus-bacon.dts
> @@ -51,6 +51,33 @@ event-hall-sensor {
> debounce-interval = <150>;
> };
> };
> +
> + vreg_boost: vreg-boost {
> + compatible = "regulator-fixed";
> +
> + regulator-name = "vreg-boost";
> + regulator-min-microvolt = <3150000>;
> + regulator-max-microvolt = <3150000>;
> +
> + regulator-always-on;
> + regulator-boot-on;
> +
> + gpio = <&pm8941_gpios 21 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&boost_bypass_n_pin>;
> + };
> +
> + vreg_vph_pwr: vreg-vph-pwr {
> + compatible = "regulator-fixed";
> + regulator-name = "vph-pwr";
> +
> + regulator-min-microvolt = <3600000>;
> + regulator-max-microvolt = <3600000>;
> +
> + regulator-always-on;
> + };
> };
>
> &blsp1_i2c1 {
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte.dts b/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte.dts
> index 325feb89b343..ca3aa16b4b10 100644
> --- a/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte.dts
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte.dts
> @@ -155,7 +155,15 @@ vreg_panel: panel-regulator {
> enable-active-high;
> };
>
> - /delete-node/ vreg-boost;
> + vreg_vph_pwr: vreg-vph-pwr {
> + compatible = "regulator-fixed";
> + regulator-name = "vph-pwr";
> +
> + regulator-min-microvolt = <3600000>;
> + regulator-max-microvolt = <3600000>;
> +
> + regulator-always-on;
> + };
> };
>
> &blsp1_i2c2 {
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974pro-sony-xperia-shinano-castor.dts b/arch/arm/boot/dts/qcom/qcom-msm8974pro-sony-xperia-shinano-castor.dts
> index efe21289c9fe..b76d51b1b667 100644
> --- a/arch/arm/boot/dts/qcom/qcom-msm8974pro-sony-xperia-shinano-castor.dts
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8974pro-sony-xperia-shinano-castor.dts
> @@ -84,6 +84,33 @@ vreg_vsp: lcd-dcdc-regulator {
> pinctrl-0 = <&lcd_dcdc_en_pin_a>;
> };
>
> + vreg_boost: vreg-boost {
> + compatible = "regulator-fixed";
> +
> + regulator-name = "vreg-boost";
> + regulator-min-microvolt = <3150000>;
> + regulator-max-microvolt = <3150000>;
> +
> + regulator-always-on;
> + regulator-boot-on;
> +
> + gpio = <&pm8941_gpios 21 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&boost_bypass_n_pin>;
> + };
> +
> + vreg_vph_pwr: vreg-vph-pwr {
> + compatible = "regulator-fixed";
> + regulator-name = "vph-pwr";
> +
> + regulator-min-microvolt = <3600000>;
> + regulator-max-microvolt = <3600000>;
> +
> + regulator-always-on;
> + };
> +
> vreg_wlan: wlan-regulator {
> compatible = "regulator-fixed";
>
prev parent reply other threads:[~2023-07-04 14:08 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-02 13:42 [PATCH v2 00/27] ARM: dts: qcom: cleanup PMIC usage Dmitry Baryshkov
2023-07-02 13:42 ` [PATCH v2 01/27] ARM: dts: qcom: apq8064: correct XOADC register address Dmitry Baryshkov
2023-07-02 13:42 ` [PATCH v2 02/27] ARM: dts: qcom: msm8960: introduce label for PMIC keypad Dmitry Baryshkov
2023-07-02 13:42 ` [PATCH v2 03/27] ARM: dts: qcom: msm8660-surf: use keypad label directly Dmitry Baryshkov
2023-07-02 13:42 ` [PATCH v2 04/27] ARM: dts: qcom: apq8064-nexus7: move sdcc1 node to proper place Dmitry Baryshkov
2023-07-02 13:42 ` [PATCH v2 05/27] ARM: dts: qcom: mdm9615-wp8548-mangoh-green: group include clauses Dmitry Baryshkov
2023-07-02 13:42 ` [PATCH v2 06/27] ARM: dts: qcom: strip prefix from PMIC files Dmitry Baryshkov
2023-07-02 13:43 ` [PATCH v2 07/27] ARM: dts: qcom: apq8064: fix PMIC node labels Dmitry Baryshkov
2023-07-03 11:46 ` Konrad Dybcio
2023-07-02 13:43 ` [PATCH v2 08/27] ARM: dts: qcom: mdm9615: " Dmitry Baryshkov
2023-07-03 11:46 ` Konrad Dybcio
2023-07-02 13:43 ` [PATCH v2 09/27] ARM: dts: qcom: msm8660: " Dmitry Baryshkov
2023-07-03 11:47 ` Konrad Dybcio
2023-07-02 13:43 ` [PATCH v2 10/27] ARM: dts: qcom: msm8960: " Dmitry Baryshkov
2023-07-03 11:47 ` Konrad Dybcio
2023-07-02 13:43 ` [PATCH v2 11/27] ARM: dts: qcom: msm8960: split PMIC to separate dtsi files Dmitry Baryshkov
2023-07-03 11:49 ` Konrad Dybcio
2023-07-02 13:43 ` [PATCH v2 12/27] ARM: dts: qcom: apq8064: split PMICs " Dmitry Baryshkov
2023-07-02 13:43 ` [PATCH v2 13/27] ARM: dts: qcom: mdm9615: split PMIC " Dmitry Baryshkov
2023-07-02 13:43 ` [PATCH v2 14/27] ARM: dts: qcom: msm8660: " Dmitry Baryshkov
2023-07-02 13:43 ` [PATCH v2 15/27] ARM: dts: qcom: pm8058: reorder nodes Dmitry Baryshkov
2023-07-03 11:51 ` Konrad Dybcio
2023-07-02 13:43 ` [PATCH v2 16/27] ARM: dts: qcom: pm8921: " Dmitry Baryshkov
2023-07-03 11:52 ` Konrad Dybcio
2023-07-02 13:43 ` [PATCH v2 17/27] ARM: dts: qcom: pm8018: move reg property Dmitry Baryshkov
2023-07-03 11:52 ` Konrad Dybcio
2023-07-02 13:43 ` [PATCH v2 18/27] ARM: dts: qcom: pm8921: " Dmitry Baryshkov
2023-07-03 11:52 ` Konrad Dybcio
2023-07-02 13:43 ` [PATCH v2 19/27] ARM: dts: qcom: pm8058: use defined IRQ flags Dmitry Baryshkov
2023-07-03 11:53 ` Konrad Dybcio
2023-07-02 13:43 ` [PATCH v2 20/27] ARM: dts: qcom: pm8921: switch to interrupts-extended Dmitry Baryshkov
2023-07-03 11:53 ` Konrad Dybcio
2023-07-02 13:43 ` [PATCH v2 21/27] ARM: dts: qcom: pm8018: " Dmitry Baryshkov
2023-07-03 11:53 ` Konrad Dybcio
2023-07-02 13:43 ` [PATCH v2 22/27] ARM: dts: qcom: pm8058: " Dmitry Baryshkov
2023-07-03 11:54 ` Konrad Dybcio
2023-07-02 13:43 ` [PATCH v2 23/27] ARM: dts: qcom: apq8064: move RPM regulators to board files Dmitry Baryshkov
2023-07-02 13:43 ` [PATCH v2 24/27] ARM: dts: qcom: mdm9615: " Dmitry Baryshkov
2023-07-02 13:43 ` [PATCH v2 25/27] ARM: dts: qcom: msm8660: " Dmitry Baryshkov
2023-07-02 13:43 ` [PATCH v2 26/27] ARM: dts: qcom: msm8960: drop useless rpm regulators node Dmitry Baryshkov
2023-07-02 13:43 ` [PATCH v2 27/27] ARM: dts: qcom: msm8974: move regulators to board files Dmitry Baryshkov
2023-07-04 14:08 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=399f29d0-ca1e-932c-6d7f-e07d6d0c0159@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox