Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Stephen Boyd <sboyd@kernel.org>,
	linux-arm-msm@vger.kernel.org,
	Manivannan Sadhasivam <mani@kernel.org>,
	devicetree@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Avri Altman <avri.altman@wdc.com>, Sean Paul <sean@poorly.run>,
	dri-devel@lists.freedesktop.org,
	Abhinav Kumar <quic_abhinavk@quicinc.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Bart Van Assche <bvanassche@acm.org>, Lee Jones <lee@kernel.org>,
	Rob Clark <robdclark@gmail.com>, Rob Herring <robh+dt@kernel.org>,
	Daniel Vetter <daniel@ffwll.ch>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Andy Gross <agross@kernel.org>, David Airlie <airlied@gmail.com>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	freedreno@lists.freedesktop.org
Subject: Re: [PATCH 3/8] dt-bindings: ufs: qcom: document the fact the UFS controller can have an ICE core
Date: Thu, 23 Mar 2023 08:58:37 -0500	[thread overview]
Message-ID: <167957963115.3095299.4593054829506617284.robh@kernel.org> (raw)
In-Reply-To: <20230323-topic-sm8450-upstream-dt-bindings-fixes-v1-3-3ead1e418fe4@linaro.org>


On Thu, 23 Mar 2023 11:25:18 +0100, Neil Armstrong wrote:
> Move the qcom,sm8450-ufshc to the right allOf:if allowing the ICE clocks
> and registers to be specified.
> 
> Fixes: 462c5c0aa798 ("dt-bindings: ufs: qcom,ufs: convert to dtschema")
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
>  Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: clocks: [[4294967295, 151], [4294967295, 10], [4294967295, 150], [4294967295, 166], [4294967295, 0], [4294967295, 164], [4294967295, 160], [4294967295, 162]] is too short
	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: clock-names: ['core_clk', 'bus_aggr_clk', 'iface_clk', 'core_clk_unipro', 'ref_clk', 'tx_lane0_sync_clk', 'rx_lane0_sync_clk', 'rx_lane1_sync_clk'] is too short
	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: reg: [[0, 30949376, 0, 12288]] is too short
	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230323-topic-sm8450-upstream-dt-bindings-fixes-v1-3-3ead1e418fe4@linaro.org

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2023-03-23 13:59 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-23 10:25 [PATCH 0/8] arm64: qcom: sm8450: bindings check cleanup Neil Armstrong
2023-03-23 10:25 ` [PATCH 1/8] dt-bindings: display: msm: sm8450-mdss: Fix DSI compatible Neil Armstrong
2023-03-23 13:58   ` Rob Herring
2023-03-23 14:44     ` Neil Armstrong
2023-03-23 10:25 ` [PATCH 2/8] dt-bindings: mfd: qcom,spmi-pmic: document pm8450 pmic Neil Armstrong
2023-03-23 10:45   ` Krzysztof Kozlowski
2023-03-23 13:58   ` Rob Herring
2023-03-23 10:25 ` [PATCH 3/8] dt-bindings: ufs: qcom: document the fact the UFS controller can have an ICE core Neil Armstrong
2023-03-23 13:58   ` Rob Herring [this message]
2023-03-23 14:45     ` Neil Armstrong
2023-03-23 10:25 ` [PATCH 4/8] arm64: dts: qcom: sm8450: remove invalid properties in cluster-sleep nodes Neil Armstrong
2023-03-23 10:51   ` Krzysztof Kozlowski
2023-03-23 13:14     ` Neil Armstrong
2023-03-24  7:12       ` Krzysztof Kozlowski
2023-03-23 10:25 ` [PATCH 5/8] arm64: dts: qcom: sm8450: remove invalid power-domain-names in pcie nodes Neil Armstrong
2023-03-23 10:25 ` [PATCH 6/8] arm64: dts: qcom: sm8450: remove invalid npl clock in vamacro node Neil Armstrong
2023-03-23 10:47   ` Krzysztof Kozlowski
2023-03-23 13:13     ` Neil Armstrong
2023-03-24  7:17       ` Krzysztof Kozlowski
2023-03-24  8:59         ` neil.armstrong
2023-03-23 10:25 ` [PATCH 7/8] arm64: dts: qcom: sm8450: remove invalid reg-names from ufs node Neil Armstrong
2023-03-23 10:49   ` Krzysztof Kozlowski
2023-03-23 13:10     ` Neil Armstrong
2023-03-24  6:52       ` Eric Biggers
2023-03-24  7:14         ` Krzysztof Kozlowski
2023-03-24  7:26         ` Luca Weiss
2023-03-24  7:27           ` Krzysztof Kozlowski
2023-03-23 10:25 ` [PATCH 8/8] arm64: dts: qcom: sm8450: fix pcie1 gpios properties name Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=167957963115.3095299.4593054829506617284.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=agross@kernel.org \
    --cc=airlied@gmail.com \
    --cc=alim.akhtar@samsung.com \
    --cc=andersson@kernel.org \
    --cc=avri.altman@wdc.com \
    --cc=bvanassche@acm.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzk@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=robdclark@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=sean@poorly.run \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox