Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Neil Armstrong <neil.armstrong@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Rob Clark <robdclark@gmail.com>,
	Abhinav Kumar <quic_abhinavk@quicinc.com>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Sean Paul <sean@poorly.run>, David Airlie <airlied@gmail.com>,
	Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Lee Jones <lee@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
	Manivannan Sadhasivam <mani@kernel.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Avri Altman <avri.altman@wdc.com>,
	Bart Van Assche <bvanassche@acm.org>
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	linux-scsi@vger.kernel.org
Subject: Re: [PATCH 6/8] arm64: dts: qcom: sm8450: remove invalid npl clock in vamacro node
Date: Thu, 23 Mar 2023 14:13:00 +0100	[thread overview]
Message-ID: <006bf3bf-ab9a-4a08-3ba5-fa23ff4ea05a@linaro.org> (raw)
In-Reply-To: <35e3aa8b-ccff-25fa-42da-d8934ef366c6@linaro.org>

On 23/03/2023 11:47, Krzysztof Kozlowski wrote:
> On 23/03/2023 11:25, Neil Armstrong wrote:
>> Fixes the following DT bindings check error:
>> codec@33f0000: clocks: [[137, 57, 1], [137, 102, 1], [137, 103, 1], [137, 70, 1]] is too long
>> codec@33f0000: clock-names: 'oneOf' conditional failed, one must be fixed:
>> 	        ['mclk', 'macro', 'dcodec', 'npl'] is too long
>>
>> The implementation was checked and this npl clock isn't used for the VA macro.
>>
> 
> This does not look correct. DTS looks good, you miss some patches in
> your tree.

I'm based on today's linux-next, while the other lpass macros uses the npl clock,
the lpass vamacro bindings doesn't document the npl clock.

And I found no fixes whatsover to add the npl clock to bindings.

Neil

> 
> Best regards,
> Krzysztof
> 


  reply	other threads:[~2023-03-23 13:13 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-23 10:25 [PATCH 0/8] arm64: qcom: sm8450: bindings check cleanup Neil Armstrong
2023-03-23 10:25 ` [PATCH 1/8] dt-bindings: display: msm: sm8450-mdss: Fix DSI compatible Neil Armstrong
2023-03-23 13:58   ` Rob Herring
2023-03-23 14:44     ` Neil Armstrong
2023-03-23 10:25 ` [PATCH 2/8] dt-bindings: mfd: qcom,spmi-pmic: document pm8450 pmic Neil Armstrong
2023-03-23 10:45   ` Krzysztof Kozlowski
2023-03-23 13:58   ` Rob Herring
2023-03-23 10:25 ` [PATCH 3/8] dt-bindings: ufs: qcom: document the fact the UFS controller can have an ICE core Neil Armstrong
2023-03-23 13:58   ` Rob Herring
2023-03-23 14:45     ` Neil Armstrong
2023-03-23 10:25 ` [PATCH 4/8] arm64: dts: qcom: sm8450: remove invalid properties in cluster-sleep nodes Neil Armstrong
2023-03-23 10:51   ` Krzysztof Kozlowski
2023-03-23 13:14     ` Neil Armstrong
2023-03-24  7:12       ` Krzysztof Kozlowski
2023-03-23 10:25 ` [PATCH 5/8] arm64: dts: qcom: sm8450: remove invalid power-domain-names in pcie nodes Neil Armstrong
2023-03-23 10:25 ` [PATCH 6/8] arm64: dts: qcom: sm8450: remove invalid npl clock in vamacro node Neil Armstrong
2023-03-23 10:47   ` Krzysztof Kozlowski
2023-03-23 13:13     ` Neil Armstrong [this message]
2023-03-24  7:17       ` Krzysztof Kozlowski
2023-03-24  8:59         ` neil.armstrong
2023-03-23 10:25 ` [PATCH 7/8] arm64: dts: qcom: sm8450: remove invalid reg-names from ufs node Neil Armstrong
2023-03-23 10:49   ` Krzysztof Kozlowski
2023-03-23 13:10     ` Neil Armstrong
2023-03-24  6:52       ` Eric Biggers
2023-03-24  7:14         ` Krzysztof Kozlowski
2023-03-24  7:26         ` Luca Weiss
2023-03-24  7:27           ` Krzysztof Kozlowski
2023-03-23 10:25 ` [PATCH 8/8] arm64: dts: qcom: sm8450: fix pcie1 gpios properties name Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=006bf3bf-ab9a-4a08-3ba5-fa23ff4ea05a@linaro.org \
    --to=neil.armstrong@linaro.org \
    --cc=agross@kernel.org \
    --cc=airlied@gmail.com \
    --cc=alim.akhtar@samsung.com \
    --cc=andersson@kernel.org \
    --cc=avri.altman@wdc.com \
    --cc=bvanassche@acm.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzk@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=robdclark@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=sean@poorly.run \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox