* [PATCH V2] clk: qcom: ipq5332: fix the order of SLEEP_CLK and XO clock
@ 2023-04-17 10:56 Kathiravan T
2023-04-17 14:34 ` Konrad Dybcio
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Kathiravan T @ 2023-04-17 10:56 UTC (permalink / raw)
To: andersson, agross, konrad.dybcio, mturquette, sboyd,
linux-arm-msm, linux-clk, linux-kernel
Cc: Kathiravan T
The order of DT_SLEEP_CLK and DT_XO are swapped and it is incorrect.
Due to which the clocks for which the parent should be XO is having parent
as SLEEP_CLK and vice versa. So fix the same by re-ordering the entries.
Fixes: 3d89d52970fd ("clk: qcom: add Global Clock controller (GCC) driver for IPQ5332 SoC")
Reported-by: Devi Priya <quic_devipriy@quicinc.com>
Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
---
Changes in V2:
- Added the Reported-by and Fixes tag
drivers/clk/qcom/gcc-ipq5332.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/qcom/gcc-ipq5332.c b/drivers/clk/qcom/gcc-ipq5332.c
index 8cacbfb10c72..14096887d436 100644
--- a/drivers/clk/qcom/gcc-ipq5332.c
+++ b/drivers/clk/qcom/gcc-ipq5332.c
@@ -20,8 +20,8 @@
#include "reset.h"
enum {
- DT_SLEEP_CLK,
DT_XO,
+ DT_SLEEP_CLK,
DT_PCIE_2LANE_PHY_PIPE_CLK,
DT_PCIE_2LANE_PHY_PIPE_CLK_X1,
DT_USB_PCIE_WRAPPER_PIPE_CLK,
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH V2] clk: qcom: ipq5332: fix the order of SLEEP_CLK and XO clock
2023-04-17 10:56 [PATCH V2] clk: qcom: ipq5332: fix the order of SLEEP_CLK and XO clock Kathiravan T
@ 2023-04-17 14:34 ` Konrad Dybcio
2023-05-12 16:04 ` Kathiravan T
2023-05-27 1:07 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2023-04-17 14:34 UTC (permalink / raw)
To: Kathiravan T, andersson, agross, mturquette, sboyd, linux-arm-msm,
linux-clk, linux-kernel
On 17.04.2023 12:56, Kathiravan T wrote:
> The order of DT_SLEEP_CLK and DT_XO are swapped and it is incorrect.
> Due to which the clocks for which the parent should be XO is having parent
> as SLEEP_CLK and vice versa. So fix the same by re-ordering the entries.
>
> Fixes: 3d89d52970fd ("clk: qcom: add Global Clock controller (GCC) driver for IPQ5332 SoC")
> Reported-by: Devi Priya <quic_devipriy@quicinc.com>
> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
> ---
This matches what I can see in the bindings.
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> Changes in V2:
> - Added the Reported-by and Fixes tag
>
> drivers/clk/qcom/gcc-ipq5332.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/qcom/gcc-ipq5332.c b/drivers/clk/qcom/gcc-ipq5332.c
> index 8cacbfb10c72..14096887d436 100644
> --- a/drivers/clk/qcom/gcc-ipq5332.c
> +++ b/drivers/clk/qcom/gcc-ipq5332.c
> @@ -20,8 +20,8 @@
> #include "reset.h"
>
> enum {
> - DT_SLEEP_CLK,
> DT_XO,
> + DT_SLEEP_CLK,
> DT_PCIE_2LANE_PHY_PIPE_CLK,
> DT_PCIE_2LANE_PHY_PIPE_CLK_X1,
> DT_USB_PCIE_WRAPPER_PIPE_CLK,
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH V2] clk: qcom: ipq5332: fix the order of SLEEP_CLK and XO clock
2023-04-17 10:56 [PATCH V2] clk: qcom: ipq5332: fix the order of SLEEP_CLK and XO clock Kathiravan T
2023-04-17 14:34 ` Konrad Dybcio
@ 2023-05-12 16:04 ` Kathiravan T
2023-05-27 1:07 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Kathiravan T @ 2023-05-12 16:04 UTC (permalink / raw)
To: andersson, agross, konrad.dybcio, mturquette, sboyd,
linux-arm-msm, linux-clk, linux-kernel
On 4/17/2023 4:26 PM, Kathiravan T wrote:
> The order of DT_SLEEP_CLK and DT_XO are swapped and it is incorrect.
> Due to which the clocks for which the parent should be XO is having parent
> as SLEEP_CLK and vice versa. So fix the same by re-ordering the entries.
Gentle Reminder...
>
> Fixes: 3d89d52970fd ("clk: qcom: add Global Clock controller (GCC) driver for IPQ5332 SoC")
> Reported-by: Devi Priya <quic_devipriy@quicinc.com>
> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
> ---
> Changes in V2:
> - Added the Reported-by and Fixes tag
>
> drivers/clk/qcom/gcc-ipq5332.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/qcom/gcc-ipq5332.c b/drivers/clk/qcom/gcc-ipq5332.c
> index 8cacbfb10c72..14096887d436 100644
> --- a/drivers/clk/qcom/gcc-ipq5332.c
> +++ b/drivers/clk/qcom/gcc-ipq5332.c
> @@ -20,8 +20,8 @@
> #include "reset.h"
>
> enum {
> - DT_SLEEP_CLK,
> DT_XO,
> + DT_SLEEP_CLK,
> DT_PCIE_2LANE_PHY_PIPE_CLK,
> DT_PCIE_2LANE_PHY_PIPE_CLK_X1,
> DT_USB_PCIE_WRAPPER_PIPE_CLK,
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH V2] clk: qcom: ipq5332: fix the order of SLEEP_CLK and XO clock
2023-04-17 10:56 [PATCH V2] clk: qcom: ipq5332: fix the order of SLEEP_CLK and XO clock Kathiravan T
2023-04-17 14:34 ` Konrad Dybcio
2023-05-12 16:04 ` Kathiravan T
@ 2023-05-27 1:07 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2023-05-27 1:07 UTC (permalink / raw)
To: linux-clk, Kathiravan T, agross, linux-kernel, konrad.dybcio,
linux-arm-msm, mturquette, sboyd
On Mon, 17 Apr 2023 16:26:07 +0530, Kathiravan T wrote:
> The order of DT_SLEEP_CLK and DT_XO are swapped and it is incorrect.
> Due to which the clocks for which the parent should be XO is having parent
> as SLEEP_CLK and vice versa. So fix the same by re-ordering the entries.
>
>
Applied, thanks!
[1/1] clk: qcom: ipq5332: fix the order of SLEEP_CLK and XO clock
commit: 7510e80f4ac707efc7e964120525ef759a02f171
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-05-27 1:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-17 10:56 [PATCH V2] clk: qcom: ipq5332: fix the order of SLEEP_CLK and XO clock Kathiravan T
2023-04-17 14:34 ` Konrad Dybcio
2023-05-12 16:04 ` Kathiravan T
2023-05-27 1:07 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox