From: Bjorn Andersson <andersson@kernel.org>
To: Rob Herring <robh+dt@kernel.org>, Dan Murphy <dmurphy@ti.com>,
Yassine Oudjana <y.oudjana@protonmail.com>,
Luca Weiss <luca@z3ntu.xyz>,
phone-devel@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Raffaele Tranquillini <raffaele.tranquillini@gmail.com>,
Andy Gross <agross@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
~postmarketos/upstreaming@lists.sr.ht,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: (subset) [PATCH 0/5] Improvements for drv260x driver and add to Huawei Watch
Date: Fri, 26 May 2023 18:07:28 -0700 [thread overview]
Message-ID: <168514964951.348612.17473479796367169535.b4-ty@kernel.org> (raw)
In-Reply-To: <20230430-drv260x-improvements-v1-0-1fb28b4cc698@z3ntu.xyz>
On Sun, 30 Apr 2023 20:20:52 +0200, Luca Weiss wrote:
> Clean up some issues with the driver I've noticed while working on it,
> then fix the magnitude handling which previously resulted the driver
> discarding the upper 8 bits of the magnitude value, and finally we can
> add the drv260x to the APQ8026 Huawei Watch.
>
> While the "fix magnitude handling" commit technically changes behavior
> and could change behavior of existing user space applications that deal
> with this quirky behavior, it's definitely not correct and results in
> very unexpected behavior if the user space doesn't look out for it
> (meaning only use 0x00-0xFF magnitude, and also know that the magnitude
> was interpreted as signed value, see more details in the commit message
> there).
>
> [...]
Applied, thanks!
[5/5] ARM: dts: qcom: apq8026-huawei-sturgeon: Add vibrator
commit: ad318f9ce5a2e815816bfcf7f187a3ac32905523
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
prev parent reply other threads:[~2023-05-27 1:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-30 18:20 [PATCH 0/5] Improvements for drv260x driver and add to Huawei Watch Luca Weiss
2023-04-30 18:20 ` [PATCH 1/5] Input: drv260x - fix typo in register value define Luca Weiss
2023-04-30 18:20 ` [PATCH 2/5] Input: drv260x - sleep between polling GO bit Luca Weiss
2023-04-30 18:20 ` [PATCH 3/5] Input: drv260x - remove unused .reg_defaults Luca Weiss
2023-04-30 18:20 ` [PATCH 4/5] Input: drv260x - fix magnitude handling Luca Weiss
2023-04-30 18:20 ` [PATCH 5/5] ARM: dts: qcom: apq8026-huawei-sturgeon: Add vibrator Luca Weiss
2023-05-02 10:21 ` Konrad Dybcio
2023-05-02 0:29 ` [PATCH 0/5] Improvements for drv260x driver and add to Huawei Watch Dmitry Torokhov
2023-05-27 1:07 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168514964951.348612.17473479796367169535.b4-ty@kernel.org \
--to=andersson@kernel.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dmurphy@ti.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=phone-devel@vger.kernel.org \
--cc=raffaele.tranquillini@gmail.com \
--cc=robh+dt@kernel.org \
--cc=y.oudjana@protonmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox