* [PATCH] Documentation/accel/qaic: Fix typo 'phsyical'
@ 2024-05-31 6:09 Danish Prakash
2024-05-31 14:20 ` Shuah Khan
0 siblings, 1 reply; 5+ messages in thread
From: Danish Prakash @ 2024-05-31 6:09 UTC (permalink / raw)
Cc: Shuah Khan, Danish Prakash, Jeffrey Hugo, Carl Vanderlip,
Pranjal Ramajor Asha Kanojiya, Oded Gabbay, Jonathan Corbet,
open list:QUALCOMM CLOUD AI (QAIC) DRIVER,
open list:QUALCOMM CLOUD AI (QAIC) DRIVER,
open list:DOCUMENTATION, open list
(as part of LFX Linux Mentorship program)
Signed-off-by: Danish Prakash <contact@danishpraka.sh>
---
Documentation/accel/qaic/qaic.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/accel/qaic/qaic.rst b/Documentation/accel/qaic/qaic.rst
index efb7771273bb..628bf2f7a416 100644
--- a/Documentation/accel/qaic/qaic.rst
+++ b/Documentation/accel/qaic/qaic.rst
@@ -93,7 +93,7 @@ commands (does not impact QAIC).
uAPI
====
-QAIC creates an accel device per phsyical PCIe device. This accel device exists
+QAIC creates an accel device per physical PCIe device. This accel device exists
for as long as the PCIe device is known to Linux.
The PCIe device may not be in the state to accept requests from userspace at
--
2.45.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Documentation/accel/qaic: Fix typo 'phsyical'
2024-05-31 6:09 [PATCH] Documentation/accel/qaic: Fix typo 'phsyical' Danish Prakash
@ 2024-05-31 14:20 ` Shuah Khan
2024-05-31 21:05 ` Jeffrey Hugo
2024-06-01 14:51 ` [PATCH] Documentation/accel/qaic: Fix typo Danish Prakash
0 siblings, 2 replies; 5+ messages in thread
From: Shuah Khan @ 2024-05-31 14:20 UTC (permalink / raw)
To: Danish Prakash
Cc: Jeffrey Hugo, Carl Vanderlip, Pranjal Ramajor Asha Kanojiya,
Oded Gabbay, Jonathan Corbet,
open list:QUALCOMM CLOUD AI (QAIC) DRIVER,
open list:QUALCOMM CLOUD AI (QAIC) DRIVER,
open list:DOCUMENTATION, open list, Shuah Khan
On 5/31/24 00:09, Danish Prakash wrote:
> (as part of LFX Linux Mentorship program)
>
Please add proper commit log for this change.
> Signed-off-by: Danish Prakash <contact@danishpraka.sh>
> ---
> Documentation/accel/qaic/qaic.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/accel/qaic/qaic.rst b/Documentation/accel/qaic/qaic.rst
> index efb7771273bb..628bf2f7a416 100644
> --- a/Documentation/accel/qaic/qaic.rst
> +++ b/Documentation/accel/qaic/qaic.rst
> @@ -93,7 +93,7 @@ commands (does not impact QAIC).
> uAPI
> ====
>
> -QAIC creates an accel device per phsyical PCIe device. This accel device exists
> +QAIC creates an accel device per physical PCIe device. This accel device exists
> for as long as the PCIe device is known to Linux.
>
> The PCIe device may not be in the state to accept requests from userspace at
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Documentation/accel/qaic: Fix typo 'phsyical'
2024-05-31 14:20 ` Shuah Khan
@ 2024-05-31 21:05 ` Jeffrey Hugo
2024-06-01 14:51 ` [PATCH] Documentation/accel/qaic: Fix typo Danish Prakash
1 sibling, 0 replies; 5+ messages in thread
From: Jeffrey Hugo @ 2024-05-31 21:05 UTC (permalink / raw)
To: Shuah Khan, Danish Prakash
Cc: Carl Vanderlip, Pranjal Ramajor Asha Kanojiya, Oded Gabbay,
Jonathan Corbet, open list:QUALCOMM CLOUD AI (QAIC) DRIVER,
open list:QUALCOMM CLOUD AI (QAIC) DRIVER,
open list:DOCUMENTATION, open list
On 5/31/2024 8:20 AM, Shuah Khan wrote:
> On 5/31/24 00:09, Danish Prakash wrote:
>> (as part of LFX Linux Mentorship program)
>>
>
> Please add proper commit log for this change.
Looks like a good fix, and I'd love to take it, but the commit log needs
some content.
>
>> Signed-off-by: Danish Prakash <contact@danishpraka.sh>
>
>> ---
>> Documentation/accel/qaic/qaic.rst | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/accel/qaic/qaic.rst
>> b/Documentation/accel/qaic/qaic.rst
>> index efb7771273bb..628bf2f7a416 100644
>> --- a/Documentation/accel/qaic/qaic.rst
>> +++ b/Documentation/accel/qaic/qaic.rst
>> @@ -93,7 +93,7 @@ commands (does not impact QAIC).
>> uAPI
>> ====
>> -QAIC creates an accel device per phsyical PCIe device. This accel
>> device exists
>> +QAIC creates an accel device per physical PCIe device. This accel
>> device exists
>> for as long as the PCIe device is known to Linux.
>> The PCIe device may not be in the state to accept requests from
>> userspace at
>
> thanks,
> -- Shuah
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] Documentation/accel/qaic: Fix typo
2024-05-31 14:20 ` Shuah Khan
2024-05-31 21:05 ` Jeffrey Hugo
@ 2024-06-01 14:51 ` Danish Prakash
2024-06-04 15:36 ` Jeffrey Hugo
1 sibling, 1 reply; 5+ messages in thread
From: Danish Prakash @ 2024-06-01 14:51 UTC (permalink / raw)
Cc: Shuah Khan, Danish Prakash, Jeffrey Hugo, Carl Vanderlip,
Pranjal Ramajor Asha Kanojiya, Oded Gabbay, Jonathan Corbet,
open list:QUALCOMM CLOUD AI (QAIC) DRIVER,
open list:QUALCOMM CLOUD AI (QAIC) DRIVER,
open list:DOCUMENTATION, open list
Fixed a typo in the docs where 'phsyical'
was corrected to 'physical'.
Signed-off-by: Danish Prakash <contact@danishpraka.sh>
---
Documentation/accel/qaic/qaic.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/accel/qaic/qaic.rst b/Documentation/accel/qaic/qaic.rst
index efb7771273bb..628bf2f7a416 100644
--- a/Documentation/accel/qaic/qaic.rst
+++ b/Documentation/accel/qaic/qaic.rst
@@ -93,7 +93,7 @@ commands (does not impact QAIC).
uAPI
====
-QAIC creates an accel device per phsyical PCIe device. This accel device exists
+QAIC creates an accel device per physical PCIe device. This accel device exists
for as long as the PCIe device is known to Linux.
The PCIe device may not be in the state to accept requests from userspace at
--
2.45.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Documentation/accel/qaic: Fix typo
2024-06-01 14:51 ` [PATCH] Documentation/accel/qaic: Fix typo Danish Prakash
@ 2024-06-04 15:36 ` Jeffrey Hugo
0 siblings, 0 replies; 5+ messages in thread
From: Jeffrey Hugo @ 2024-06-04 15:36 UTC (permalink / raw)
To: Danish Prakash
Cc: Shuah Khan, Carl Vanderlip, Pranjal Ramajor Asha Kanojiya,
Oded Gabbay, Jonathan Corbet,
open list:QUALCOMM CLOUD AI (QAIC) DRIVER,
open list:QUALCOMM CLOUD AI (QAIC) DRIVER,
open list:DOCUMENTATION, open list
For future reference, since this is the second revision of this change,
the subject should have "[PATCH v2]".
On 6/1/2024 8:51 AM, Danish Prakash wrote:
> Fixed a typo in the docs where 'phsyical' > was corrected to 'physical'.
Commit text should be in the present simple tense. You currently are
using past tense here. "Fixed" -> "Fix", etc.
> Signed-off-by: Danish Prakash <contact@danishpraka.sh>
> ---
Since this is a single change and not a series, you should have a change
log here which identifies what is different in this revision.
> Documentation/accel/qaic/qaic.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/accel/qaic/qaic.rst b/Documentation/accel/qaic/qaic.rst
> index efb7771273bb..628bf2f7a416 100644
> --- a/Documentation/accel/qaic/qaic.rst
> +++ b/Documentation/accel/qaic/qaic.rst
> @@ -93,7 +93,7 @@ commands (does not impact QAIC).
> uAPI
> ====
>
> -QAIC creates an accel device per phsyical PCIe device. This accel device exists
> +QAIC creates an accel device per physical PCIe device. This accel device exists
> for as long as the PCIe device is known to Linux.
>
> The PCIe device may not be in the state to accept requests from userspace at
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-06-04 15:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-31 6:09 [PATCH] Documentation/accel/qaic: Fix typo 'phsyical' Danish Prakash
2024-05-31 14:20 ` Shuah Khan
2024-05-31 21:05 ` Jeffrey Hugo
2024-06-01 14:51 ` [PATCH] Documentation/accel/qaic: Fix typo Danish Prakash
2024-06-04 15:36 ` Jeffrey Hugo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox