* [PATCH v2 1/4] arm64: dts: qcom: sc7180: correct SPMI bus address cells
@ 2022-12-13 10:19 Krzysztof Kozlowski
2022-12-13 10:19 ` [PATCH v2 2/4] arm64: dts: qcom: sc7280: " Krzysztof Kozlowski
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-13 10:19 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Stephen Boyd, Rajendra Nayak, Kiran Gunda
Cc: Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
The SPMI bus uses two address cells and zero size cells (second reg
entry - SPMI_USID - is not the size):
spmi@c440000: #address-cells:0:0: 2 was expected
Fixes: 0f9dc5f09fbd ("arm64: dts: qcom: sc7180: Add SPMI PMIC arbiter device")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
---
Changes since v1:
1. secoond->second
2. Add tags
---
arch/arm64/boot/dts/qcom/sc7180.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index eb1e1ea12ff6..906fb9343bcc 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -3274,8 +3274,8 @@ spmi_bus: spmi@c440000 {
interrupts-extended = <&pdc 1 IRQ_TYPE_LEVEL_HIGH>;
qcom,ee = <0>;
qcom,channel = <0>;
- #address-cells = <1>;
- #size-cells = <1>;
+ #address-cells = <2>;
+ #size-cells = <0>;
interrupt-controller;
#interrupt-cells = <4>;
cell-index = <0>;
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v2 2/4] arm64: dts: qcom: sc7280: correct SPMI bus address cells 2022-12-13 10:19 [PATCH v2 1/4] arm64: dts: qcom: sc7180: correct SPMI bus address cells Krzysztof Kozlowski @ 2022-12-13 10:19 ` Krzysztof Kozlowski 2022-12-13 10:19 ` [PATCH v2 3/4] arm64: dts: qcom: sc8280xp: " Krzysztof Kozlowski ` (2 subsequent siblings) 3 siblings, 0 replies; 6+ messages in thread From: Krzysztof Kozlowski @ 2022-12-13 10:19 UTC (permalink / raw) To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Rajendra Nayak, Satya Priya Cc: Krzysztof Kozlowski, Stephen Boyd, linux-arm-msm, devicetree, linux-kernel The SPMI bus uses two address cells and zero size cells (second reg entry - SPMI_USID - is not the size): spmi@c440000: #address-cells:0:0: 2 was expected Fixes: 14abf8dfe364 ("arm64: dts: qcom: sc7280: Add SPMI PMIC arbiter device for SC7280") Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Reviewed-by: Stephen Boyd <swboyd@chromium.org> --- Changes since v1: 1. secoond->second 2. Add tags --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi index 448879d3d5cd..7c24c2129800 100644 --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi @@ -4286,8 +4286,8 @@ spmi_bus: spmi@c440000 { interrupts-extended = <&pdc 1 IRQ_TYPE_LEVEL_HIGH>; qcom,ee = <0>; qcom,channel = <0>; - #address-cells = <1>; - #size-cells = <1>; + #address-cells = <2>; + #size-cells = <0>; interrupt-controller; #interrupt-cells = <4>; }; -- 2.34.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 3/4] arm64: dts: qcom: sc8280xp: correct SPMI bus address cells 2022-12-13 10:19 [PATCH v2 1/4] arm64: dts: qcom: sc7180: correct SPMI bus address cells Krzysztof Kozlowski 2022-12-13 10:19 ` [PATCH v2 2/4] arm64: dts: qcom: sc7280: " Krzysztof Kozlowski @ 2022-12-13 10:19 ` Krzysztof Kozlowski 2022-12-13 10:19 ` [PATCH v2 4/4] arm64: dts: qcom: rename AOSS QMP nodes Krzysztof Kozlowski 2023-01-11 5:09 ` (subset) [PATCH v2 1/4] arm64: dts: qcom: sc7180: correct SPMI bus address cells Bjorn Andersson 3 siblings, 0 replies; 6+ messages in thread From: Krzysztof Kozlowski @ 2022-12-13 10:19 UTC (permalink / raw) To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Johan Hovold Cc: Krzysztof Kozlowski, Stephen Boyd, linux-arm-msm, devicetree, linux-kernel The SPMI bus uses two address cells and zero size cells (second reg entry - SPMI_USID - is not the size): spmi@c440000: #address-cells:0:0: 2 was expected Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform") Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Reviewed-by: Stephen Boyd <swboyd@chromium.org> Reviewed-by: Johan Hovold <johan+linaro@kernel.org> --- Changes since v1: 1. secoond->second 2. Add tags --- arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi index 27f5c2f82338..3cb4ca6c53eb 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi @@ -1947,8 +1947,8 @@ spmi_bus: spmi@c440000 { interrupts-extended = <&pdc 1 IRQ_TYPE_LEVEL_HIGH>; qcom,ee = <0>; qcom,channel = <0>; - #address-cells = <1>; - #size-cells = <1>; + #address-cells = <2>; + #size-cells = <0>; interrupt-controller; #interrupt-cells = <4>; }; -- 2.34.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 4/4] arm64: dts: qcom: rename AOSS QMP nodes 2022-12-13 10:19 [PATCH v2 1/4] arm64: dts: qcom: sc7180: correct SPMI bus address cells Krzysztof Kozlowski 2022-12-13 10:19 ` [PATCH v2 2/4] arm64: dts: qcom: sc7280: " Krzysztof Kozlowski 2022-12-13 10:19 ` [PATCH v2 3/4] arm64: dts: qcom: sc8280xp: " Krzysztof Kozlowski @ 2022-12-13 10:19 ` Krzysztof Kozlowski 2022-12-13 10:20 ` Konrad Dybcio 2023-01-11 5:09 ` (subset) [PATCH v2 1/4] arm64: dts: qcom: sc7180: correct SPMI bus address cells Bjorn Andersson 3 siblings, 1 reply; 6+ messages in thread From: Krzysztof Kozlowski @ 2022-12-13 10:19 UTC (permalink / raw) To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski Cc: Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel The Always On Subsystem (AOSS) QMP is not a power domain controller since commit 135780456218 ("arm64: dts: qcom: sc7180: Use QMP property to control load state") and few others. In fact, it was never a power domain controller but rather control of power state of remote processors. This power state control is now handled differently, thus the AOSS QMP nodes do not have power-domain-cells: sc7280-idp.dtb: power-controller@c300000: '#power-domain-cells' is a required property From schema: Documentation/devicetree/bindings/power/power-domain.yaml AOSS QMP is an interface to the actuall AOSS subsystem responsible for some of power management functions, thus let's call the nodes as "power-management". Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Changes since v1: 1. Call the nodes "power-management" --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 +- arch/arm64/boot/dts/qcom/sc7280.dtsi | 2 +- arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 +- arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- arch/arm64/boot/dts/qcom/sm6350.dtsi | 2 +- arch/arm64/boot/dts/qcom/sm8150.dtsi | 2 +- arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 +- arch/arm64/boot/dts/qcom/sm8350.dtsi | 2 +- arch/arm64/boot/dts/qcom/sm8450.dtsi | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index 906fb9343bcc..1370b7adccd8 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -3248,7 +3248,7 @@ aoss_reset: reset-controller@c2a0000 { #reset-cells = <1>; }; - aoss_qmp: power-controller@c300000 { + aoss_qmp: power-management@c300000 { compatible = "qcom,sc7180-aoss-qmp", "qcom,aoss-qmp"; reg = <0 0x0c300000 0 0x400>; interrupts = <GIC_SPI 389 IRQ_TYPE_EDGE_RISING>; diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi index 7c24c2129800..4768ae74d61f 100644 --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi @@ -4257,7 +4257,7 @@ aoss_reset: reset-controller@c2a0000 { #reset-cells = <1>; }; - aoss_qmp: power-controller@c300000 { + aoss_qmp: power-management@c300000 { compatible = "qcom,sc7280-aoss-qmp", "qcom,aoss-qmp"; reg = <0 0x0c300000 0 0x400>; interrupts-extended = <&ipcc IPCC_CLIENT_AOP diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi index 3cb4ca6c53eb..05086169d873 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi @@ -1921,7 +1921,7 @@ tsens1: thermal-sensor@c265000 { #thermal-sensor-cells = <1>; }; - aoss_qmp: power-controller@c300000 { + aoss_qmp: power-management@c300000 { compatible = "qcom,sc8280xp-aoss-qmp", "qcom,aoss-qmp"; reg = <0 0x0c300000 0 0x400>; interrupts-extended = <&ipcc IPCC_CLIENT_AOP IPCC_MPROC_SIGNAL_GLINK_QMP IRQ_TYPE_EDGE_RISING>; diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index 5f1f7cb52c90..a749e6b9d5ac 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi @@ -4965,7 +4965,7 @@ aoss_reset: reset-controller@c2a0000 { #reset-cells = <1>; }; - aoss_qmp: power-controller@c300000 { + aoss_qmp: power-management@c300000 { compatible = "qcom,sdm845-aoss-qmp", "qcom,aoss-qmp"; reg = <0 0x0c300000 0 0x400>; interrupts = <GIC_SPI 389 IRQ_TYPE_EDGE_RISING>; diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/qcom/sm6350.dtsi index 0f01ff4feb55..8dda257178c9 100644 --- a/arch/arm64/boot/dts/qcom/sm6350.dtsi +++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi @@ -1273,7 +1273,7 @@ tsens1: thermal-sensor@c265000 { #thermal-sensor-cells = <1>; }; - aoss_qmp: power-controller@c300000 { + aoss_qmp: power-management@c300000 { compatible = "qcom,sm6350-aoss-qmp", "qcom,aoss-qmp"; reg = <0 0x0c300000 0 0x1000>; interrupts-extended = <&ipcc IPCC_CLIENT_AOP IPCC_MPROC_SIGNAL_GLINK_QMP diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi index d1b64280ab0b..089f730beb76 100644 --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi @@ -3589,7 +3589,7 @@ pdc: interrupt-controller@b220000 { interrupt-controller; }; - aoss_qmp: power-controller@c300000 { + aoss_qmp: power-management@c300000 { compatible = "qcom,sm8150-aoss-qmp", "qcom,aoss-qmp"; reg = <0x0 0x0c300000 0x0 0x400>; interrupts = <GIC_SPI 389 IRQ_TYPE_EDGE_RISING>; diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi index fbbbae29e0c2..a4e171a59409 100644 --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi @@ -3741,7 +3741,7 @@ tsens1: thermal-sensor@c265000 { #thermal-sensor-cells = <1>; }; - aoss_qmp: power-controller@c300000 { + aoss_qmp: power-management@c300000 { compatible = "qcom,sm8250-aoss-qmp", "qcom,aoss-qmp"; reg = <0 0x0c300000 0 0x400>; interrupts-extended = <&ipcc IPCC_CLIENT_AOP diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi index 49db223a0777..1fd0df2e343f 100644 --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi @@ -1717,7 +1717,7 @@ tsens1: thermal-sensor@c265000 { #thermal-sensor-cells = <1>; }; - aoss_qmp: power-controller@c300000 { + aoss_qmp: power-management@c300000 { compatible = "qcom,sm8350-aoss-qmp", "qcom,aoss-qmp"; reg = <0 0x0c300000 0 0x400>; interrupts-extended = <&ipcc IPCC_CLIENT_AOP IPCC_MPROC_SIGNAL_GLINK_QMP diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi index e0d30dadbf8b..e9a835e34ad2 100644 --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi @@ -2453,7 +2453,7 @@ tsens1: thermal-sensor@c265000 { #thermal-sensor-cells = <1>; }; - aoss_qmp: power-controller@c300000 { + aoss_qmp: power-management@c300000 { compatible = "qcom,sm8450-aoss-qmp", "qcom,aoss-qmp"; reg = <0 0x0c300000 0 0x400>; interrupts-extended = <&ipcc IPCC_CLIENT_AOP IPCC_MPROC_SIGNAL_GLINK_QMP -- 2.34.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 4/4] arm64: dts: qcom: rename AOSS QMP nodes 2022-12-13 10:19 ` [PATCH v2 4/4] arm64: dts: qcom: rename AOSS QMP nodes Krzysztof Kozlowski @ 2022-12-13 10:20 ` Konrad Dybcio 0 siblings, 0 replies; 6+ messages in thread From: Konrad Dybcio @ 2022-12-13 10:20 UTC (permalink / raw) To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski Cc: linux-arm-msm, devicetree, linux-kernel On 13.12.2022 11:19, Krzysztof Kozlowski wrote: > The Always On Subsystem (AOSS) QMP is not a power domain controller > since commit 135780456218 ("arm64: dts: qcom: sc7180: Use QMP property > to control load state") and few others. In fact, it was never a power > domain controller but rather control of power state of remote > processors. This power state control is now handled differently, thus > the AOSS QMP nodes do not have power-domain-cells: > > sc7280-idp.dtb: power-controller@c300000: '#power-domain-cells' is a required property > From schema: Documentation/devicetree/bindings/power/power-domain.yaml > > AOSS QMP is an interface to the actuall AOSS subsystem responsible for > some of power management functions, thus let's call the nodes as > "power-management". > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > > Changes since v1: > 1. Call the nodes "power-management" > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 +- > arch/arm64/boot/dts/qcom/sc7280.dtsi | 2 +- > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 +- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- > arch/arm64/boot/dts/qcom/sm6350.dtsi | 2 +- > arch/arm64/boot/dts/qcom/sm8150.dtsi | 2 +- > arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 +- > arch/arm64/boot/dts/qcom/sm8350.dtsi | 2 +- > arch/arm64/boot/dts/qcom/sm8450.dtsi | 2 +- > 9 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index 906fb9343bcc..1370b7adccd8 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -3248,7 +3248,7 @@ aoss_reset: reset-controller@c2a0000 { > #reset-cells = <1>; > }; > > - aoss_qmp: power-controller@c300000 { > + aoss_qmp: power-management@c300000 { > compatible = "qcom,sc7180-aoss-qmp", "qcom,aoss-qmp"; > reg = <0 0x0c300000 0 0x400>; > interrupts = <GIC_SPI 389 IRQ_TYPE_EDGE_RISING>; > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi > index 7c24c2129800..4768ae74d61f 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > @@ -4257,7 +4257,7 @@ aoss_reset: reset-controller@c2a0000 { > #reset-cells = <1>; > }; > > - aoss_qmp: power-controller@c300000 { > + aoss_qmp: power-management@c300000 { > compatible = "qcom,sc7280-aoss-qmp", "qcom,aoss-qmp"; > reg = <0 0x0c300000 0 0x400>; > interrupts-extended = <&ipcc IPCC_CLIENT_AOP > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > index 3cb4ca6c53eb..05086169d873 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > @@ -1921,7 +1921,7 @@ tsens1: thermal-sensor@c265000 { > #thermal-sensor-cells = <1>; > }; > > - aoss_qmp: power-controller@c300000 { > + aoss_qmp: power-management@c300000 { > compatible = "qcom,sc8280xp-aoss-qmp", "qcom,aoss-qmp"; > reg = <0 0x0c300000 0 0x400>; > interrupts-extended = <&ipcc IPCC_CLIENT_AOP IPCC_MPROC_SIGNAL_GLINK_QMP IRQ_TYPE_EDGE_RISING>; > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index 5f1f7cb52c90..a749e6b9d5ac 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -4965,7 +4965,7 @@ aoss_reset: reset-controller@c2a0000 { > #reset-cells = <1>; > }; > > - aoss_qmp: power-controller@c300000 { > + aoss_qmp: power-management@c300000 { > compatible = "qcom,sdm845-aoss-qmp", "qcom,aoss-qmp"; > reg = <0 0x0c300000 0 0x400>; > interrupts = <GIC_SPI 389 IRQ_TYPE_EDGE_RISING>; > diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/qcom/sm6350.dtsi > index 0f01ff4feb55..8dda257178c9 100644 > --- a/arch/arm64/boot/dts/qcom/sm6350.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi > @@ -1273,7 +1273,7 @@ tsens1: thermal-sensor@c265000 { > #thermal-sensor-cells = <1>; > }; > > - aoss_qmp: power-controller@c300000 { > + aoss_qmp: power-management@c300000 { > compatible = "qcom,sm6350-aoss-qmp", "qcom,aoss-qmp"; > reg = <0 0x0c300000 0 0x1000>; > interrupts-extended = <&ipcc IPCC_CLIENT_AOP IPCC_MPROC_SIGNAL_GLINK_QMP > diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi > index d1b64280ab0b..089f730beb76 100644 > --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi > @@ -3589,7 +3589,7 @@ pdc: interrupt-controller@b220000 { > interrupt-controller; > }; > > - aoss_qmp: power-controller@c300000 { > + aoss_qmp: power-management@c300000 { > compatible = "qcom,sm8150-aoss-qmp", "qcom,aoss-qmp"; > reg = <0x0 0x0c300000 0x0 0x400>; > interrupts = <GIC_SPI 389 IRQ_TYPE_EDGE_RISING>; > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi > index fbbbae29e0c2..a4e171a59409 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi > @@ -3741,7 +3741,7 @@ tsens1: thermal-sensor@c265000 { > #thermal-sensor-cells = <1>; > }; > > - aoss_qmp: power-controller@c300000 { > + aoss_qmp: power-management@c300000 { > compatible = "qcom,sm8250-aoss-qmp", "qcom,aoss-qmp"; > reg = <0 0x0c300000 0 0x400>; > interrupts-extended = <&ipcc IPCC_CLIENT_AOP > diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi > index 49db223a0777..1fd0df2e343f 100644 > --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi > @@ -1717,7 +1717,7 @@ tsens1: thermal-sensor@c265000 { > #thermal-sensor-cells = <1>; > }; > > - aoss_qmp: power-controller@c300000 { > + aoss_qmp: power-management@c300000 { > compatible = "qcom,sm8350-aoss-qmp", "qcom,aoss-qmp"; > reg = <0 0x0c300000 0 0x400>; > interrupts-extended = <&ipcc IPCC_CLIENT_AOP IPCC_MPROC_SIGNAL_GLINK_QMP > diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi > index e0d30dadbf8b..e9a835e34ad2 100644 > --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi > @@ -2453,7 +2453,7 @@ tsens1: thermal-sensor@c265000 { > #thermal-sensor-cells = <1>; > }; > > - aoss_qmp: power-controller@c300000 { > + aoss_qmp: power-management@c300000 { > compatible = "qcom,sm8450-aoss-qmp", "qcom,aoss-qmp"; > reg = <0 0x0c300000 0 0x400>; > interrupts-extended = <&ipcc IPCC_CLIENT_AOP IPCC_MPROC_SIGNAL_GLINK_QMP ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: (subset) [PATCH v2 1/4] arm64: dts: qcom: sc7180: correct SPMI bus address cells 2022-12-13 10:19 [PATCH v2 1/4] arm64: dts: qcom: sc7180: correct SPMI bus address cells Krzysztof Kozlowski ` (2 preceding siblings ...) 2022-12-13 10:19 ` [PATCH v2 4/4] arm64: dts: qcom: rename AOSS QMP nodes Krzysztof Kozlowski @ 2023-01-11 5:09 ` Bjorn Andersson 3 siblings, 0 replies; 6+ messages in thread From: Bjorn Andersson @ 2023-01-11 5:09 UTC (permalink / raw) To: Krzysztof Kozlowski, rnayak, robh+dt, konrad.dybcio, agross, krzysztof.kozlowski+dt, swboyd, kgunda Cc: linux-arm-msm, devicetree, linux-kernel On Tue, 13 Dec 2022 11:19:17 +0100, Krzysztof Kozlowski wrote: > The SPMI bus uses two address cells and zero size cells (second reg > entry - SPMI_USID - is not the size): > > spmi@c440000: #address-cells:0:0: 2 was expected > > Applied, thanks! [1/4] arm64: dts: qcom: sc7180: correct SPMI bus address cells commit: 1f75745537222172f84783d369bbd1fb2d4b6414 [2/4] arm64: dts: qcom: sc7280: correct SPMI bus address cells commit: 8da3786a91e56fe0c4aeb2c2209744474af6e517 [3/4] arm64: dts: qcom: sc8280xp: correct SPMI bus address cells commit: 76d9e8b4d54ae2cb91a68f0cb82624887de767a7 [4/4] arm64: dts: qcom: rename AOSS QMP nodes commit: bb99820dd284a9bae63d713431d84b1832d222a1 Best regards, -- Bjorn Andersson <andersson@kernel.org> ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-01-11 5:19 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-12-13 10:19 [PATCH v2 1/4] arm64: dts: qcom: sc7180: correct SPMI bus address cells Krzysztof Kozlowski 2022-12-13 10:19 ` [PATCH v2 2/4] arm64: dts: qcom: sc7280: " Krzysztof Kozlowski 2022-12-13 10:19 ` [PATCH v2 3/4] arm64: dts: qcom: sc8280xp: " Krzysztof Kozlowski 2022-12-13 10:19 ` [PATCH v2 4/4] arm64: dts: qcom: rename AOSS QMP nodes Krzysztof Kozlowski 2022-12-13 10:20 ` Konrad Dybcio 2023-01-11 5:09 ` (subset) [PATCH v2 1/4] arm64: dts: qcom: sc7180: correct SPMI bus address cells Bjorn Andersson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox