Re: [PATCH V3 0/3] X1E001DE Snapdragon Devkit for Windows

["Rob Herring (Arm)" <robh@kernel.org>]

On Fri, 25 Oct 2024 18:02:24 +0530, Sibi Sankar wrote:
> Add initial support for X1E001DE Snapdragon Devkit for Windows. X1E001DE
> is the speed binned variant of X1E80100 that supports turbo boost up to
> 4.3 Ghz. The initial support includes the following:
> 
> -DSPs
> -Ethernet (RTL8125BG) over the pcie 5 instance.
> -NVme
> -Wifi
> -USB-C ports
> 
> V3:
> * Asked around and looked at the firmware, couldn't find a codename so
>   will keep it as DEVKIT. Will update it if someone from the community
>   finds something else.
> * Update type c roles as reported by ucsi. [Dmitry]
> * Update THUNDERCOMM to Thundercomm. [Dmitry]
> * Update regulator names and sort Order. [Dmitry]
> * Add x1e001DE devkit to the safe list.
> * Mark regulator-nmve as boot enabled.
> 
> 
> V2:
> * Fix Ghz -> GHz  [Jeff]
> * Pick up Ab tag from Rob.
> * Use Vendor in ADSP/CDSP firmware path [Dmitry]
> * Fix reserved gpios [Dmitry]
> * Only port0 supports DRD update the dt accordingly [Dmitry]
> 
> Sibi Sankar (3):
>   dt-bindings: arm: qcom: Add Snapdragon Devkit for Windows
>   firmware: qcom: uefisecapp: Allow X1E Devkit devices
>   arm64: dts: qcom: Add X1E001DE Snapdragon Devkit for Windows
> 
>  .../devicetree/bindings/arm/qcom.yaml         |   6 +
>  arch/arm64/boot/dts/qcom/Makefile             |   1 +
>  arch/arm64/boot/dts/qcom/x1e001de-devkit.dts  | 814 ++++++++++++++++++
>  drivers/firmware/qcom/qcom_scm.c              |   1 +
>  4 files changed, 822 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
> 
> --
> 2.34.1
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y qcom/x1e001de-devkit.dtb' for 20241025123227.3527720-1-quic_sibis@quicinc.com:

arch/arm64/boot/dts/qcom/x1e001de-devkit.dtb: usb@a2f8800: interrupt-names: ['pwr_event', 'dp_hs_phy_irq', 'dm_hs_phy_irq'] is too short
	from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml#
arch/arm64/boot/dts/qcom/x1e001de-devkit.dtb: system-cache-controller@25000000: reg: [[0, 620756992, 0, 2097152], [0, 622854144, 0, 2097152], [0, 624951296, 0, 2097152], [0, 627048448, 0, 2097152], [0, 629145600, 0, 2097152], [0, 631242752, 0, 2097152], [0, 633339904, 0, 2097152], [0, 635437056, 0, 2097152], [0, 637534208, 0, 2097152], [0, 639631360, 0, 2097152]] is too long
	from schema $id: http://devicetree.org/schemas/cache/qcom,llcc.yaml#
arch/arm64/boot/dts/qcom/x1e001de-devkit.dtb: system-cache-controller@25000000: reg-names: ['llcc0_base', 'llcc1_base', 'llcc2_base', 'llcc3_base', 'llcc4_base', 'llcc5_base', 'llcc6_base', 'llcc7_base', 'llcc_broadcast_base', 'llcc_broadcast_and_base'] is too long
	from schema $id: http://devicetree.org/schemas/cache/qcom,llcc.yaml#
arch/arm64/boot/dts/qcom/x1e001de-devkit.dtb: system-cache-controller@25000000: reg: [[0, 620756992, 0, 2097152], [0, 622854144, 0, 2097152], [0, 624951296, 0, 2097152], [0, 627048448, 0, 2097152], [0, 629145600, 0, 2097152], [0, 631242752, 0, 2097152], [0, 633339904, 0, 2097152], [0, 635437056, 0, 2097152], [0, 637534208, 0, 2097152], [0, 639631360, 0, 2097152]] is too long
	from schema $id: http://devicetree.org/schemas/cache/qcom,llcc.yaml#
arch/arm64/boot/dts/qcom/x1e001de-devkit.dtb: system-cache-controller@25000000: reg-names: ['llcc0_base', 'llcc1_base', 'llcc2_base', 'llcc3_base', 'llcc4_base', 'llcc5_base', 'llcc6_base', 'llcc7_base', 'llcc_broadcast_base', 'llcc_broadcast_and_base'] is too long
	from schema $id: http://devicetree.org/schemas/cache/qcom,llcc.yaml#