From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Sibi Sankar <quic_sibis@quicinc.com>,
andersson@kernel.org, konradybcio@kernel.org, krzk+dt@kernel.org,
robh+dt@kernel.org, dmitry.baryshkov@linaro.org
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, conor+dt@kernel.org,
abel.vesa@linaro.org, srinivas.kandagatla@linaro.org,
quic_jjohnson@quicinc.com, maz@kernel.org,
jens.glathe@oldschoolsolutions.biz
Subject: Re: [PATCH V3 3/3] arm64: dts: qcom: Add X1E001DE Snapdragon Devkit for Windows
Date: Mon, 4 Nov 2024 12:25:27 +0100 [thread overview]
Message-ID: <dbed68f8-ec8e-47e2-a2d7-e57363b23e20@oss.qualcomm.com> (raw)
In-Reply-To: <20241025123227.3527720-4-quic_sibis@quicinc.com>
On 25.10.2024 2:32 PM, Sibi Sankar wrote:
> Add initial support for x1e001de devkit platform. This includes:
>
> -DSPs
> -Ethernet (RTL8125BG) over the pcie 5 instance.
> -NVme
> -Wifi
> -USB-C ports
>
> Link: https://www.qualcomm.com/news/releases/2024/05/qualcomm-accelerates-development-for-copilot--pcs-with-snapdrago
> Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
> ---
[...]
> + vreg_nvme: regulator-nvme {
> + compatible = "regulator-fixed";
> +
> + regulator-name = "VREG_NVME_3P3";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> +
> + gpio = <&tlmm 18 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&nvme_reg_en>;
these are backwards
otherwise lgtm
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
next prev parent reply other threads:[~2024-11-04 11:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 12:32 [PATCH V3 0/3] X1E001DE Snapdragon Devkit for Windows Sibi Sankar
2024-10-25 12:32 ` [PATCH V3 1/3] dt-bindings: arm: qcom: Add " Sibi Sankar
2024-10-25 12:32 ` [PATCH V3 2/3] firmware: qcom: uefisecapp: Allow X1E Devkit devices Sibi Sankar
2024-10-25 12:32 ` [PATCH V3 3/3] arm64: dts: qcom: Add X1E001DE Snapdragon Devkit for Windows Sibi Sankar
2024-11-04 11:25 ` Konrad Dybcio [this message]
2024-10-25 13:55 ` [PATCH V3 0/3] " Rob Herring (Arm)
2024-10-27 20:42 ` Jens Glathe
2024-10-30 17:02 ` Marc Zyngier
2024-10-31 9:46 ` Abel Vesa
2024-10-31 10:00 ` Jens Glathe
2024-10-31 12:29 ` Marc Zyngier
2024-10-31 13:34 ` Jens Glathe
2024-11-06 0:53 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbed68f8-ec8e-47e2-a2d7-e57363b23e20@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=jens.glathe@oldschoolsolutions.biz \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=quic_jjohnson@quicinc.com \
--cc=quic_sibis@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox