From: "Rob Herring (Arm)" <robh@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Krishna Kurapati <quic_kriskura@quicinc.com>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Bjorn Andersson <andersson@kernel.org>
Subject: Re: [PATCH v2 1/4] dt-bindings: arm: qcom-soc: extend to support SAR2130P platform
Date: Wed, 30 Oct 2024 08:33:55 -0500 [thread overview]
Message-ID: <173029523595.389190.16064407897855389566.robh@kernel.org> (raw)
In-Reply-To: <20241030-sar2130p-dt-v2-1-027364ca0e86@linaro.org>
On Wed, 30 Oct 2024 13:50:54 +0200, Dmitry Baryshkov wrote:
> Extend the patterns in qcom-soc.yaml to support Qualcomm SAR2130P
> platform.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> Documentation/devicetree/bindings/arm/qcom-soc.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.example.dtb: remoteproc@30000000: compatible: ['qcom,sa8775p-adsp-pas'] is valid under each of {'items': [{'pattern': '^qcom,(sa|sc)8[0-9]+[a-z][a-z]?-.*$'}], 'type': 'array', 'minItems': 1, 'maxItems': 1}, {'items': [{'pattern': '^qcom,(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sar|sc|sd[amx]|sm|x1e)[0-9]+(p|pro)?-.*$'}], 'type': 'array', 'minItems': 1, 'maxItems': 1}
from schema $id: http://devicetree.org/schemas/arm/qcom-soc.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/qcom,sa8775p-gcc.example.dtb: clock-controller@100000: compatible: ['qcom,sa8775p-gcc'] is valid under each of {'items': [{'pattern': '^qcom,(sa|sc)8[0-9]+[a-z][a-z]?-.*$'}], 'type': 'array', 'minItems': 1, 'maxItems': 1}, {'items': [{'pattern': '^qcom,(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sar|sc|sd[amx]|sm|x1e)[0-9]+(p|pro)?-.*$'}], 'type': 'array', 'minItems': 1, 'maxItems': 1}
from schema $id: http://devicetree.org/schemas/arm/qcom-soc.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.example.dtb: phy@8901000: compatible: ['qcom,sa8775p-dwmac-sgmii-phy'] is valid under each of {'items': [{'pattern': '^qcom,(sa|sc)8[0-9]+[a-z][a-z]?-.*$'}], 'type': 'array', 'minItems': 1, 'maxItems': 1}, {'items': [{'pattern': '^qcom,(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sar|sc|sd[amx]|sm|x1e)[0-9]+(p|pro)?-.*$'}], 'type': 'array', 'minItems': 1, 'maxItems': 1}
from schema $id: http://devicetree.org/schemas/arm/qcom-soc.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.example.dtb: pinctrl@f000000: compatible: ['qcom,sa8775p-tlmm'] is valid under each of {'items': [{'pattern': '^qcom,(sa|sc)8[0-9]+[a-z][a-z]?-.*$'}], 'type': 'array', 'minItems': 1, 'maxItems': 1}, {'items': [{'pattern': '^qcom,(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sar|sc|sd[amx]|sm|x1e)[0-9]+(p|pro)?-.*$'}], 'type': 'array', 'minItems': 1, 'maxItems': 1}
from schema $id: http://devicetree.org/schemas/arm/qcom-soc.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/interconnect/qcom,sa8775p-rpmh.example.dtb: interconnect-aggre1-noc: compatible: ['qcom,sa8775p-aggre1-noc'] is valid under each of {'items': [{'pattern': '^qcom,(sa|sc)8[0-9]+[a-z][a-z]?-.*$'}], 'type': 'array', 'minItems': 1, 'maxItems': 1}, {'items': [{'pattern': '^qcom,(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sar|sc|sd[amx]|sm|x1e)[0-9]+(p|pro)?-.*$'}], 'type': 'array', 'minItems': 1, 'maxItems': 1}
from schema $id: http://devicetree.org/schemas/arm/qcom-soc.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241030-sar2130p-dt-v2-1-027364ca0e86@linaro.org
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2024-10-30 13:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 11:50 [PATCH v2 0/4] arm64: dts: qcom: add QAR2130P support Dmitry Baryshkov
2024-10-30 11:50 ` [PATCH v2 1/4] dt-bindings: arm: qcom-soc: extend to support SAR2130P platform Dmitry Baryshkov
2024-10-30 13:33 ` Rob Herring (Arm) [this message]
2024-10-31 8:13 ` Krzysztof Kozlowski
2024-10-31 15:45 ` Dmitry Baryshkov
2024-10-30 11:50 ` [PATCH v2 2/4] dt-bindings: arm: qcom: add QAR2130P board Dmitry Baryshkov
2024-10-30 11:50 ` [PATCH v2 3/4] arm64: dts: qcom: sar2130p: add support for SAR2130P Dmitry Baryshkov
2024-10-31 20:39 ` Konrad Dybcio
2024-10-30 11:50 ` [PATCH v2 4/4] arm64: dts: qcom: sar2130p: add QAR2130P board file Dmitry Baryshkov
2024-10-31 20:42 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173029523595.389190.16064407897855389566.robh@kernel.org \
--to=robh@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_kriskura@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox