From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Krishna Kurapati <quic_kriskura@quicinc.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] arm64: dts: qcom: sar2130p: add QAR2130P board file
Date: Thu, 31 Oct 2024 21:42:13 +0100 [thread overview]
Message-ID: <7a87ff33-2a88-4476-9116-69d6725b8d0c@oss.qualcomm.com> (raw)
In-Reply-To: <20241030-sar2130p-dt-v2-4-027364ca0e86@linaro.org>
On 30.10.2024 12:50 PM, Dmitry Baryshkov wrote:
> Add board DT file for the Qualcomm Snapdragon AR2 Gen1 Smart Viewer
> Development Kit.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
Please add newlines before status consistently
[...]
> +
> + wcn7850-pmu {
> + compatible = "qcom,wcn7850-pmu";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&wlan_en_state>, <&bt_en_state>;
flip please
[...]
> +
> +&pon_resin {
> + status = "okay";
> +
> + linux,code = <KEY_VOLUMEDOWN>;
and here
[...]
> +
> + ptn3222: redriver@4f {
> + compatible = "nxp,ptn3222";
> + reg = <0x4f>;
> + #phy-cells = <0>;
> + vdd3v3-supply = <&vreg_l2a_3p1>;
> + vdd1v8-supply = <&vreg_l15a_1p8>;
> + reset-gpios = <&tlmm 99 GPIO_ACTIVE_LOW>;
Since I'm nitpicking hard already, please see the property order in romulus.dtsi
Looks good otherwise, thanks!
Konrad
prev parent reply other threads:[~2024-10-31 20:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 11:50 [PATCH v2 0/4] arm64: dts: qcom: add QAR2130P support Dmitry Baryshkov
2024-10-30 11:50 ` [PATCH v2 1/4] dt-bindings: arm: qcom-soc: extend to support SAR2130P platform Dmitry Baryshkov
2024-10-30 13:33 ` Rob Herring (Arm)
2024-10-31 8:13 ` Krzysztof Kozlowski
2024-10-31 15:45 ` Dmitry Baryshkov
2024-10-30 11:50 ` [PATCH v2 2/4] dt-bindings: arm: qcom: add QAR2130P board Dmitry Baryshkov
2024-10-30 11:50 ` [PATCH v2 3/4] arm64: dts: qcom: sar2130p: add support for SAR2130P Dmitry Baryshkov
2024-10-31 20:39 ` Konrad Dybcio
2024-10-30 11:50 ` [PATCH v2 4/4] arm64: dts: qcom: sar2130p: add QAR2130P board file Dmitry Baryshkov
2024-10-31 20:42 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a87ff33-2a88-4476-9116-69d6725b8d0c@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_kriskura@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox