[PATCH v2 0/2] Remove apss_dbg clock from IPQ5424 gcc driver

[PATCH v2 0/2] Remove apss_dbg clock from IPQ5424 gcc driver

[Manikanta Mylavarapu]

The gcc_apss_dbg clk is access protected by trust zone, and accessing
it results in a kernel crash. Therefore remove the gcc_apss_dbg_clk
from gcc driver and dt-bindings.

Changes in V2:
	- Fixed all review comments from Krzysztof Kozlowski.
	- Patches were re-ordered to ensure each patch is bisectable.
	- Detailed change logs are added to the respective patches.

V1 can be found at:
https://lore.kernel.org/linux-arm-msm/20241205064037.1960323-1-quic_mmanikan@quicinc.com/

Manikanta Mylavarapu (2):
  clk: qcom: ipq5424: remove apss_dbg clock
  dt-bindings: clock: qcom: gcc-ipq5424: remove apss_dbg clock macro

 drivers/clk/qcom/gcc-ipq5424.c               | 19 -------------------
 include/dt-bindings/clock/qcom,ipq5424-gcc.h |  1 -
 2 files changed, 20 deletions(-)


base-commit: e25c8d66f6786300b680866c0e0139981273feba
-- 
2.34.1

[PATCH v2 1/2] clk: qcom: ipq5424: remove apss_dbg clock

[Manikanta Mylavarapu]

The gcc_apss_dbg clk is access protected by trust zone, and accessing
it results in a kernel crash. Therefore remove the gcc_apss_dbg_clk
from the gcc driver.

Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com>
---
Changes in V2:
	- Updated commit message.
	- Patch #2 from V1 has been moved to Patch #1 in V2 to enusre
	  it is bisecatble.

 drivers/clk/qcom/gcc-ipq5424.c | 19 -------------------
 1 file changed, 19 deletions(-)

diff --git a/drivers/clk/qcom/gcc-ipq5424.c b/drivers/clk/qcom/gcc-ipq5424.c
index 88a7d5b2e751..5f42ac6c8cdc 100644
--- a/drivers/clk/qcom/gcc-ipq5424.c
+++ b/drivers/clk/qcom/gcc-ipq5424.c
@@ -1097,24 +1097,6 @@ static struct clk_branch gcc_adss_pwm_clk = {
 	},
 };
 
-static struct clk_branch gcc_apss_dbg_clk = {
-	.halt_reg = 0x2402c,
-	.halt_check = BRANCH_HALT_VOTED,
-	.clkr = {
-		.enable_reg = 0x2402c,
-		.enable_mask = BIT(0),
-		.hw.init = &(const struct clk_init_data) {
-			.name = "gcc_apss_dbg_clk",
-			.parent_hws = (const struct clk_hw*[]) {
-				&gcc_qdss_dap_sync_clk_src.hw
-			},
-			.num_parents = 1,
-			.flags = CLK_SET_RATE_PARENT,
-			.ops = &clk_branch2_ops,
-		},
-	},
-};
-
 static struct clk_branch gcc_cnoc_pcie0_1lane_s_clk = {
 	.halt_reg = 0x31088,
 	.halt_check = BRANCH_HALT,
@@ -2785,7 +2767,6 @@ static struct clk_branch gcc_pcie3_rchng_clk = {
 static struct clk_regmap *gcc_ipq5424_clocks[] = {
 	[GCC_ADSS_PWM_CLK] = &gcc_adss_pwm_clk.clkr,
 	[GCC_ADSS_PWM_CLK_SRC] = &gcc_adss_pwm_clk_src.clkr,
-	[GCC_APSS_DBG_CLK] = &gcc_apss_dbg_clk.clkr,
 	[GCC_CNOC_PCIE0_1LANE_S_CLK] = &gcc_cnoc_pcie0_1lane_s_clk.clkr,
 	[GCC_CNOC_PCIE1_1LANE_S_CLK] = &gcc_cnoc_pcie1_1lane_s_clk.clkr,
 	[GCC_CNOC_PCIE2_2LANE_S_CLK] = &gcc_cnoc_pcie2_2lane_s_clk.clkr,
-- 
2.34.1

[PATCH v2 2/2] dt-bindings: clock: qcom: gcc-ipq5424: remove apss_dbg clock macro

[Manikanta Mylavarapu]

The gcc_apss_dbg clk is access protected by trust zone, and accessing
it results in a kernel crash. Therefore remove the gcc_apss_dbg_clk macro.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com>
---
Changes in V2:
	- Pick up A-b tag.
	- Updated commit message.
	- Patch #1 from V1 has been moved to Patch #2 in V2 to enusre
	  it is bisecatble.

 include/dt-bindings/clock/qcom,ipq5424-gcc.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/dt-bindings/clock/qcom,ipq5424-gcc.h b/include/dt-bindings/clock/qcom,ipq5424-gcc.h
index 755ce7a71c7c..9f14680052a0 100644
--- a/include/dt-bindings/clock/qcom,ipq5424-gcc.h
+++ b/include/dt-bindings/clock/qcom,ipq5424-gcc.h
@@ -12,7 +12,6 @@
 #define GPLL2					2
 #define GPLL2_OUT_MAIN                          3
 #define GCC_SLEEP_CLK_SRC			4
-#define GCC_APSS_DBG_CLK                        5
 #define GCC_USB0_EUD_AT_CLK			6
 #define GCC_PCIE0_AXI_M_CLK_SRC			7
 #define GCC_PCIE0_AXI_M_CLK			8
-- 
2.34.1

Re: [PATCH v2 0/2] Remove apss_dbg clock from IPQ5424 gcc driver

[Bjorn Andersson]

On Tue, 17 Dec 2024 17:09:07 +0530, Manikanta Mylavarapu wrote:
> The gcc_apss_dbg clk is access protected by trust zone, and accessing
> it results in a kernel crash. Therefore remove the gcc_apss_dbg_clk
> from gcc driver and dt-bindings.
> 
> Changes in V2:
> 	- Fixed all review comments from Krzysztof Kozlowski.
> 	- Patches were re-ordered to ensure each patch is bisectable.
> 	- Detailed change logs are added to the respective patches.
> 
> [...]

Applied, thanks!

[1/2] clk: qcom: ipq5424: remove apss_dbg clock
      commit: 5051b61d769ecc02b218499c35bee4cc1c38b7dc
[2/2] dt-bindings: clock: qcom: gcc-ipq5424: remove apss_dbg clock macro
      commit: 46e6075287e68e1d3d0ea8ecda610064636e0854

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>