* [PATCH] arm64: qcom: romulus: Update firmware names
@ 2025-01-08 12:44 Joel Stanley
2025-01-09 14:34 ` Konrad Dybcio
2025-01-09 23:14 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Joel Stanley @ 2025-01-08 12:44 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio; +Cc: linux-arm-msm, devicetree, linux-kernel
Other x1e machines use _dtbs.elf for these firmwares, which matches the
filenames shipped by Windows.
Fixes: 09d77be56093 ("arm64: dts: qcom: Add support for X1-based Surface Laptop 7 devices")
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
Tested on a Surface Laptop 13 where the firmware appears to load
correctly.
arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi b/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi
index f01eb5ab7dc6..85d28fb8d878 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi
@@ -706,14 +706,14 @@ &qupv3_2 {
&remoteproc_adsp {
firmware-name = "qcom/x1e80100/microsoft/Romulus/qcadsp8380.mbn",
- "qcom/x1e80100/microsoft/Romulus/adsp_dtb.mbn";
+ "qcom/x1e80100/microsoft/Romulus/adsp_dtbs.elf";
status = "okay";
};
&remoteproc_cdsp {
firmware-name = "qcom/x1e80100/microsoft/Romulus/qccdsp8380.mbn",
- "qcom/x1e80100/microsoft/Romulus/cdsp_dtb.mbn";
+ "qcom/x1e80100/microsoft/Romulus/cdsp_dtbs.elf";
status = "okay";
};
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: qcom: romulus: Update firmware names
2025-01-08 12:44 [PATCH] arm64: qcom: romulus: Update firmware names Joel Stanley
@ 2025-01-09 14:34 ` Konrad Dybcio
2025-01-09 23:14 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2025-01-09 14:34 UTC (permalink / raw)
To: Joel Stanley, Bjorn Andersson, Konrad Dybcio
Cc: linux-arm-msm, devicetree, linux-kernel
On 8.01.2025 1:44 PM, Joel Stanley wrote:
> Other x1e machines use _dtbs.elf for these firmwares, which matches the
> filenames shipped by Windows.
>
> Fixes: 09d77be56093 ("arm64: dts: qcom: Add support for X1-based Surface Laptop 7 devices")
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
Right, I renamed these locally.. but it's definitely better to keep
those as-shipped
The commit title should like:
arm64: dts: qcom: x1e80100-romulus: Update firmware nodes
(see git log --oneline path/to/dir for the general format)
but maybe Bjorn can fix that up when applying
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Thanks!
Konrad
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: qcom: romulus: Update firmware names
2025-01-08 12:44 [PATCH] arm64: qcom: romulus: Update firmware names Joel Stanley
2025-01-09 14:34 ` Konrad Dybcio
@ 2025-01-09 23:14 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2025-01-09 23:14 UTC (permalink / raw)
To: Konrad Dybcio, Joel Stanley; +Cc: linux-arm-msm, devicetree, linux-kernel
On Wed, 08 Jan 2025 23:14:59 +1030, Joel Stanley wrote:
> Other x1e machines use _dtbs.elf for these firmwares, which matches the
> filenames shipped by Windows.
>
>
Applied, thanks!
[1/1] arm64: qcom: romulus: Update firmware names
commit: 983833061d9599a534e44fd6d335080d1a0ba985
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-01-09 23:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-08 12:44 [PATCH] arm64: qcom: romulus: Update firmware names Joel Stanley
2025-01-09 14:34 ` Konrad Dybcio
2025-01-09 23:14 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox