* [net PATCH] net: phy: qcom: qca807x fix condition for DAC_DSP_BIAS_CURRENT
@ 2025-02-19 13:09 Christian Marangi
2025-02-19 13:59 ` Andrew Lunn
2025-02-20 21:30 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Christian Marangi @ 2025-02-19 13:09 UTC (permalink / raw)
To: Andrew Lunn, Heiner Kallweit, Russell King, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Maxime Chevallier,
Christophe Leroy, Rob Herring (Arm), Robert Marko,
Christophe JAILLET, George Moussalem, Christian Marangi,
linux-arm-msm, netdev, linux-kernel
Cc: stable
From: George Moussalem <george.moussalem@outlook.com>
While setting the DAC value, the wrong boolean value is evaluated to set
the DSP bias current. So let's correct the conditional statement and use
the right boolean value read from the DTS set in the priv.
Cc: stable@vger.kernel.org
Fixes: d1cb613efbd3 ("net: phy: qcom: add support for QCA807x PHY Family")
Signed-off-by: George Moussalem <george.moussalem@outlook.com>
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
drivers/net/phy/qcom/qca807x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/qcom/qca807x.c b/drivers/net/phy/qcom/qca807x.c
index 3279de857b47..2ad8c2586d64 100644
--- a/drivers/net/phy/qcom/qca807x.c
+++ b/drivers/net/phy/qcom/qca807x.c
@@ -774,7 +774,7 @@ static int qca807x_config_init(struct phy_device *phydev)
control_dac &= ~QCA807X_CONTROL_DAC_MASK;
if (!priv->dac_full_amplitude)
control_dac |= QCA807X_CONTROL_DAC_DSP_AMPLITUDE;
- if (!priv->dac_full_amplitude)
+ if (!priv->dac_full_bias_current)
control_dac |= QCA807X_CONTROL_DAC_DSP_BIAS_CURRENT;
if (!priv->dac_disable_bias_current_tweak)
control_dac |= QCA807X_CONTROL_DAC_BIAS_CURRENT_TWEAK;
--
2.47.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [net PATCH] net: phy: qcom: qca807x fix condition for DAC_DSP_BIAS_CURRENT
2025-02-19 13:09 [net PATCH] net: phy: qcom: qca807x fix condition for DAC_DSP_BIAS_CURRENT Christian Marangi
@ 2025-02-19 13:59 ` Andrew Lunn
2025-02-20 21:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2025-02-19 13:59 UTC (permalink / raw)
To: Christian Marangi
Cc: Heiner Kallweit, Russell King, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Maxime Chevallier, Christophe Leroy,
Rob Herring (Arm), Robert Marko, Christophe JAILLET,
George Moussalem, linux-arm-msm, netdev, linux-kernel, stable
On Wed, Feb 19, 2025 at 02:09:21PM +0100, Christian Marangi wrote:
> From: George Moussalem <george.moussalem@outlook.com>
>
> While setting the DAC value, the wrong boolean value is evaluated to set
> the DSP bias current. So let's correct the conditional statement and use
> the right boolean value read from the DTS set in the priv.
>
> Cc: stable@vger.kernel.org
> Fixes: d1cb613efbd3 ("net: phy: qcom: add support for QCA807x PHY Family")
> Signed-off-by: George Moussalem <george.moussalem@outlook.com>
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [net PATCH] net: phy: qcom: qca807x fix condition for DAC_DSP_BIAS_CURRENT
2025-02-19 13:09 [net PATCH] net: phy: qcom: qca807x fix condition for DAC_DSP_BIAS_CURRENT Christian Marangi
2025-02-19 13:59 ` Andrew Lunn
@ 2025-02-20 21:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-02-20 21:30 UTC (permalink / raw)
To: Christian Marangi
Cc: andrew, hkallweit1, linux, davem, edumazet, kuba, pabeni,
maxime.chevallier, christophe.leroy, robh, robimarko,
christophe.jaillet, george.moussalem, linux-arm-msm, netdev,
linux-kernel, stable
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 19 Feb 2025 14:09:21 +0100 you wrote:
> From: George Moussalem <george.moussalem@outlook.com>
>
> While setting the DAC value, the wrong boolean value is evaluated to set
> the DSP bias current. So let's correct the conditional statement and use
> the right boolean value read from the DTS set in the priv.
>
> Cc: stable@vger.kernel.org
> Fixes: d1cb613efbd3 ("net: phy: qcom: add support for QCA807x PHY Family")
> Signed-off-by: George Moussalem <george.moussalem@outlook.com>
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
>
> [...]
Here is the summary with links:
- [net] net: phy: qcom: qca807x fix condition for DAC_DSP_BIAS_CURRENT
https://git.kernel.org/netdev/net/c/992ee3ed6e9f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-02-20 21:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-19 13:09 [net PATCH] net: phy: qcom: qca807x fix condition for DAC_DSP_BIAS_CURRENT Christian Marangi
2025-02-19 13:59 ` Andrew Lunn
2025-02-20 21:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox