[PATCH 0/3] pmdomain: qcom: rpmhpd: Add SM4450 power domains

[PATCH 0/3] pmdomain: qcom: rpmhpd: Add SM4450 power domains

[Ajit Pandey]

This series add power domains exposed by RPMh in the Qualcomm SM4450 platform.

Signed-off-by: Ajit Pandey <quic_ajipan@quicinc.com>
---
Ajit Pandey (3):
      dt-bindings: power: qcom,rpmpd: Add SM4450 compatible
      pmdomain: qcom: rpmhpd: Add SM4450 power domains
      arm64: dts: qcom: sm4450: Add RPMh power domains support

 .../devicetree/bindings/power/qcom,rpmpd.yaml      |  1 +
 arch/arm64/boot/dts/qcom/sm4450.dtsi               | 68 ++++++++++++++++++++++
 drivers/pmdomain/qcom/rpmhpd.c                     | 16 +++++
 3 files changed, 85 insertions(+)
---
base-commit: f660850bc246fef15ba78c81f686860324396628
change-id: 20250417-sm4450_rpmhpd-6a74794d0cab

Best regards,
-- 
Ajit Pandey <quic_ajipan@quicinc.com>

[PATCH 1/3] dt-bindings: power: qcom,rpmpd: Add SM4450 compatible

[Ajit Pandey]

Document compatible for RPMh power domain controller on SM4450 Platform.

Signed-off-by: Ajit Pandey <quic_ajipan@quicinc.com>
---
 Documentation/devicetree/bindings/power/qcom,rpmpd.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
index 655687369a238a096673a3482082533390283508..1bf65f2a583ab70ac313309f917aaabb75dc3f85 100644
--- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
+++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
@@ -50,6 +50,7 @@ properties:
           - qcom,sdx55-rpmhpd
           - qcom,sdx65-rpmhpd
           - qcom,sdx75-rpmhpd
+          - qcom,sm4450-rpmhpd
           - qcom,sm6115-rpmpd
           - qcom,sm6125-rpmpd
           - qcom,sm6350-rpmhpd

-- 
2.25.1

Re: [PATCH 1/3] dt-bindings: power: qcom,rpmpd: Add SM4450 compatible

[Rob Herring (Arm)]

On Thu, 17 Apr 2025 22:37:39 +0530, Ajit Pandey wrote:
> Document compatible for RPMh power domain controller on SM4450 Platform.
> 
> Signed-off-by: Ajit Pandey <quic_ajipan@quicinc.com>
> ---
>  Documentation/devicetree/bindings/power/qcom,rpmpd.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>

[PATCH 2/3] pmdomain: qcom: rpmhpd: Add SM4450 power domains

[Ajit Pandey]

Add power domains exposed by RPMh in the Qualcomm SM4450 platform.

Signed-off-by: Ajit Pandey <quic_ajipan@quicinc.com>
---
 drivers/pmdomain/qcom/rpmhpd.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/drivers/pmdomain/qcom/rpmhpd.c b/drivers/pmdomain/qcom/rpmhpd.c
index dfd0f80154e49d882a59dd23a8e2d755610c896b..078323b85b5648e33dd89e08cf31bdc5ab76d553 100644
--- a/drivers/pmdomain/qcom/rpmhpd.c
+++ b/drivers/pmdomain/qcom/rpmhpd.c
@@ -360,6 +360,21 @@ static const struct rpmhpd_desc sdx75_desc = {
 	.num_pds = ARRAY_SIZE(sdx75_rpmhpds),
 };
 
+/* SM4450 RPMH powerdomains */
+static struct rpmhpd *sm4450_rpmhpds[] = {
+	[RPMHPD_CX] = &cx,
+	[RPMHPD_CX_AO] = &cx_ao,
+	[RPMHPD_EBI] = &ebi,
+	[RPMHPD_LMX] = &lmx,
+	[RPMHPD_MSS] = &mss,
+	[RPMHPD_MX] = &mx,
+};
+
+static const struct rpmhpd_desc sm4450_desc = {
+	.rpmhpds = sm4450_rpmhpds,
+	.num_pds = ARRAY_SIZE(sm4450_rpmhpds),
+};
+
 /* SM6350 RPMH powerdomains */
 static struct rpmhpd *sm6350_rpmhpds[] = {
 	[SM6350_CX] = &cx_w_mx_parent,
@@ -724,6 +739,7 @@ static const struct of_device_id rpmhpd_match_table[] = {
 	{ .compatible = "qcom,sdx55-rpmhpd", .data = &sdx55_desc},
 	{ .compatible = "qcom,sdx65-rpmhpd", .data = &sdx65_desc},
 	{ .compatible = "qcom,sdx75-rpmhpd", .data = &sdx75_desc},
+	{ .compatible = "qcom,sm4450-rpmhpd", .data = &sm4450_desc },
 	{ .compatible = "qcom,sm6350-rpmhpd", .data = &sm6350_desc },
 	{ .compatible = "qcom,sm7150-rpmhpd", .data = &sm7150_desc },
 	{ .compatible = "qcom,sm8150-rpmhpd", .data = &sm8150_desc },

-- 
2.25.1

Re: [PATCH 2/3] pmdomain: qcom: rpmhpd: Add SM4450 power domains

[Konrad Dybcio]

On 4/17/25 7:07 PM, Ajit Pandey wrote:
> Add power domains exposed by RPMh in the Qualcomm SM4450 platform.
> 
> Signed-off-by: Ajit Pandey <quic_ajipan@quicinc.com>
> ---
>  drivers/pmdomain/qcom/rpmhpd.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/drivers/pmdomain/qcom/rpmhpd.c b/drivers/pmdomain/qcom/rpmhpd.c
> index dfd0f80154e49d882a59dd23a8e2d755610c896b..078323b85b5648e33dd89e08cf31bdc5ab76d553 100644
> --- a/drivers/pmdomain/qcom/rpmhpd.c
> +++ b/drivers/pmdomain/qcom/rpmhpd.c
> @@ -360,6 +360,21 @@ static const struct rpmhpd_desc sdx75_desc = {
>  	.num_pds = ARRAY_SIZE(sdx75_rpmhpds),
>  };
>  
> +/* SM4450 RPMH powerdomains */
> +static struct rpmhpd *sm4450_rpmhpds[] = {
> +	[RPMHPD_CX] = &cx,
> +	[RPMHPD_CX_AO] = &cx_ao,
> +	[RPMHPD_EBI] = &ebi,
> +	[RPMHPD_LMX] = &lmx,
> +	[RPMHPD_MSS] = &mss,
> +	[RPMHPD_MX] = &mx,
> +};

/me wipes glasses

Is there no VDD_GFX?

Konrad

Re: [PATCH 2/3] pmdomain: qcom: rpmhpd: Add SM4450 power domains

[Ajit Pandey]

On 4/18/2025 2:40 AM, Konrad Dybcio wrote:
> On 4/17/25 7:07 PM, Ajit Pandey wrote:
>> Add power domains exposed by RPMh in the Qualcomm SM4450 platform.
>>
>> Signed-off-by: Ajit Pandey <quic_ajipan@quicinc.com>
>> ---
>>   drivers/pmdomain/qcom/rpmhpd.c | 16 ++++++++++++++++
>>   1 file changed, 16 insertions(+)
>>
>> diff --git a/drivers/pmdomain/qcom/rpmhpd.c b/drivers/pmdomain/qcom/rpmhpd.c
>> index dfd0f80154e49d882a59dd23a8e2d755610c896b..078323b85b5648e33dd89e08cf31bdc5ab76d553 100644
>> --- a/drivers/pmdomain/qcom/rpmhpd.c
>> +++ b/drivers/pmdomain/qcom/rpmhpd.c
>> @@ -360,6 +360,21 @@ static const struct rpmhpd_desc sdx75_desc = {
>>   	.num_pds = ARRAY_SIZE(sdx75_rpmhpds),
>>   };
>>   
>> +/* SM4450 RPMH powerdomains */
>> +static struct rpmhpd *sm4450_rpmhpds[] = {
>> +	[RPMHPD_CX] = &cx,
>> +	[RPMHPD_CX_AO] = &cx_ao,
>> +	[RPMHPD_EBI] = &ebi,
>> +	[RPMHPD_LMX] = &lmx,
>> +	[RPMHPD_MSS] = &mss,
>> +	[RPMHPD_MX] = &mx,
>> +};
> 
> /me wipes glasses
> 
> Is there no VDD_GFX?
> 
> Konrad

Yes, there is no VDD_GFX pd in sm4450
-- 
Thanks, and Regards
Ajit

[PATCH 3/3] arm64: dts: qcom: sm4450: Add RPMh power domains support

[Ajit Pandey]

Add device node for RPMh power domains on Qualcomm SM4450 platform.

Signed-off-by: Ajit Pandey <quic_ajipan@quicinc.com>
---
 arch/arm64/boot/dts/qcom/sm4450.dtsi | 68 ++++++++++++++++++++++++++++++++++++
 1 file changed, 68 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm4450.dtsi b/arch/arm64/boot/dts/qcom/sm4450.dtsi
index 27453771aa68a1c4dbd2a986af6785fa05db147d..d217d922811e84420f0f31008e939337b07bc38b 100644
--- a/arch/arm64/boot/dts/qcom/sm4450.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm4450.dtsi
@@ -10,6 +10,8 @@
 #include <dt-bindings/clock/qcom,sm4450-gpucc.h>
 #include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/interrupt-controller/arm-gic.h>
+#include <dt-bindings/power/qcom,rpmhpd.h>
+#include <dt-bindings/power/qcom-rpmpd.h>
 #include <dt-bindings/soc/qcom,rpmh-rsc.h>
 
 / {
@@ -591,6 +593,72 @@ rpmhcc: clock-controller {
 				clocks = <&xo_board>;
 				clock-names = "xo";
 			};
+
+			rpmhpd: power-controller {
+				compatible = "qcom,sm4450-rpmhpd";
+				#power-domain-cells = <1>;
+				operating-points-v2 = <&rpmhpd_opp_table>;
+
+				rpmhpd_opp_table: opp-table {
+					compatible = "operating-points-v2";
+
+					rpmhpd_opp_ret: opp-16 {
+						opp-level = <RPMH_REGULATOR_LEVEL_RETENTION>;
+					};
+
+					rpmhpd_opp_min_svs: opp-48 {
+						opp-level = <RPMH_REGULATOR_LEVEL_MIN_SVS>;
+					};
+
+					rpmhpd_opp_low_svs_d1: opp-56 {
+						opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS_D1>;
+					};
+
+					rpmhpd_opp_low_svs: opp-64 {
+						opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS>;
+					};
+
+					rpmhpd_opp_low_svs_l1: opp-80 {
+						opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS_L1>;
+					};
+
+					rpmhpd_opp_low_svs_l2: opp-96 {
+						opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS_L2>;
+					};
+
+					rpmhpd_opp_svs: opp-128 {
+						opp-level = <RPMH_REGULATOR_LEVEL_SVS>;
+					};
+
+					rpmhpd_opp_svs_l1: opp-192 {
+						opp-level = <RPMH_REGULATOR_LEVEL_SVS_L1>;
+					};
+
+					rpmhpd_opp_svs_l2: opp-224 {
+						opp-level = <RPMH_REGULATOR_LEVEL_SVS_L2>;
+					};
+
+					rpmhpd_opp_nom: opp-256 {
+						opp-level = <RPMH_REGULATOR_LEVEL_NOM>;
+					};
+
+					rpmhpd_opp_nom_l1: opp-320 {
+						opp-level = <RPMH_REGULATOR_LEVEL_NOM_L1>;
+					};
+
+					rpmhpd_opp_nom_l2: opp-336 {
+						opp-level = <RPMH_REGULATOR_LEVEL_NOM_L2>;
+					};
+
+					rpmhpd_opp_turbo: opp-384 {
+						opp-level = <RPMH_REGULATOR_LEVEL_TURBO>;
+					};
+
+					rpmhpd_opp_turbo_l1: opp-416 {
+						opp-level = <RPMH_REGULATOR_LEVEL_TURBO_L1>;
+					};
+				};
+			};
 		};
 
 		cpufreq_hw: cpufreq@17d91000 {

-- 
2.25.1

Re: [PATCH 3/3] arm64: dts: qcom: sm4450: Add RPMh power domains support

[Dmitry Baryshkov]

On Thu, Apr 17, 2025 at 10:37:41PM +0530, Ajit Pandey wrote:
> Add device node for RPMh power domains on Qualcomm SM4450 platform.
> 
> Signed-off-by: Ajit Pandey <quic_ajipan@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sm4450.dtsi | 68 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 68 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

-- 
With best wishes
Dmitry

Re: [PATCH 0/3] pmdomain: qcom: rpmhpd: Add SM4450 power domains

[Ulf Hansson]

On Thu, 17 Apr 2025 at 19:08, Ajit Pandey <quic_ajipan@quicinc.com> wrote:
>
> This series add power domains exposed by RPMh in the Qualcomm SM4450 platform.
>
> Signed-off-by: Ajit Pandey <quic_ajipan@quicinc.com>
> ---
> Ajit Pandey (3):
>       dt-bindings: power: qcom,rpmpd: Add SM4450 compatible
>       pmdomain: qcom: rpmhpd: Add SM4450 power domains
>       arm64: dts: qcom: sm4450: Add RPMh power domains support
>
>  .../devicetree/bindings/power/qcom,rpmpd.yaml      |  1 +
>  arch/arm64/boot/dts/qcom/sm4450.dtsi               | 68 ++++++++++++++++++++++
>  drivers/pmdomain/qcom/rpmhpd.c                     | 16 +++++
>  3 files changed, 85 insertions(+)
> ---
> base-commit: f660850bc246fef15ba78c81f686860324396628
> change-id: 20250417-sm4450_rpmhpd-6a74794d0cab
>
> Best regards,
> --
> Ajit Pandey <quic_ajipan@quicinc.com>
>

Patch 1 and 2 applied for next, thanks!

Kind regards
Uffe

Re: (subset) [PATCH 0/3] pmdomain: qcom: rpmhpd: Add SM4450 power domains

[Bjorn Andersson]

On Thu, 17 Apr 2025 22:37:38 +0530, Ajit Pandey wrote:
> This series add power domains exposed by RPMh in the Qualcomm SM4450 platform.
> 
> 

Applied, thanks!

[3/3] arm64: dts: qcom: sm4450: Add RPMh power domains support
      commit: 654ac800d4ac6bd4bffa7e98997a1e0d336999b1

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>