From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Hans de Goede <hansg@kernel.org>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Mark Pearson <mpearson-lenovo@squebb.ca>,
Sebastian Reichel <sre@kernel.org>
Cc: "Derek J. Clark" <derekjohn.clark@gmail.com>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
Neil Armstrong <neil.armstrong@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH v5 0/3] platform: arm64: thinkpad-t14s-ec: new driver
Date: Tue, 23 Sep 2025 11:40:00 +0300 [thread overview]
Message-ID: <175861680092.3176.3763843003064695385.b4-ty@linux.intel.com> (raw)
In-Reply-To: <20250918-thinkpad-t14s-ec-v5-0-ac0bc6382c5c@collabora.com>
On Thu, 18 Sep 2025 23:20:25 +0200, Sebastian Reichel wrote:
> Introduce driver for the ThinkPad T14s Gen6 Snapdragon EC. In theory
> it seems to be compatible with the ThinkPad ACPI driver, but these
> devices are booted with device tree. As the name implies, the existing
> ThinkPad ACPI driver only supports the ACPI interface. Looking at
> the implementation, the ACPI DSDT contains many mapping functions
> to translate the low level I2C messages into the interface used by
> the ThinkPad ACPI driver. Adding DT support to the ThinkPad ACPI driver
> would require adding all those translation functions, which would add
> more or less the same amount of code as writing a separate driver using
> the low level interface directly. I don't think it's sensible to make
> the existing ACPI driver even more complicated, so I went for a separate
> driver.
>
> [...]
Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.
The list of commits applied:
[1/3] dt-bindings: platform: Add Lenovo Thinkpad T14s EC
commit: bee278e18e641a4bc11513b0fa8f5eb2667b8a32
[2/3] platform: arm64: thinkpad-t14s-ec: new driver
commit: 27221f91b83ff1435e550f57b8380a01bab0fc80
[3/3] arm64: dts: qcom: x1e80100-t14s: add EC
commit: 7de8353e082d179a241dc4a4129c5d6916803399
--
i.
prev parent reply other threads:[~2025-09-23 8:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 21:20 [PATCH v5 0/3] platform: arm64: thinkpad-t14s-ec: new driver Sebastian Reichel
2025-09-18 21:20 ` [PATCH v5 1/3] dt-bindings: platform: Add Lenovo Thinkpad T14s EC Sebastian Reichel
2025-09-19 14:40 ` Rob Herring
2025-09-23 8:41 ` Ilpo Järvinen
2025-09-18 21:20 ` [PATCH v5 2/3] platform: arm64: thinkpad-t14s-ec: new driver Sebastian Reichel
2025-09-18 21:20 ` [PATCH v5 3/3] arm64: dts: qcom: x1e80100-t14s: add EC Sebastian Reichel
2025-09-23 8:40 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175861680092.3176.3763843003064695385.b4-ty@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=derekjohn.clark@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=hansg@kernel.org \
--cc=hmh@hmh.eng.br \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpearson-lenovo@squebb.ca \
--cc=neil.armstrong@linaro.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox