From: "Rob Herring (Arm)" <robh@kernel.org>
To: Vikash Garodia <vikash.garodia@oss.qualcomm.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
devicetree@vger.kernel.org,
Philipp Zabel <p.zabel@pengutronix.de>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Bryan O'Donoghue <bod@kernel.org>,
Vishnu Reddy <quic_bvisredd@quicinc.com>,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
Subject: Re: [PATCH 1/8] media: dt-bindings: qcom-kaanapali-iris: Add kaanapali video codec binding
Date: Thu, 25 Sep 2025 00:11:40 -0500 [thread overview]
Message-ID: <175877709998.3725789.11141152500856219909.robh@kernel.org> (raw)
In-Reply-To: <20250925-knp_video-v1-1-e323c0b3c0cd@oss.qualcomm.com>
On Thu, 25 Sep 2025 04:44:39 +0530, Vikash Garodia wrote:
> Kaanapali SOC brings in the new generation of video IP i.e iris4. When
> compared to previous generation, iris3x, it has,
> - separate power domains for stream and pixel processing hardware blocks
> (bse and vpp).
> - additional power domain for apv codec.
> - power domains for individual pipes (VPPx).
> - different clocks and reset lines.
>
> There are variants of this hardware, where only a single VPP pipe would
> be functional (VPP0), and APV may not be present. In such case, the
> hardware can be enabled without those 2 related power doamins, and
> corresponding clocks. This explains the min entries for power domains
> and clocks.
> Iommus include all the different stream-ids which can be possibly
> generated by vpu4 video hardware in both secure and non secure
> execution mode.
>
> This patch depends on following patches
> https://lore.kernel.org/all/20250924-knp-interconnect-v1-1-4c822a72141c@oss.qualcomm.com/
> https://lore.kernel.org/all/20250924-knp-clk-v1-3-29b02b818782@oss.qualcomm.com/
>
> Signed-off-by: Vikash Garodia <vikash.garodia@oss.qualcomm.com>
> ---
> .../bindings/media/qcom,kaanapali-iris.yaml | 236 +++++++++++++++++++++
> 1 file changed, 236 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/media/qcom,kaanapali-iris.example.dts:24:18: fatal error: dt-bindings/interconnect/qcom,kaanapali-rpmh.h: No such file or directory
24 | #include <dt-bindings/interconnect/qcom,kaanapali-rpmh.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.dtbs:132: Documentation/devicetree/bindings/media/qcom,kaanapali-iris.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1525: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250925-knp_video-v1-1-e323c0b3c0cd@oss.qualcomm.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2025-09-25 5:11 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 23:14 [PATCH 0/8] media: iris: add support for video codecs on Qcom kaanapali platform Vikash Garodia
2025-09-24 23:14 ` [PATCH 1/8] media: dt-bindings: qcom-kaanapali-iris: Add kaanapali video codec binding Vikash Garodia
2025-09-25 3:06 ` Dmitry Baryshkov
2025-09-25 7:57 ` Vikash Garodia
2025-09-25 8:59 ` Konrad Dybcio
2025-09-25 19:09 ` Vikash Garodia
2025-09-25 19:20 ` Dmitry Baryshkov
2025-09-25 5:11 ` Rob Herring (Arm) [this message]
2025-09-25 9:08 ` Krzysztof Kozlowski
2025-09-25 19:23 ` Vikash Garodia
2025-09-25 19:25 ` Dmitry Baryshkov
2025-09-25 19:31 ` Vikash Garodia
2025-09-25 19:38 ` Dmitry Baryshkov
2025-09-25 19:45 ` Vikash Garodia
2025-09-25 20:33 ` Dmitry Baryshkov
2025-09-26 11:47 ` Konrad Dybcio
2025-09-26 13:55 ` Vikash Garodia
2025-09-26 22:25 ` Dmitry Baryshkov
2025-10-02 9:18 ` Vikash Garodia
2025-10-07 13:58 ` Krzysztof Kozlowski
2025-10-08 9:53 ` Vikash Garodia
2025-09-24 23:14 ` [PATCH 2/8] media: iris: Add support for multiple clock sources Vikash Garodia
2025-09-25 23:59 ` Bryan O'Donoghue
2025-10-02 9:25 ` Vikash Garodia
2025-09-24 23:14 ` [PATCH 3/8] media: iris: Add support for multiple TZ CP configs Vikash Garodia
2025-09-25 9:01 ` Konrad Dybcio
2025-09-25 19:27 ` Vikash Garodia
2025-09-26 11:44 ` Konrad Dybcio
2025-09-26 0:30 ` Bryan O'Donoghue
2025-09-29 5:45 ` Vishnu Reddy
2025-09-24 23:14 ` [PATCH 4/8] media: iris: Introduce buffer size calculations for vpu4 Vikash Garodia
2025-09-26 13:00 ` Bryan O'Donoghue
2025-10-02 10:06 ` Vikash Garodia
2025-09-24 23:14 ` [PATCH 5/8] media: iris: Move vpu register defines to common header file Vikash Garodia
2025-09-25 9:10 ` Konrad Dybcio
2025-09-29 5:44 ` Vishnu Reddy
2025-10-07 13:23 ` Konrad Dybcio
2025-10-02 9:35 ` Vikash Garodia
2025-10-07 13:22 ` Konrad Dybcio
2025-10-16 13:47 ` Dmitry Baryshkov
2025-10-16 18:37 ` Vikash Garodia
2025-10-16 18:58 ` Dmitry Baryshkov
2025-09-24 23:14 ` [PATCH 6/8] media: iris: Move vpu35 specific api to common to use for vpu4 Vikash Garodia
2025-09-24 23:14 ` [PATCH 7/8] media: iris: Introduce vpu ops for vpu4 with necessary hooks Vikash Garodia
2025-09-25 9:18 ` Konrad Dybcio
2025-09-29 5:45 ` Vishnu Reddy
2025-10-02 9:41 ` Vikash Garodia
2025-10-07 13:21 ` Konrad Dybcio
2025-09-24 23:14 ` [PATCH 8/8] media: iris: Add platform data for kaanapali Vikash Garodia
2025-09-25 2:44 ` Dmitry Baryshkov
2025-09-25 8:17 ` Vikash Garodia
2025-10-02 15:10 ` Bryan O'Donoghue
2025-10-02 15:29 ` Bryan O'Donoghue
2025-10-18 6:55 ` Vishnu Reddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175877709998.3725789.11141152500856219909.robh@kernel.org \
--to=robh@kernel.org \
--cc=abhinav.kumar@linux.dev \
--cc=bod@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dikshita.agarwal@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=quic_bvisredd@quicinc.com \
--cc=vikash.garodia@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox