[PATCH v2 0/6] Further bringup of SHIFTphone 8

[PATCH v2 0/6] Further bringup of SHIFTphone 8

[Luca Weiss]

Add some cleanups and fixes to shift-otter, and enable flash LED, RGB
LED and Venus.

Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
Changes in v2:
- Pick up tags
- Also remove polling-delay-passive = <0> for thermal zones
- Link to v1: https://lore.kernel.org/r/20250930-otter-further-bringup-v1-0-7fe66f653900@fairphone.com

---
Alexander Martinz (4):
      arm64: dts: qcom: qcm6490-shift-otter: Fix sorting and indentation
      arm64: dts: qcom: qcm6490-shift-otter: Remove thermal zone polling delays
      arm64: dts: qcom: qcm6490-shift-otter: Add missing reserved-memory
      arm64: dts: qcom: qcm6490-shift-otter: Enable venus node

Casey Connolly (1):
      arm64: dts: qcom: qcm6490-shift-otter: Enable flash LED

Luca Weiss (1):
      arm64: dts: qcom: qcm6490-shift-otter: Enable RGB LED

 arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts | 75 ++++++++++++++++++------
 1 file changed, 56 insertions(+), 19 deletions(-)
---
base-commit: 3b9b1f8df454caa453c7fb07689064edb2eda90a
change-id: 20250930-otter-further-bringup-f9e640c4008e

Best regards,
-- 
Luca Weiss <luca.weiss@fairphone.com>

[PATCH v2 1/6] arm64: dts: qcom: qcm6490-shift-otter: Fix sorting and indentation

[Luca Weiss]

From: Alexander Martinz <amartinz@shiftphones.com>

Make sure the nodes are sorted correctly, and the indentation is
correct.

Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
 arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
index eb8efba1b9dd..8d45e6ac0e44 100644
--- a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
+++ b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
@@ -857,7 +857,7 @@ &uart5 {
 &uart7 {
 	/delete-property/interrupts;
 	interrupts-extended = <&intc GIC_SPI 608 IRQ_TYPE_LEVEL_HIGH>,
-			<&tlmm 31 IRQ_TYPE_EDGE_FALLING>;
+			      <&tlmm 31 IRQ_TYPE_EDGE_FALLING>;
 
 	pinctrl-1 = <&qup_uart7_sleep_cts>, <&qup_uart7_sleep_rts>, <&qup_uart7_sleep_tx>, <&qup_uart7_sleep_rx>;
 	pinctrl-names = "default", "sleep";
@@ -920,10 +920,6 @@ &usb_1_dwc3_hs {
 	remote-endpoint = <&pmic_glink_hs_in>;
 };
 
-&usb_dp_qmpphy_out {
-	remote-endpoint = <&pmic_glink_ss_in>;
-};
-
 &usb_1_hsphy {
 	vdda-pll-supply = <&vreg_l10c>;
 	vdda18-supply = <&vreg_l1c>;
@@ -950,6 +946,10 @@ &usb_1_qmpphy {
 	status = "okay";
 };
 
+&usb_dp_qmpphy_out {
+	remote-endpoint = <&pmic_glink_ss_in>;
+};
+
 &wifi {
 	qcom,calibration-variant = "SHIFTphone_8";
 

-- 
2.51.0

Re: [PATCH v2 1/6] arm64: dts: qcom: qcm6490-shift-otter: Fix sorting and indentation

[Dmitry Baryshkov]

On Thu, Oct 09, 2025 at 11:06:31AM +0200, Luca Weiss wrote:
> From: Alexander Martinz <amartinz@shiftphones.com>
> 
> Make sure the nodes are sorted correctly, and the indentation is
> correct.
> 
> Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
>  arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry

[PATCH v2 2/6] arm64: dts: qcom: qcm6490-shift-otter: Remove thermal zone polling delays

[Luca Weiss]

From: Alexander Martinz <amartinz@shiftphones.com>

As with all other devices in commit 7747a49db7e5 ("arm64: dts: qcom:
sc7280-*: Remove thermal zone polling delays"), apply the same change to
this device as the delays are assumed to be equal to "0" if not set.

Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
 arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
index 8d45e6ac0e44..0d331bda4a82 100644
--- a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
+++ b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
@@ -130,8 +130,6 @@ rmtfs_mem: rmtfs@f8500000 {
 
 	thermal-zones {
 		camera-thermal {
-			polling-delay-passive = <0>;
-			polling-delay = <0>;
 			thermal-sensors = <&pmk8350_adc_tm 2>;
 
 			trips {
@@ -144,8 +142,6 @@ active-config0 {
 		};
 
 		chg-skin-thermal {
-			polling-delay-passive = <0>;
-			polling-delay = <0>;
 			thermal-sensors = <&pm7250b_adc_tm 0>;
 
 			trips {
@@ -158,8 +154,6 @@ active-config0 {
 		};
 
 		conn-thermal {
-			polling-delay-passive = <0>;
-			polling-delay = <0>;
 			thermal-sensors = <&pm7250b_adc_tm 1>;
 
 			trips {
@@ -172,8 +166,6 @@ active-config0 {
 		};
 
 		quiet-thermal {
-			polling-delay-passive = <0>;
-			polling-delay = <0>;
 			thermal-sensors = <&pmk8350_adc_tm 1>;
 
 			trips {
@@ -186,8 +178,6 @@ active-config0 {
 		};
 
 		rear-cam-thermal {
-			polling-delay-passive = <0>;
-			polling-delay = <0>;
 			thermal-sensors = <&pmk8350_adc_tm 4>;
 
 			trips {
@@ -200,8 +190,6 @@ active-config0 {
 		};
 
 		sdm-skin-thermal {
-			polling-delay-passive = <0>;
-			polling-delay = <0>;
 			thermal-sensors = <&pmk8350_adc_tm 3>;
 
 			trips {
@@ -214,8 +202,6 @@ active-config0 {
 		};
 
 		xo-thermal {
-			polling-delay-passive = <0>;
-			polling-delay = <0>;
 			thermal-sensors = <&pmk8350_adc_tm 0>;
 
 			trips {

-- 
2.51.0

Re: [PATCH v2 2/6] arm64: dts: qcom: qcm6490-shift-otter: Remove thermal zone polling delays

[Konrad Dybcio]

On 10/9/25 11:06 AM, Luca Weiss wrote:
> From: Alexander Martinz <amartinz@shiftphones.com>
> 
> As with all other devices in commit 7747a49db7e5 ("arm64: dts: qcom:
> sc7280-*: Remove thermal zone polling delays"), apply the same change to
> this device as the delays are assumed to be equal to "0" if not set.
> 
> Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

[PATCH v2 3/6] arm64: dts: qcom: qcm6490-shift-otter: Add missing reserved-memory

[Luca Weiss]

From: Alexander Martinz <amartinz@shiftphones.com>

It seems we also need to reserve a region of 81 MiB called "removed_mem"
otherwise we can easily hit memory errors with higher RAM usage.

Fixes: 249666e34c24 ("arm64: dts: qcom: add QCM6490 SHIFTphone 8")
Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
 arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
index 0d331bda4a82..31650c29b1ca 100644
--- a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
+++ b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
@@ -118,6 +118,11 @@ cdsp_mem: cdsp@88f00000 {
 			no-map;
 		};
 
+		removed_mem: removed@c0000000 {
+			reg = <0x0 0xc0000000 0x0 0x5100000>;
+			no-map;
+		};
+
 		rmtfs_mem: rmtfs@f8500000 {
 			compatible = "qcom,rmtfs-mem";
 			reg = <0x0 0xf8500000 0x0 0x600000>;

-- 
2.51.0

Re: [PATCH v2 3/6] arm64: dts: qcom: qcm6490-shift-otter: Add missing reserved-memory

[Dmitry Baryshkov]

On Thu, Oct 09, 2025 at 11:06:33AM +0200, Luca Weiss wrote:
> From: Alexander Martinz <amartinz@shiftphones.com>
> 
> It seems we also need to reserve a region of 81 MiB called "removed_mem"
> otherwise we can easily hit memory errors with higher RAM usage.
> 
> Fixes: 249666e34c24 ("arm64: dts: qcom: add QCM6490 SHIFTphone 8")
> Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
>  arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry

Re: [PATCH v2 3/6] arm64: dts: qcom: qcm6490-shift-otter: Add missing reserved-memory

[Bjorn Andersson]

On Thu, Oct 09, 2025 at 11:06:33AM +0200, Luca Weiss wrote:
> From: Alexander Martinz <amartinz@shiftphones.com>
> 
> It seems we also need to reserve a region of 81 MiB called "removed_mem"
> otherwise we can easily hit memory errors with higher RAM usage.
> 

If you make sure CONFIG_MEMTEST is enabled, you can boot with memtest=1
on the command line to catch such issues, without relying on "higher RAM
usage" (or randomness).

Regards,
Bjorn

> Fixes: 249666e34c24 ("arm64: dts: qcom: add QCM6490 SHIFTphone 8")
> Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
>  arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
> index 0d331bda4a82..31650c29b1ca 100644
> --- a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
> @@ -118,6 +118,11 @@ cdsp_mem: cdsp@88f00000 {
>  			no-map;
>  		};
>  
> +		removed_mem: removed@c0000000 {
> +			reg = <0x0 0xc0000000 0x0 0x5100000>;
> +			no-map;
> +		};
> +
>  		rmtfs_mem: rmtfs@f8500000 {
>  			compatible = "qcom,rmtfs-mem";
>  			reg = <0x0 0xf8500000 0x0 0x600000>;
> 
> -- 
> 2.51.0
> 

Re: [PATCH v2 3/6] arm64: dts: qcom: qcm6490-shift-otter: Add missing reserved-memory

[Luca Weiss]

On Mon Oct 27, 2025 at 5:45 PM CET, Bjorn Andersson wrote:
> On Thu, Oct 09, 2025 at 11:06:33AM +0200, Luca Weiss wrote:
>> From: Alexander Martinz <amartinz@shiftphones.com>
>> 
>> It seems we also need to reserve a region of 81 MiB called "removed_mem"
>> otherwise we can easily hit memory errors with higher RAM usage.
>> 
>
> If you make sure CONFIG_MEMTEST is enabled, you can boot with memtest=1
> on the command line to catch such issues, without relying on "higher RAM
> usage" (or randomness).

Good idea, ran it now and no issue seen.

[    0.000000] Machine model: SHIFT SHIFTphone 8
     <...>
[    0.000000] early_memtest: # of tests: 1
[    0.000000]   0x0000000080880000 - 0x0000000080884000 pattern 0000000000000000
[    0.000000]   0x0000000080894000 - 0x00000000808ff000 pattern 0000000000000000
[    0.000000]   0x0000000081800000 - 0x0000000086700000 pattern 0000000000000000
[    0.000000]   0x000000008ad00000 - 0x000000008b200000 pattern 0000000000000000
[    0.000000]   0x000000008b710000 - 0x000000008b71a000 pattern 0000000000000000
[    0.000000]   0x000000008b71c000 - 0x000000008b800000 pattern 0000000000000000
[    0.000000]   0x000000009c700000 - 0x00000000a0080000 pattern 0000000000000000
[    0.000000]   0x00000000a18b0000 - 0x00000000af41e000 pattern 0000000000000000
[    0.000000]   0x00000000af43fe53 - 0x00000000af61f000 pattern 0000000000000000
[    0.000000]   0x00000000affff000 - 0x00000000b7100000 pattern 0000000000000000
[    0.000000]   0x00000000c5100000 - 0x00000000e1000000 pattern 0000000000000000
[    0.000000]   0x00000000e3300000 - 0x00000000f8500000 pattern 0000000000000000
[    0.000000]   0x00000000f8b00000 - 0x000000037e857c78 pattern 0000000000000000
[    0.000000]   0x000000037e857ca7 - 0x000000037e857ca8 pattern 0000000000000000
[    0.000000]   0x000000037e857cd7 - 0x000000037e857cd8 pattern 0000000000000000
[    0.000000]   0x000000037e857d04 - 0x000000037e857d08 pattern 0000000000000000
[    0.000000]   0x000000037e857d34 - 0x000000037e857d38 pattern 0000000000000000
[    0.000000]   0x000000037e857d64 - 0x000000037e857d68 pattern 0000000000000000
[    0.000000]   0x000000037e857d94 - 0x000000037e857d98 pattern 0000000000000000
[    0.000000]   0x000000037e857dc4 - 0x000000037e857dc8 pattern 0000000000000000
[    0.000000]   0x000000037e857df4 - 0x000000037e857df8 pattern 0000000000000000
[    0.000000]   0x000000037e857e24 - 0x000000037e857e28 pattern 0000000000000000
[    0.000000]   0x000000037e857e54 - 0x000000037e857e58 pattern 0000000000000000
[    0.000000]   0x000000037e857e84 - 0x000000037e857e88 pattern 0000000000000000
[    0.000000]   0x000000037e857eb4 - 0x000000037e857eb8 pattern 0000000000000000
[    0.000000]   0x000000037e857ee4 - 0x000000037e857ee8 pattern 0000000000000000
[    0.000000]   0x000000037e857f14 - 0x000000037e857f18 pattern 0000000000000000
[    0.000000]   0x000000037e857f44 - 0x000000037e857f48 pattern 0000000000000000
[    0.000000]   0x000000037e857f74 - 0x000000037e857f78 pattern 0000000000000000
[    0.000000]   0x000000037e857fa4 - 0x000000037e857fa8 pattern 0000000000000000
[    0.000000]   0x000000037e857fd4 - 0x000000037e857fd8 pattern 0000000000000000
[    0.000000]   0x000000037e858004 - 0x000000037e858008 pattern 0000000000000000
[    0.000000]   0x000000037e858034 - 0x000000037e858038 pattern 0000000000000000
[    0.000000]   0x000000037e858064 - 0x000000037e858068 pattern 0000000000000000
[    0.000000]   0x000000037e858094 - 0x000000037e858098 pattern 0000000000000000
[    0.000000]   0x000000037e8580c4 - 0x000000037e8580c8 pattern 0000000000000000
[    0.000000]   0x000000037e8580f4 - 0x000000037e8580f8 pattern 0000000000000000
[    0.000000]   0x000000037e858124 - 0x000000037e858128 pattern 0000000000000000
[    0.000000]   0x000000037e858154 - 0x000000037e858158 pattern 0000000000000000
[    0.000000]   0x000000037e858184 - 0x000000037e858188 pattern 0000000000000000
[    0.000000]   0x000000037e8581b4 - 0x000000037e8581b8 pattern 0000000000000000
[    0.000000]   0x000000037e8581e4 - 0x000000037e8581e8 pattern 0000000000000000
[    0.000000]   0x000000037e858214 - 0x000000037e858218 pattern 0000000000000000
[    0.000000]   0x000000037e858244 - 0x000000037e858248 pattern 0000000000000000
[    0.000000]   0x000000037e858274 - 0x000000037e858278 pattern 0000000000000000
[    0.000000]   0x000000037e8582a4 - 0x000000037e8582a8 pattern 0000000000000000
[    0.000000]   0x000000037e8582d4 - 0x000000037e8582d8 pattern 0000000000000000
[    0.000000]   0x000000037e858304 - 0x000000037e858308 pattern 0000000000000000
[    0.000000]   0x000000037e858334 - 0x000000037e858338 pattern 0000000000000000

Regards
Luca

>
> Regards,
> Bjorn
>
>> Fixes: 249666e34c24 ("arm64: dts: qcom: add QCM6490 SHIFTphone 8")
>> Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
>> ---
>>  arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts | 5 +++++
>>  1 file changed, 5 insertions(+)
>> 
>> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
>> index 0d331bda4a82..31650c29b1ca 100644
>> --- a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
>> @@ -118,6 +118,11 @@ cdsp_mem: cdsp@88f00000 {
>>  			no-map;
>>  		};
>>  
>> +		removed_mem: removed@c0000000 {
>> +			reg = <0x0 0xc0000000 0x0 0x5100000>;
>> +			no-map;
>> +		};
>> +
>>  		rmtfs_mem: rmtfs@f8500000 {
>>  			compatible = "qcom,rmtfs-mem";
>>  			reg = <0x0 0xf8500000 0x0 0x600000>;
>> 
>> -- 
>> 2.51.0
>> 

[PATCH v2 4/6] arm64: dts: qcom: qcm6490-shift-otter: Enable flash LED

[Luca Weiss]

From: Casey Connolly <casey.connolly@linaro.org>

Describe the flash LED on this phone.

Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
 arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
index 31650c29b1ca..ac6ed79e57b1 100644
--- a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
+++ b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
@@ -605,6 +605,19 @@ volume_down_default: volume-down-default-state {
 	};
 };
 
+&pm8350c_flash {
+	status = "okay";
+
+	led-0 {
+		function = LED_FUNCTION_FLASH;
+		color = <LED_COLOR_ID_WHITE>;
+		led-sources = <1>, <2>;
+		led-max-microamp = <500000>;
+		flash-max-microamp = <1500000>;
+		flash-max-timeout-us = <1280000>;
+	};
+};
+
 &pmk8350_adc_tm {
 	status = "okay";
 

-- 
2.51.0

Re: [PATCH v2 4/6] arm64: dts: qcom: qcm6490-shift-otter: Enable flash LED

[Dmitry Baryshkov]

On Thu, Oct 09, 2025 at 11:06:34AM +0200, Luca Weiss wrote:
> From: Casey Connolly <casey.connolly@linaro.org>
> 
> Describe the flash LED on this phone.
> 
> Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
>  arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry

[PATCH v2 5/6] arm64: dts: qcom: qcm6490-shift-otter: Enable RGB LED

[Luca Weiss]

From: Luca Weiss <luca@lucaweiss.eu>

Enable the RGB LED connected to the PM7350C (PM8350C).

Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
 arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts | 27 ++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
index ac6ed79e57b1..af6f7b41201d 100644
--- a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
+++ b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
@@ -618,6 +618,33 @@ led-0 {
 	};
 };
 
+&pm8350c_pwm {
+	status = "okay";
+
+	multi-led {
+		color = <LED_COLOR_ID_RGB>;
+		function = LED_FUNCTION_STATUS;
+
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		led@1 {
+			reg = <1>;
+			color = <LED_COLOR_ID_RED>;
+		};
+
+		led@2 {
+			reg = <2>;
+			color = <LED_COLOR_ID_GREEN>;
+		};
+
+		led@3 {
+			reg = <3>;
+			color = <LED_COLOR_ID_BLUE>;
+		};
+	};
+};
+
 &pmk8350_adc_tm {
 	status = "okay";
 

-- 
2.51.0

Re: [PATCH v2 5/6] arm64: dts: qcom: qcm6490-shift-otter: Enable RGB LED

[Dmitry Baryshkov]

On Thu, Oct 09, 2025 at 11:06:35AM +0200, Luca Weiss wrote:
> From: Luca Weiss <luca@lucaweiss.eu>
> 
> Enable the RGB LED connected to the PM7350C (PM8350C).
> 
> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
>  arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts | 27 ++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 

-- 
With best wishes
Dmitry

Re: [PATCH v2 5/6] arm64: dts: qcom: qcm6490-shift-otter: Enable RGB LED

[Konrad Dybcio]

On 10/9/25 4:42 PM, Dmitry Baryshkov wrote:
> On Thu, Oct 09, 2025 at 11:06:35AM +0200, Luca Weiss wrote:
>> From: Luca Weiss <luca@lucaweiss.eu>
>>
>> Enable the RGB LED connected to the PM7350C (PM8350C).
>>
>> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
>> ---

(you sent an empty email, Dmitry)

Konrad

Re: [PATCH v2 5/6] arm64: dts: qcom: qcm6490-shift-otter: Enable RGB LED

[Dmitry Baryshkov]

On Thu, Oct 09, 2025 at 04:46:24PM +0200, Konrad Dybcio wrote:
> On 10/9/25 4:42 PM, Dmitry Baryshkov wrote:
> > On Thu, Oct 09, 2025 at 11:06:35AM +0200, Luca Weiss wrote:
> >> From: Luca Weiss <luca@lucaweiss.eu>
> >>
> >> Enable the RGB LED connected to the PM7350C (PM8350C).
> >>
> >> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
> >> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> >> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> >> ---
> 
> (you sent an empty email, Dmitry)

Ouch


Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>



-- 
With best wishes
Dmitry

Re: [PATCH v2 5/6] arm64: dts: qcom: qcm6490-shift-otter: Enable RGB LED

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 478 bytes --]

On Thu 2025-10-09 11:06:35, Luca Weiss wrote:
> From: Luca Weiss <luca@lucaweiss.eu>
> 
> Enable the RGB LED connected to the PM7350C (PM8350C).
> 
> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>

Reviewed-by: Pavel Machek <pavel@ucw.cz>

-- 
I don't work for Nazis and criminals, and neither should you.
Boycott Putin, Trump, Netanyahu and Musk!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[PATCH v2 6/6] arm64: dts: qcom: qcm6490-shift-otter: Enable venus node

[Luca Weiss]

From: Alexander Martinz <amartinz@shiftphones.com>

Enable the venus node so that the video encoder/decoder will start
working.

Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
 arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
index af6f7b41201d..a3e6b6a96530 100644
--- a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
+++ b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
@@ -981,6 +981,12 @@ &usb_dp_qmpphy_out {
 	remote-endpoint = <&pmic_glink_ss_in>;
 };
 
+&venus {
+	firmware-name = "qcom/qcm6490/SHIFT/otter/venus.mbn";
+
+	status = "okay";
+};
+
 &wifi {
 	qcom,calibration-variant = "SHIFTphone_8";
 

-- 
2.51.0

Re: [PATCH v2 6/6] arm64: dts: qcom: qcm6490-shift-otter: Enable venus node

[Dmitry Baryshkov]

On Thu, Oct 09, 2025 at 11:06:36AM +0200, Luca Weiss wrote:
> From: Alexander Martinz <amartinz@shiftphones.com>
> 
> Enable the venus node so that the video encoder/decoder will start
> working.
> 
> Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
>  arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
> index af6f7b41201d..a3e6b6a96530 100644
> --- a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
> @@ -981,6 +981,12 @@ &usb_dp_qmpphy_out {
>  	remote-endpoint = <&pmic_glink_ss_in>;
>  };
>  
> +&venus {
> +	firmware-name = "qcom/qcm6490/SHIFT/otter/venus.mbn";

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


> +
> +	status = "okay";
> +};
> +
>  &wifi {
>  	qcom,calibration-variant = "SHIFTphone_8";
>  
> 
> -- 
> 2.51.0
> 

-- 
With best wishes
Dmitry

Re: [PATCH v2 0/6] Further bringup of SHIFTphone 8

[Bjorn Andersson]

On Thu, 09 Oct 2025 11:06:30 +0200, Luca Weiss wrote:
> Add some cleanups and fixes to shift-otter, and enable flash LED, RGB
> LED and Venus.
> 
> 

Applied, thanks!

[1/6] arm64: dts: qcom: qcm6490-shift-otter: Fix sorting and indentation
      commit: 03eb18495d2d91214e840064641eade208fcd8c7
[2/6] arm64: dts: qcom: qcm6490-shift-otter: Remove thermal zone polling delays
      commit: a206ee34db2eff05d3d58214ba2e827824b2bc7b
[3/6] arm64: dts: qcom: qcm6490-shift-otter: Add missing reserved-memory
      commit: f404fdcb50021fdad6bc734d69468cc777901a80
[4/6] arm64: dts: qcom: qcm6490-shift-otter: Enable flash LED
      commit: 2fd302ea31af00eff7d8e2c9fb13209ea6959195
[5/6] arm64: dts: qcom: qcm6490-shift-otter: Enable RGB LED
      commit: 66e74839662d06ddd11b310a8465b91802030531
[6/6] arm64: dts: qcom: qcm6490-shift-otter: Enable venus node
      commit: 6e66efe16bde9c498789d8156da3aeb0b24e9c90

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>