[PATCH v2] arm64: dts: qcom: sdm845-shift-axolotl: fix touchscreen properties

[PATCH v2] arm64: dts: qcom: sdm845-shift-axolotl: fix touchscreen properties

[Joel Selvaraj via B4 Relay]

From: Joel Selvaraj <foss@joelselvaraj.com>

The touchscreen properties previously upstreamed was based on downstream
touchscreen driver. We ended up adapting upstream edt_ft5x06 driver to
support the touchscreen controller used in this device. Update the
touchscreen properties to match with the upstream edt_ft5x06
driver.

Also, the touchscreen controller used in this device is ft5452 and not
fts8719. Fix the compatible string accordingly.

The wakeup-source property was removed as it prevents the touchscreen's
regulators and irq from being disabled when the device is suspended and
could lead to unexpected battery drain. Once low power mode and
tap-to-wake functionality is properly implemented and tested to be
working, we can add it back, if needed.

Signed-off-by: Joel Selvaraj <foss@joelselvaraj.com>
---
Changes in v2:
- Split the commit message into multiple paragraphs. (Konrad Dybcio)
- Add explanation for removing the wakeup-source property. (Konrad Dybcio)
- Link to v1: https://lore.kernel.org/r/20250919-shift-axolotl-fix-touchscreen-dts-v1-1-60e26ad4e038@joelselvaraj.com
---
 arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
index 89260fce6513937224f76a94e1833a5a8d59faa4..d4062844234e33b0d501bcb7d0b6d5386c822937 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
@@ -434,20 +434,19 @@ &i2c5 {
 	status = "okay";
 
 	touchscreen@38 {
-		compatible = "focaltech,fts8719";
+		compatible = "focaltech,ft5452";
 		reg = <0x38>;
-		wakeup-source;
-		interrupt-parent = <&tlmm>;
-		interrupts = <125 IRQ_TYPE_EDGE_FALLING>;
-		vdd-supply = <&vreg_l28a_3p0>;
-		vcc-i2c-supply = <&vreg_l14a_1p88>;
 
-		pinctrl-names = "default", "suspend";
+		interrupts-extended = <&tlmm 125 IRQ_TYPE_EDGE_FALLING>;
+		reset-gpios = <&tlmm 99 GPIO_ACTIVE_LOW>;
+
+		vcc-supply = <&vreg_l28a_3p0>;
+		iovcc-supply = <&vreg_l14a_1p88>;
+
 		pinctrl-0 = <&ts_int_active &ts_reset_active>;
 		pinctrl-1 = <&ts_int_suspend &ts_reset_suspend>;
+		pinctrl-names = "default", "suspend";
 
-		reset-gpio = <&tlmm 99 GPIO_ACTIVE_HIGH>;
-		irq-gpio = <&tlmm 125 GPIO_TRANSITORY>;
 		touchscreen-size-x = <1080>;
 		touchscreen-size-y = <2160>;
 	};

---
base-commit: fe45352cd106ae41b5ad3f0066c2e54dbb2dfd70
change-id: 20250919-shift-axolotl-fix-touchscreen-dts-afa274c233de

Best regards,
-- 
Joel Selvaraj <foss@joelselvaraj.com>

Re: [PATCH v2] arm64: dts: qcom: sdm845-shift-axolotl: fix touchscreen properties

[Konrad Dybcio]

On 10/21/25 8:20 AM, Joel Selvaraj via B4 Relay wrote:
> From: Joel Selvaraj <foss@joelselvaraj.com>
> 
> The touchscreen properties previously upstreamed was based on downstream
> touchscreen driver. We ended up adapting upstream edt_ft5x06 driver to
> support the touchscreen controller used in this device. Update the
> touchscreen properties to match with the upstream edt_ft5x06
> driver.
> 
> Also, the touchscreen controller used in this device is ft5452 and not
> fts8719. Fix the compatible string accordingly.
> 
> The wakeup-source property was removed as it prevents the touchscreen's
> regulators and irq from being disabled when the device is suspended and
> could lead to unexpected battery drain. Once low power mode and
> tap-to-wake functionality is properly implemented and tested to be
> working, we can add it back, if needed.
> 
> Signed-off-by: Joel Selvaraj <foss@joelselvaraj.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

Re: [PATCH v2] arm64: dts: qcom: sdm845-shift-axolotl: fix touchscreen properties

[Bjorn Andersson]

On Tue, 21 Oct 2025 01:20:49 -0500, Joel Selvaraj wrote:
> The touchscreen properties previously upstreamed was based on downstream
> touchscreen driver. We ended up adapting upstream edt_ft5x06 driver to
> support the touchscreen controller used in this device. Update the
> touchscreen properties to match with the upstream edt_ft5x06
> driver.
> 
> Also, the touchscreen controller used in this device is ft5452 and not
> fts8719. Fix the compatible string accordingly.
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: qcom: sdm845-shift-axolotl: fix touchscreen properties
      commit: e19dc81263853d7fb41944db9fe7a54400c0b1b0

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>