From: Krzysztof Kozlowski <krzk@kernel.org>
To: Wenmeng Liu <quic_wenmliu@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
bryan.odonoghue@linaro.org, todor.too@gmail.com,
rfoss@kernel.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: qcs615: Enable camss for qcs615-adp-air
Date: Tue, 20 May 2025 11:44:07 +0200 [thread overview]
Message-ID: <19efba52-7cb4-4c7e-9c97-779214d3ea2a@kernel.org> (raw)
In-Reply-To: <20250520-qcs615-adp-air-camss-v1-2-ac25ca137d34@quicinc.com>
On 20/05/2025 10:56, Wenmeng Liu wrote:
> This change enables camera driver for QCS615 ADP AIR board.
>
> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/qcs615-ride.dts | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> index 2b5aa3c66867676bda59ff82b902b6e4974126f8..be8b829ec508d7de7a4cd6be6d1d4e83b09734bb 100644
> --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> @@ -211,6 +211,13 @@ vreg_l17a: ldo17 {
> };
> };
>
> +&camss {
> + vdda-phy-supply = <&vreg_l5a>;
> + vdda-pll-supply = <&vreg_l12a>;
> +
> + status = "ok";
Standard qcom comment...
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Maybe you need to update your dtschema and yamllint. Don't rely on
distro packages for dtschema and be sure you are using the latest
released dtschema.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-05-20 9:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-20 8:56 [PATCH 0/2] arm64: dts: qcom: qcs615: Add support for camss Wenmeng Liu
2025-05-20 8:56 ` [PATCH 1/2] " Wenmeng Liu
2025-05-20 10:52 ` Dmitry Baryshkov
2025-05-22 18:57 ` Konrad Dybcio
2025-05-20 8:56 ` [PATCH 2/2] arm64: dts: qcom: qcs615: Enable camss for qcs615-adp-air Wenmeng Liu
2025-05-20 9:44 ` Krzysztof Kozlowski [this message]
2025-05-20 10:06 ` Wenmeng Liu
2025-05-20 12:19 ` Vladimir Zapolskiy
2025-05-21 1:32 ` Wenmeng Liu
2025-05-21 5:52 ` Vladimir Zapolskiy
2025-05-21 6:04 ` Krzysztof Kozlowski
2025-05-21 13:00 ` Dmitry Baryshkov
2025-05-21 13:07 ` Dmitry Baryshkov
2025-05-21 13:07 ` Bryan O'Donoghue
2025-05-22 6:58 ` Wenmeng Liu
2025-05-20 9:42 ` [PATCH 0/2] arm64: dts: qcom: qcs615: Add support for camss Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19efba52-7cb4-4c7e-9c97-779214d3ea2a@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=quic_wenmliu@quicinc.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox