From: Krzysztof Kozlowski <krzk@kernel.org>
To: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Wenmeng Liu <quic_wenmliu@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
bryan.odonoghue@linaro.org, todor.too@gmail.com,
rfoss@kernel.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: qcs615: Enable camss for qcs615-adp-air
Date: Wed, 21 May 2025 08:04:10 +0200 [thread overview]
Message-ID: <9babbddc-5c45-4ef4-8fbc-0da64ce99a42@kernel.org> (raw)
In-Reply-To: <76052af9-96c2-46d6-85c6-65998c389554@linaro.org>
On 21/05/2025 07:52, Vladimir Zapolskiy wrote:
>> We can perform validation through the CSID TPG(Test Pattern Generator),
>> so I enabled CAMSS.
>>
>
> Since this is just a test of CAMSS without any sensors/CSIPHY, then
>
> 1. camss-csiphy-3ph-1-0.c changes from the series have never been tested
> and added as dead code, it shall be removed from the series,
> 2. adding voltage regulators to the board dts is void and shall be removed.
>
> Not to substitute but in addition to the above it's still doubtful, if just
> a hardware/driver test configuration deserves to be added into the dts.
No, it does not deserve to be added. It's useless code in upstream. They
just want to push whatever they had downstream and drop their patch count.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-05-21 6:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-20 8:56 [PATCH 0/2] arm64: dts: qcom: qcs615: Add support for camss Wenmeng Liu
2025-05-20 8:56 ` [PATCH 1/2] " Wenmeng Liu
2025-05-20 10:52 ` Dmitry Baryshkov
2025-05-22 18:57 ` Konrad Dybcio
2025-05-20 8:56 ` [PATCH 2/2] arm64: dts: qcom: qcs615: Enable camss for qcs615-adp-air Wenmeng Liu
2025-05-20 9:44 ` Krzysztof Kozlowski
2025-05-20 10:06 ` Wenmeng Liu
2025-05-20 12:19 ` Vladimir Zapolskiy
2025-05-21 1:32 ` Wenmeng Liu
2025-05-21 5:52 ` Vladimir Zapolskiy
2025-05-21 6:04 ` Krzysztof Kozlowski [this message]
2025-05-21 13:00 ` Dmitry Baryshkov
2025-05-21 13:07 ` Dmitry Baryshkov
2025-05-21 13:07 ` Bryan O'Donoghue
2025-05-22 6:58 ` Wenmeng Liu
2025-05-20 9:42 ` [PATCH 0/2] arm64: dts: qcom: qcs615: Add support for camss Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9babbddc-5c45-4ef4-8fbc-0da64ce99a42@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=quic_wenmliu@quicinc.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=todor.too@gmail.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox