* [PATCH v2] dt-bindings: display/msm: qcom,sa8775p-mdss: fix the example
@ 2024-11-12 3:21 Dmitry Baryshkov
2024-11-12 3:40 ` Abhinav Kumar
2024-11-12 17:23 ` [PATCH v2] dt-bindings: display/msm: qcom,sa8775p-mdss: " Rob Herring (Arm)
0 siblings, 2 replies; 7+ messages in thread
From: Dmitry Baryshkov @ 2024-11-12 3:21 UTC (permalink / raw)
To: Rob Clark, Abhinav Kumar, Sean Paul, Marijn Suijten,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Mahadevan, Krzysztof Kozlowski, linux-arm-msm, dri-devel,
freedreno, devicetree, linux-kernel
Add p1 region to the list of DP registers in the SA8775p example. This
fixes the following warning:
Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.example.dtb: displayport-controller@af54000: reg: [[183844864, 260], [183845376, 192], [183848960, 1904], [183853056, 156]] is too short
Fixes: 409685915f00 ("dt-bindings: display/msm: Document MDSS on SA8775P")
Reported-by: Rob Herring <robh@kernel.org>
Closes: https://lore.kernel.org/dri-devel/CAL_JsqJ0zoyaZAgZtyJ8xMsPY+YzrbF-YG1vPN6tFoFXQaW09w@mail.gmail.com/c
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
Changes in v2:
- EDITME: describe what is new in this series revision.
- EDITME: use bulletpoints and terse descriptions.
- Link to v1: https://lore.kernel.org/r/20241112-fd-dp-fux-warning-v1-1-705b527f5a63@linaro.org
---
Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
index 58f8a01f29c7aaa9dc943c232363075686c06a7c..4536bb2f971f3b7173b8807f90c9af3e460bb01c 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
@@ -168,7 +168,8 @@ examples:
reg = <0xaf54000 0x104>,
<0xaf54200 0x0c0>,
<0xaf55000 0x770>,
- <0xaf56000 0x09c>;
+ <0xaf56000 0x09c>,
+ <0xaf57000 0x09c>;
interrupt-parent = <&mdss0>;
interrupts = <12>;
---
base-commit: ff2ce06d5e28be5ee399a2ff894d6a551c70a318
change-id: 20241112-fd-dp-fux-warning-c8764c93f787
Best regards,
--
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v2] dt-bindings: display/msm: qcom,sa8775p-mdss: fix the example
2024-11-12 3:21 [PATCH v2] dt-bindings: display/msm: qcom,sa8775p-mdss: fix the example Dmitry Baryshkov
@ 2024-11-12 3:40 ` Abhinav Kumar
2024-11-12 13:15 ` Dmitry Baryshkov
2024-11-12 17:23 ` [PATCH v2] dt-bindings: display/msm: qcom,sa8775p-mdss: " Rob Herring (Arm)
1 sibling, 1 reply; 7+ messages in thread
From: Abhinav Kumar @ 2024-11-12 3:40 UTC (permalink / raw)
To: Dmitry Baryshkov, Rob Clark, Sean Paul, Marijn Suijten,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Mahadevan, Krzysztof Kozlowski, linux-arm-msm, dri-devel,
freedreno, devicetree, linux-kernel
On 11/11/2024 7:21 PM, Dmitry Baryshkov wrote:
> Add p1 region to the list of DP registers in the SA8775p example. This
> fixes the following warning:
>
> Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.example.dtb: displayport-controller@af54000: reg: [[183844864, 260], [183845376, 192], [183848960, 1904], [183853056, 156]] is too short
>
> Fixes: 409685915f00 ("dt-bindings: display/msm: Document MDSS on SA8775P")
> Reported-by: Rob Herring <robh@kernel.org>
> Closes: https://lore.kernel.org/dri-devel/CAL_JsqJ0zoyaZAgZtyJ8xMsPY+YzrbF-YG1vPN6tFoFXQaW09w@mail.gmail.com/c
Thanks for the patch.
I think this link has an extra 'c' at the end.
With that fixed,
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> Changes in v2:
> - EDITME: describe what is new in this series revision.
> - EDITME: use bulletpoints and terse descriptions.
> - Link to v1: https://lore.kernel.org/r/20241112-fd-dp-fux-warning-v1-1-705b527f5a63@linaro.org
> ---
> Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
> index 58f8a01f29c7aaa9dc943c232363075686c06a7c..4536bb2f971f3b7173b8807f90c9af3e460bb01c 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
> @@ -168,7 +168,8 @@ examples:
> reg = <0xaf54000 0x104>,
> <0xaf54200 0x0c0>,
> <0xaf55000 0x770>,
> - <0xaf56000 0x09c>;
> + <0xaf56000 0x09c>,
> + <0xaf57000 0x09c>;
>
> interrupt-parent = <&mdss0>;
> interrupts = <12>;
>
> ---
> base-commit: ff2ce06d5e28be5ee399a2ff894d6a551c70a318
> change-id: 20241112-fd-dp-fux-warning-c8764c93f787
>
> Best regards,
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v2] dt-bindings: display/msm: qcom,sa8775p-mdss: fix the example
2024-11-12 3:40 ` Abhinav Kumar
@ 2024-11-12 13:15 ` Dmitry Baryshkov
2024-11-12 19:16 ` [PATCH v2] dt-bindings: display/msm: qcom, sa8775p-mdss: " Abhinav Kumar
0 siblings, 1 reply; 7+ messages in thread
From: Dmitry Baryshkov @ 2024-11-12 13:15 UTC (permalink / raw)
To: Abhinav Kumar
Cc: Rob Clark, Sean Paul, Marijn Suijten, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Mahadevan,
Krzysztof Kozlowski, linux-arm-msm, dri-devel, freedreno,
devicetree, linux-kernel
On Tue, 12 Nov 2024 at 05:40, Abhinav Kumar <quic_abhinavk@quicinc.com> wrote:
>
>
>
> On 11/11/2024 7:21 PM, Dmitry Baryshkov wrote:
> > Add p1 region to the list of DP registers in the SA8775p example. This
> > fixes the following warning:
> >
> > Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.example.dtb: displayport-controller@af54000: reg: [[183844864, 260], [183845376, 192], [183848960, 1904], [183853056, 156]] is too short
> >
> > Fixes: 409685915f00 ("dt-bindings: display/msm: Document MDSS on SA8775P")
> > Reported-by: Rob Herring <robh@kernel.org>
> > Closes: https://lore.kernel.org/dri-devel/CAL_JsqJ0zoyaZAgZtyJ8xMsPY+YzrbF-YG1vPN6tFoFXQaW09w@mail.gmail.com/c
>
> Thanks for the patch.
>
> I think this link has an extra 'c' at the end.
Oh.. Can you fix that when picking it up for -fixes or would you
prefer to have a clean version in patchwork?
>
> With that fixed,
>
> Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
>
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > ---
> > Changes in v2:
> > - EDITME: describe what is new in this series revision.
> > - EDITME: use bulletpoints and terse descriptions.
> > - Link to v1: https://lore.kernel.org/r/20241112-fd-dp-fux-warning-v1-1-705b527f5a63@linaro.org
> > ---
> > Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
> > index 58f8a01f29c7aaa9dc943c232363075686c06a7c..4536bb2f971f3b7173b8807f90c9af3e460bb01c 100644
> > --- a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
> > +++ b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
> > @@ -168,7 +168,8 @@ examples:
> > reg = <0xaf54000 0x104>,
> > <0xaf54200 0x0c0>,
> > <0xaf55000 0x770>,
> > - <0xaf56000 0x09c>;
> > + <0xaf56000 0x09c>,
> > + <0xaf57000 0x09c>;
> >
> > interrupt-parent = <&mdss0>;
> > interrupts = <12>;
> >
> > ---
> > base-commit: ff2ce06d5e28be5ee399a2ff894d6a551c70a318
> > change-id: 20241112-fd-dp-fux-warning-c8764c93f787
> >
> > Best regards,
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v2] dt-bindings: display/msm: qcom, sa8775p-mdss: fix the example
2024-11-12 13:15 ` Dmitry Baryshkov
@ 2024-11-12 19:16 ` Abhinav Kumar
2024-12-02 11:21 ` Krzysztof Kozlowski
0 siblings, 1 reply; 7+ messages in thread
From: Abhinav Kumar @ 2024-11-12 19:16 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Rob Clark, Sean Paul, Marijn Suijten, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Mahadevan,
Krzysztof Kozlowski, linux-arm-msm, dri-devel, freedreno,
devicetree, linux-kernel
On 11/12/2024 5:15 AM, Dmitry Baryshkov wrote:
> On Tue, 12 Nov 2024 at 05:40, Abhinav Kumar <quic_abhinavk@quicinc.com> wrote:
>>
>>
>>
>> On 11/11/2024 7:21 PM, Dmitry Baryshkov wrote:
>>> Add p1 region to the list of DP registers in the SA8775p example. This
>>> fixes the following warning:
>>>
>>> Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.example.dtb: displayport-controller@af54000: reg: [[183844864, 260], [183845376, 192], [183848960, 1904], [183853056, 156]] is too short
>>>
>>> Fixes: 409685915f00 ("dt-bindings: display/msm: Document MDSS on SA8775P")
>>> Reported-by: Rob Herring <robh@kernel.org>
>>> Closes: https://lore.kernel.org/dri-devel/CAL_JsqJ0zoyaZAgZtyJ8xMsPY+YzrbF-YG1vPN6tFoFXQaW09w@mail.gmail.com/c
>>
>> Thanks for the patch.
>>
>> I think this link has an extra 'c' at the end.
>
> Oh.. Can you fix that when picking it up for -fixes or would you
> prefer to have a clean version in patchwork?
>
Yes, I can fix it up while applying.
Thanks
Abhinav
>>
>> With that fixed,
>>
>> Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
>>
>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>>> ---
>>> Changes in v2:
>>> - EDITME: describe what is new in this series revision.
>>> - EDITME: use bulletpoints and terse descriptions.
>>> - Link to v1: https://lore.kernel.org/r/20241112-fd-dp-fux-warning-v1-1-705b527f5a63@linaro.org
>>> ---
>>> Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
>>> index 58f8a01f29c7aaa9dc943c232363075686c06a7c..4536bb2f971f3b7173b8807f90c9af3e460bb01c 100644
>>> --- a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
>>> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
>>> @@ -168,7 +168,8 @@ examples:
>>> reg = <0xaf54000 0x104>,
>>> <0xaf54200 0x0c0>,
>>> <0xaf55000 0x770>,
>>> - <0xaf56000 0x09c>;
>>> + <0xaf56000 0x09c>,
>>> + <0xaf57000 0x09c>;
>>>
>>> interrupt-parent = <&mdss0>;
>>> interrupts = <12>;
>>>
>>> ---
>>> base-commit: ff2ce06d5e28be5ee399a2ff894d6a551c70a318
>>> change-id: 20241112-fd-dp-fux-warning-c8764c93f787
>>>
>>> Best regards,
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v2] dt-bindings: display/msm: qcom, sa8775p-mdss: fix the example
2024-11-12 19:16 ` [PATCH v2] dt-bindings: display/msm: qcom, sa8775p-mdss: " Abhinav Kumar
@ 2024-12-02 11:21 ` Krzysztof Kozlowski
2024-12-03 3:40 ` Abhinav Kumar
0 siblings, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2024-12-02 11:21 UTC (permalink / raw)
To: Abhinav Kumar, Dmitry Baryshkov
Cc: Rob Clark, Sean Paul, Marijn Suijten, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Mahadevan,
Krzysztof Kozlowski, linux-arm-msm, dri-devel, freedreno,
devicetree, linux-kernel
On 12/11/2024 20:16, Abhinav Kumar wrote:
>
>
> On 11/12/2024 5:15 AM, Dmitry Baryshkov wrote:
>> On Tue, 12 Nov 2024 at 05:40, Abhinav Kumar <quic_abhinavk@quicinc.com> wrote:
>>>
>>>
>>>
>>> On 11/11/2024 7:21 PM, Dmitry Baryshkov wrote:
>>>> Add p1 region to the list of DP registers in the SA8775p example. This
>>>> fixes the following warning:
>>>>
>>>> Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.example.dtb: displayport-controller@af54000: reg: [[183844864, 260], [183845376, 192], [183848960, 1904], [183853056, 156]] is too short
>>>>
>>>> Fixes: 409685915f00 ("dt-bindings: display/msm: Document MDSS on SA8775P")
>>>> Reported-by: Rob Herring <robh@kernel.org>
>>>> Closes: https://lore.kernel.org/dri-devel/CAL_JsqJ0zoyaZAgZtyJ8xMsPY+YzrbF-YG1vPN6tFoFXQaW09w@mail.gmail.com/c
>>>
>>> Thanks for the patch.
>>>
>>> I think this link has an extra 'c' at the end.
>>
>> Oh.. Can you fix that when picking it up for -fixes or would you
>> prefer to have a clean version in patchwork?
>>
>
> Yes, I can fix it up while applying.
This was supposed to be send still for v6.13-rc1... I don't understand
why not, but it happened so now v6.13-rc1 has a regression - binding
warning (binding, not DTS!). All people testing on v6.13-rc1, all
maintainer trees etc. now have this warning.
Please send the fix soon, so maintainers can for example rebase their trees.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v2] dt-bindings: display/msm: qcom, sa8775p-mdss: fix the example
2024-12-02 11:21 ` Krzysztof Kozlowski
@ 2024-12-03 3:40 ` Abhinav Kumar
0 siblings, 0 replies; 7+ messages in thread
From: Abhinav Kumar @ 2024-12-03 3:40 UTC (permalink / raw)
To: Krzysztof Kozlowski, Dmitry Baryshkov
Cc: Rob Clark, Sean Paul, Marijn Suijten, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Mahadevan,
Krzysztof Kozlowski, linux-arm-msm, dri-devel, freedreno,
devicetree, linux-kernel
On 12/2/2024 3:21 AM, Krzysztof Kozlowski wrote:
> On 12/11/2024 20:16, Abhinav Kumar wrote:
>>
>>
>> On 11/12/2024 5:15 AM, Dmitry Baryshkov wrote:
>>> On Tue, 12 Nov 2024 at 05:40, Abhinav Kumar <quic_abhinavk@quicinc.com> wrote:
>>>>
>>>>
>>>>
>>>> On 11/11/2024 7:21 PM, Dmitry Baryshkov wrote:
>>>>> Add p1 region to the list of DP registers in the SA8775p example. This
>>>>> fixes the following warning:
>>>>>
>>>>> Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.example.dtb: displayport-controller@af54000: reg: [[183844864, 260], [183845376, 192], [183848960, 1904], [183853056, 156]] is too short
>>>>>
>>>>> Fixes: 409685915f00 ("dt-bindings: display/msm: Document MDSS on SA8775P")
>>>>> Reported-by: Rob Herring <robh@kernel.org>
>>>>> Closes: https://lore.kernel.org/dri-devel/CAL_JsqJ0zoyaZAgZtyJ8xMsPY+YzrbF-YG1vPN6tFoFXQaW09w@mail.gmail.com/c
>>>>
>>>> Thanks for the patch.
>>>>
>>>> I think this link has an extra 'c' at the end.
>>>
>>> Oh.. Can you fix that when picking it up for -fixes or would you
>>> prefer to have a clean version in patchwork?
>>>
>>
>> Yes, I can fix it up while applying.
>
> This was supposed to be send still for v6.13-rc1... I don't understand
> why not, but it happened so now v6.13-rc1 has a regression - binding
> warning (binding, not DTS!). All people testing on v6.13-rc1, all
> maintainer trees etc. now have this warning.
>
> Please send the fix soon, so maintainers can for example rebase their trees.
>
> Best regards,
> Krzysztof
I have queued this up in a MR and will make sure its included in a PR
for msm-fixes in a day or two.
Sorry for the delay. Will be picked up soon.
Thanks
Abhinav
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] dt-bindings: display/msm: qcom,sa8775p-mdss: fix the example
2024-11-12 3:21 [PATCH v2] dt-bindings: display/msm: qcom,sa8775p-mdss: fix the example Dmitry Baryshkov
2024-11-12 3:40 ` Abhinav Kumar
@ 2024-11-12 17:23 ` Rob Herring (Arm)
1 sibling, 0 replies; 7+ messages in thread
From: Rob Herring (Arm) @ 2024-11-12 17:23 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: dri-devel, linux-arm-msm, Maarten Lankhorst, devicetree,
linux-kernel, David Airlie, Rob Clark, Marijn Suijten,
Krzysztof Kozlowski, Mahadevan, freedreno, Abhinav Kumar,
Sean Paul, Simona Vetter, Thomas Zimmermann, Krzysztof Kozlowski,
Conor Dooley, Maxime Ripard
On Tue, 12 Nov 2024 05:21:24 +0200, Dmitry Baryshkov wrote:
> Add p1 region to the list of DP registers in the SA8775p example. This
> fixes the following warning:
>
> Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.example.dtb: displayport-controller@af54000: reg: [[183844864, 260], [183845376, 192], [183848960, 1904], [183853056, 156]] is too short
>
> Fixes: 409685915f00 ("dt-bindings: display/msm: Document MDSS on SA8775P")
> Reported-by: Rob Herring <robh@kernel.org>
> Closes: https://lore.kernel.org/dri-devel/CAL_JsqJ0zoyaZAgZtyJ8xMsPY+YzrbF-YG1vPN6tFoFXQaW09w@mail.gmail.com/c
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> Changes in v2:
> - EDITME: describe what is new in this series revision.
> - EDITME: use bulletpoints and terse descriptions.
> - Link to v1: https://lore.kernel.org/r/20241112-fd-dp-fux-warning-v1-1-705b527f5a63@linaro.org
> ---
> Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-12-03 3:40 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-12 3:21 [PATCH v2] dt-bindings: display/msm: qcom,sa8775p-mdss: fix the example Dmitry Baryshkov
2024-11-12 3:40 ` Abhinav Kumar
2024-11-12 13:15 ` Dmitry Baryshkov
2024-11-12 19:16 ` [PATCH v2] dt-bindings: display/msm: qcom, sa8775p-mdss: " Abhinav Kumar
2024-12-02 11:21 ` Krzysztof Kozlowski
2024-12-03 3:40 ` Abhinav Kumar
2024-11-12 17:23 ` [PATCH v2] dt-bindings: display/msm: qcom,sa8775p-mdss: " Rob Herring (Arm)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox