* [PATCH] power: reset: qcom-pon: drop of_match_ptr for ID table
@ 2023-03-10 20:06 Krzysztof Kozlowski
2023-03-10 20:10 ` Konrad Dybcio
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-10 20:06 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Sebastian Reichel,
linux-arm-msm, linux-pm, linux-kernel
Cc: Krzysztof Kozlowski
The Qualcomm SoC power-on driver is specific to ARCH_QCOM which depends
on OF thus the driver is OF-only. It's of_device_id table is built
unconditionally, thus of_match_ptr() for ID table does not make sense.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/power/reset/qcom-pon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/reset/qcom-pon.c b/drivers/power/reset/qcom-pon.c
index 16bc01738be9..ebdcfb28c4a0 100644
--- a/drivers/power/reset/qcom-pon.c
+++ b/drivers/power/reset/qcom-pon.c
@@ -91,7 +91,7 @@ static struct platform_driver pm8916_pon_driver = {
.probe = pm8916_pon_probe,
.driver = {
.name = "pm8916-pon",
- .of_match_table = of_match_ptr(pm8916_pon_id_table),
+ .of_match_table = pm8916_pon_id_table,
},
};
module_platform_driver(pm8916_pon_driver);
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] power: reset: qcom-pon: drop of_match_ptr for ID table
2023-03-10 20:06 [PATCH] power: reset: qcom-pon: drop of_match_ptr for ID table Krzysztof Kozlowski
@ 2023-03-10 20:10 ` Konrad Dybcio
2023-03-10 20:48 ` Marijn Suijten
2023-03-12 22:33 ` Sebastian Reichel
2 siblings, 0 replies; 7+ messages in thread
From: Konrad Dybcio @ 2023-03-10 20:10 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson,
Sebastian Reichel, linux-arm-msm, linux-pm, linux-kernel
On 10.03.2023 21:06, Krzysztof Kozlowski wrote:
> The Qualcomm SoC power-on driver is specific to ARCH_QCOM which depends
> on OF thus the driver is OF-only. It's of_device_id table is built
> unconditionally, thus of_match_ptr() for ID table does not make sense.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> drivers/power/reset/qcom-pon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/reset/qcom-pon.c b/drivers/power/reset/qcom-pon.c
> index 16bc01738be9..ebdcfb28c4a0 100644
> --- a/drivers/power/reset/qcom-pon.c
> +++ b/drivers/power/reset/qcom-pon.c
> @@ -91,7 +91,7 @@ static struct platform_driver pm8916_pon_driver = {
> .probe = pm8916_pon_probe,
> .driver = {
> .name = "pm8916-pon",
> - .of_match_table = of_match_ptr(pm8916_pon_id_table),
> + .of_match_table = pm8916_pon_id_table,
> },
> };
> module_platform_driver(pm8916_pon_driver);
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] power: reset: qcom-pon: drop of_match_ptr for ID table
2023-03-10 20:06 [PATCH] power: reset: qcom-pon: drop of_match_ptr for ID table Krzysztof Kozlowski
2023-03-10 20:10 ` Konrad Dybcio
@ 2023-03-10 20:48 ` Marijn Suijten
2023-03-10 20:54 ` Krzysztof Kozlowski
2023-03-12 22:33 ` Sebastian Reichel
2 siblings, 1 reply; 7+ messages in thread
From: Marijn Suijten @ 2023-03-10 20:48 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Sebastian Reichel,
linux-arm-msm, linux-pm, linux-kernel
On 2023-03-10 21:06:52, Krzysztof Kozlowski wrote:
> The Qualcomm SoC power-on driver is specific to ARCH_QCOM which depends
> on OF thus the driver is OF-only. It's of_device_id table is built
Its*
> unconditionally, thus of_match_ptr() for ID table does not make sense.
Agreed. Searching for of_match_ptr on any *qcom* file yields 25 results
on a few-weeks-old tree, are you planning on assessing those too?
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org>
> ---
> drivers/power/reset/qcom-pon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/reset/qcom-pon.c b/drivers/power/reset/qcom-pon.c
> index 16bc01738be9..ebdcfb28c4a0 100644
> --- a/drivers/power/reset/qcom-pon.c
> +++ b/drivers/power/reset/qcom-pon.c
> @@ -91,7 +91,7 @@ static struct platform_driver pm8916_pon_driver = {
> .probe = pm8916_pon_probe,
> .driver = {
> .name = "pm8916-pon",
> - .of_match_table = of_match_ptr(pm8916_pon_id_table),
> + .of_match_table = pm8916_pon_id_table,
> },
> };
> module_platform_driver(pm8916_pon_driver);
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] power: reset: qcom-pon: drop of_match_ptr for ID table
2023-03-10 20:48 ` Marijn Suijten
@ 2023-03-10 20:54 ` Krzysztof Kozlowski
0 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-10 20:54 UTC (permalink / raw)
To: Marijn Suijten
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Sebastian Reichel,
linux-arm-msm, linux-pm, linux-kernel
On 10/03/2023 21:48, Marijn Suijten wrote:
> On 2023-03-10 21:06:52, Krzysztof Kozlowski wrote:
>> The Qualcomm SoC power-on driver is specific to ARCH_QCOM which depends
>> on OF thus the driver is OF-only. It's of_device_id table is built
>
> Its*
>
>> unconditionally, thus of_match_ptr() for ID table does not make sense.
>
> Agreed. Searching for of_match_ptr on any *qcom* file yields 25 results
> on a few-weeks-old tree, are you planning on assessing those too?
>
There are just few incorrect usages, I'll fix these. Rest has proper
maybe_unused or ifdef.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] power: reset: qcom-pon: drop of_match_ptr for ID table
2023-03-10 21:43 [PATCH 1/9] ASoC: qcom: lpass-sc7280: Drop " Krzysztof Kozlowski
@ 2023-03-10 21:43 ` Krzysztof Kozlowski
2023-03-10 22:35 ` Krzysztof Kozlowski
0 siblings, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-10 21:43 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Sebastian Reichel,
Claudiu Beznea, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Nicolas Ferre, Alexandre Belloni,
Lars-Peter Clausen, Nuno Sá, Oder Chiou, Srinivas Kandagatla,
Banajit Goswami, Krzysztof Kozlowski, Sylwester Nawrocki,
linux-arm-msm, linux-pm, linux-kernel, alsa-devel,
linux-arm-kernel
The Qualcomm SoC power-on driver is specific to ARCH_QCOM which depends
on OF thus the driver is OF-only. It's of_device_id table is built
unconditionally, thus of_match_ptr() for ID table does not make sense.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/power/reset/qcom-pon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/reset/qcom-pon.c b/drivers/power/reset/qcom-pon.c
index 16bc01738be9..ebdcfb28c4a0 100644
--- a/drivers/power/reset/qcom-pon.c
+++ b/drivers/power/reset/qcom-pon.c
@@ -91,7 +91,7 @@ static struct platform_driver pm8916_pon_driver = {
.probe = pm8916_pon_probe,
.driver = {
.name = "pm8916-pon",
- .of_match_table = of_match_ptr(pm8916_pon_id_table),
+ .of_match_table = pm8916_pon_id_table,
},
};
module_platform_driver(pm8916_pon_driver);
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] power: reset: qcom-pon: drop of_match_ptr for ID table
2023-03-10 21:43 ` [PATCH] power: reset: qcom-pon: drop " Krzysztof Kozlowski
@ 2023-03-10 22:35 ` Krzysztof Kozlowski
0 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-10 22:35 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Sebastian Reichel,
Claudiu Beznea, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Nicolas Ferre, Alexandre Belloni,
Lars-Peter Clausen, Nuno Sá, Oder Chiou, Srinivas Kandagatla,
Banajit Goswami, Sylwester Nawrocki, linux-arm-msm, linux-pm,
linux-kernel, alsa-devel, linux-arm-kernel
On 10/03/2023 22:43, Krzysztof Kozlowski wrote:
> The Qualcomm SoC power-on driver is specific to ARCH_QCOM which depends
> on OF thus the driver is OF-only. It's of_device_id table is built
> unconditionally, thus of_match_ptr() for ID table does not make sense.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> drivers/power/reset/qcom-pon.c | 2 +-
This one is a duplicate - I already sent it separate. Please ignore.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] power: reset: qcom-pon: drop of_match_ptr for ID table
2023-03-10 20:06 [PATCH] power: reset: qcom-pon: drop of_match_ptr for ID table Krzysztof Kozlowski
2023-03-10 20:10 ` Konrad Dybcio
2023-03-10 20:48 ` Marijn Suijten
@ 2023-03-12 22:33 ` Sebastian Reichel
2 siblings, 0 replies; 7+ messages in thread
From: Sebastian Reichel @ 2023-03-12 22:33 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, linux-arm-msm,
linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1086 bytes --]
Hi,
On Fri, Mar 10, 2023 at 09:06:52PM +0100, Krzysztof Kozlowski wrote:
> The Qualcomm SoC power-on driver is specific to ARCH_QCOM which depends
> on OF thus the driver is OF-only. It's of_device_id table is built
> unconditionally, thus of_match_ptr() for ID table does not make sense.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Thanks, queued to power-supply's for next branch.
-- Sebastian
> drivers/power/reset/qcom-pon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/reset/qcom-pon.c b/drivers/power/reset/qcom-pon.c
> index 16bc01738be9..ebdcfb28c4a0 100644
> --- a/drivers/power/reset/qcom-pon.c
> +++ b/drivers/power/reset/qcom-pon.c
> @@ -91,7 +91,7 @@ static struct platform_driver pm8916_pon_driver = {
> .probe = pm8916_pon_probe,
> .driver = {
> .name = "pm8916-pon",
> - .of_match_table = of_match_ptr(pm8916_pon_id_table),
> + .of_match_table = pm8916_pon_id_table,
> },
> };
> module_platform_driver(pm8916_pon_driver);
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-03-12 22:33 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-10 20:06 [PATCH] power: reset: qcom-pon: drop of_match_ptr for ID table Krzysztof Kozlowski
2023-03-10 20:10 ` Konrad Dybcio
2023-03-10 20:48 ` Marijn Suijten
2023-03-10 20:54 ` Krzysztof Kozlowski
2023-03-12 22:33 ` Sebastian Reichel
-- strict thread matches above, loose matches on Subject: below --
2023-03-10 21:43 [PATCH 1/9] ASoC: qcom: lpass-sc7280: Drop " Krzysztof Kozlowski
2023-03-10 21:43 ` [PATCH] power: reset: qcom-pon: drop " Krzysztof Kozlowski
2023-03-10 22:35 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox