* [PATCH 03/19] ARM: msm: proc_comm_boot_wait should not be __init [not found] <1359123276-15833-1-git-send-email-arnd@arndb.de> @ 2013-01-25 14:14 ` Arnd Bergmann 2013-01-25 18:16 ` David Brown [not found] ` <1359153858-31992-1-git-send-email-arnd@arndb.de> 1 sibling, 1 reply; 4+ messages in thread From: Arnd Bergmann @ 2013-01-25 14:14 UTC (permalink / raw) To: linux-arm-kernel Cc: linux-kernel, Arnd Bergmann, David Brown, Bryan Huntsman, Daniel Walker, linux-arm-msm msm_smd_probe is a driver probe function and may get called after the __init time, so it must not call any __init function, as the link-time warning reports. Take away the __init annotation on proc_comm_boot_wait to fix this. Without this patch, building msm_defconfig results in: WARNING: vmlinux.o(.text+0xb048): Section mismatch in reference from the function msm_smd_probe() to the function .init.text:proc_comm_boot_wait() The function msm_smd_probe() references the function __init proc_comm_boot_wait(). This is often because msm_smd_probe lacks a __init annotation or the annotation of proc_comm_boot_wait is wrong. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: David Brown <davidb@codeaurora.org> Cc: Bryan Huntsman <bryanh@codeaurora.org> Cc: Daniel Walker <c_dwalke@quicinc.com> Cc: linux-arm-msm@vger.kernel.org --- arch/arm/mach-msm/proc_comm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-msm/proc_comm.h b/arch/arm/mach-msm/proc_comm.h index 12da4ca..e8d043a 100644 --- a/arch/arm/mach-msm/proc_comm.h +++ b/arch/arm/mach-msm/proc_comm.h @@ -253,6 +253,6 @@ enum { (((drvstr) & 0xF) << 17)) int msm_proc_comm(unsigned cmd, unsigned *data1, unsigned *data2); -void __init proc_comm_boot_wait(void); +void proc_comm_boot_wait(void); #endif -- 1.8.0 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 03/19] ARM: msm: proc_comm_boot_wait should not be __init 2013-01-25 14:14 ` [PATCH 03/19] ARM: msm: proc_comm_boot_wait should not be __init Arnd Bergmann @ 2013-01-25 18:16 ` David Brown 2013-02-12 1:42 ` Olof Johansson 0 siblings, 1 reply; 4+ messages in thread From: David Brown @ 2013-01-25 18:16 UTC (permalink / raw) To: Arnd Bergmann Cc: linux-arm-kernel, linux-kernel, Bryan Huntsman, Daniel Walker, linux-arm-msm Arnd Bergmann <arnd@arndb.de> writes: > msm_smd_probe is a driver probe function and may get > called after the __init time, so it must not call > any __init function, as the link-time warning reports. > Take away the __init annotation on proc_comm_boot_wait > to fix this. > > Without this patch, building msm_defconfig results in: > > WARNING: vmlinux.o(.text+0xb048): Section mismatch in reference from the function msm_smd_probe() to the function .init.text:proc_comm_boot_wait() > The function msm_smd_probe() references > the function __init proc_comm_boot_wait(). > This is often because msm_smd_probe lacks a __init > annotation or the annotation of proc_comm_boot_wait is wrong. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Cc: David Brown <davidb@codeaurora.org> > Cc: Bryan Huntsman <bryanh@codeaurora.org> > Cc: Daniel Walker <c_dwalke@quicinc.com> > Cc: linux-arm-msm@vger.kernel.org > --- > arch/arm/mach-msm/proc_comm.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Arnd, you're welcome to pull this into your tree: Acked-by: David Brown <davidb@codeaurora.org> I don't forsee any conflicts with upcoming patches. David -- sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 03/19] ARM: msm: proc_comm_boot_wait should not be __init 2013-01-25 18:16 ` David Brown @ 2013-02-12 1:42 ` Olof Johansson 0 siblings, 0 replies; 4+ messages in thread From: Olof Johansson @ 2013-02-12 1:42 UTC (permalink / raw) To: David Brown Cc: Arnd Bergmann, linux-arm-kernel, linux-kernel, Bryan Huntsman, Daniel Walker, linux-arm-msm On Fri, Jan 25, 2013 at 10:16:31AM -0800, David Brown wrote: > Arnd Bergmann <arnd@arndb.de> writes: > > > msm_smd_probe is a driver probe function and may get > > called after the __init time, so it must not call > > any __init function, as the link-time warning reports. > > Take away the __init annotation on proc_comm_boot_wait > > to fix this. > > > > Without this patch, building msm_defconfig results in: > > > > WARNING: vmlinux.o(.text+0xb048): Section mismatch in reference from the function msm_smd_probe() to the function .init.text:proc_comm_boot_wait() > > The function msm_smd_probe() references > > the function __init proc_comm_boot_wait(). > > This is often because msm_smd_probe lacks a __init > > annotation or the annotation of proc_comm_boot_wait is wrong. > > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Cc: David Brown <davidb@codeaurora.org> > > Cc: Bryan Huntsman <bryanh@codeaurora.org> > > Cc: Daniel Walker <c_dwalke@quicinc.com> > > Cc: linux-arm-msm@vger.kernel.org > > --- > > arch/arm/mach-msm/proc_comm.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Arnd, you're welcome to pull this into your tree: > Acked-by: David Brown <davidb@codeaurora.org> > > I don't forsee any conflicts with upcoming patches. Applied. -Olof ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <1359153858-31992-1-git-send-email-arnd@arndb.de>]
* [PATCH 03/19] ARM: msm: proc_comm_boot_wait should not be __init [not found] ` <1359153858-31992-1-git-send-email-arnd@arndb.de> @ 2013-01-25 22:44 ` Arnd Bergmann 0 siblings, 0 replies; 4+ messages in thread From: Arnd Bergmann @ 2013-01-25 22:44 UTC (permalink / raw) To: linux-arm-kernel Cc: Bryan Huntsman, David Brown, linux-kernel, Arnd Bergmann, linux-arm-msm msm_smd_probe is a driver probe function and may get called after the __init time, so it must not call any __init function, as the link-time warning reports. Take away the __init annotation on proc_comm_boot_wait to fix this. Without this patch, building msm_defconfig results in: WARNING: vmlinux.o(.text+0xb048): Section mismatch in reference from the function msm_smd_probe() to the function .init.text:proc_comm_boot_wait() The function msm_smd_probe() references the function __init proc_comm_boot_wait(). This is often because msm_smd_probe lacks a __init annotation or the annotation of proc_comm_boot_wait is wrong. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: David Brown <davidb@codeaurora.org> Cc: Bryan Huntsman <bryanh@codeaurora.org> Cc: linux-arm-msm@vger.kernel.org --- arch/arm/mach-msm/proc_comm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-msm/proc_comm.h b/arch/arm/mach-msm/proc_comm.h index 12da4ca..e8d043a 100644 --- a/arch/arm/mach-msm/proc_comm.h +++ b/arch/arm/mach-msm/proc_comm.h @@ -253,6 +253,6 @@ enum { (((drvstr) & 0xF) << 17)) int msm_proc_comm(unsigned cmd, unsigned *data1, unsigned *data2); -void __init proc_comm_boot_wait(void); +void proc_comm_boot_wait(void); #endif -- 1.8.0 ^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-02-12 1:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1359123276-15833-1-git-send-email-arnd@arndb.de>
2013-01-25 14:14 ` [PATCH 03/19] ARM: msm: proc_comm_boot_wait should not be __init Arnd Bergmann
2013-01-25 18:16 ` David Brown
2013-02-12 1:42 ` Olof Johansson
[not found] ` <1359153858-31992-1-git-send-email-arnd@arndb.de>
2013-01-25 22:44 ` Arnd Bergmann
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox