* [PATCH] clk: qcom: Set CLK_SET_RATE_PARENT on ce1 clocks
@ 2015-07-15 0:09 Stephen Boyd
2015-07-15 0:28 ` Bjorn Andersson
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Boyd @ 2015-07-15 0:09 UTC (permalink / raw)
To: Mike Turquette, Stephen Boyd
Cc: linux-kernel, linux-clk, linux-arm-msm, Bjorn Andersson
The other ce clocks have the flag set, but ce1 doesn't, so
clk_set_rate() doesn't propagate up the tree to the ce1_src_clk.
Set the flag as this is supported.
Reported-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Fixes: 02824653200b ("clk: qcom: Add APQ8084 Global Clock Controller support")
Fixes: d33faa9ead8d ("clk: qcom: Add support for MSM8974's global clock controller (GCC)")
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
drivers/clk/qcom/gcc-apq8084.c | 1 +
drivers/clk/qcom/gcc-msm8974.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/clk/qcom/gcc-apq8084.c b/drivers/clk/qcom/gcc-apq8084.c
index 05b7a25b80e8..3563019b8e3c 100644
--- a/drivers/clk/qcom/gcc-apq8084.c
+++ b/drivers/clk/qcom/gcc-apq8084.c
@@ -2105,6 +2105,7 @@ static struct clk_branch gcc_ce1_clk = {
"ce1_clk_src",
},
.num_parents = 1,
+ .flags = CLK_SET_RATE_PARENT,
.ops = &clk_branch2_ops,
},
},
diff --git a/drivers/clk/qcom/gcc-msm8974.c b/drivers/clk/qcom/gcc-msm8974.c
index 2c289702119f..2bcf87538f9d 100644
--- a/drivers/clk/qcom/gcc-msm8974.c
+++ b/drivers/clk/qcom/gcc-msm8974.c
@@ -1783,6 +1783,7 @@ static struct clk_branch gcc_ce1_clk = {
"ce1_clk_src",
},
.num_parents = 1,
+ .flags = CLK_SET_RATE_PARENT,
.ops = &clk_branch2_ops,
},
},
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] clk: qcom: Set CLK_SET_RATE_PARENT on ce1 clocks
2015-07-15 0:09 [PATCH] clk: qcom: Set CLK_SET_RATE_PARENT on ce1 clocks Stephen Boyd
@ 2015-07-15 0:28 ` Bjorn Andersson
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2015-07-15 0:28 UTC (permalink / raw)
To: Stephen Boyd
Cc: Mike Turquette, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org
On Tue 14 Jul 17:09 PDT 2015, Stephen Boyd wrote:
> The other ce clocks have the flag set, but ce1 doesn't, so
> clk_set_rate() doesn't propagate up the tree to the ce1_src_clk.
> Set the flag as this is supported.
>
> Reported-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> Fixes: 02824653200b ("clk: qcom: Add APQ8084 Global Clock Controller support")
> Fixes: d33faa9ead8d ("clk: qcom: Add support for MSM8974's global clock controller (GCC)")
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
Thanks, test ok on 8974.
Tested-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Regards,
Bjorn
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-15 0:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-15 0:09 [PATCH] clk: qcom: Set CLK_SET_RATE_PARENT on ce1 clocks Stephen Boyd
2015-07-15 0:28 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox