From: Stephen Boyd <sboyd@codeaurora.org>
To: Vivek Gautam <vivek.gautam@codeaurora.org>
Cc: srinivas.kandagatla@linaro.org, maxime.ripard@free-electrons.com,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/2] nvmem: core: Correct a bunch of function documentations
Date: Mon, 9 Jan 2017 11:52:46 -0800 [thread overview]
Message-ID: <20170109195246.GP17126@codeaurora.org> (raw)
In-Reply-To: <1483693823-8858-1-git-send-email-vivek.gautam@codeaurora.org>
On 01/06, Vivek Gautam wrote:
> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
> index 398ea7f54826..294cdef96277 100644
> --- a/drivers/nvmem/core.c
> +++ b/drivers/nvmem/core.c
> @@ -634,8 +634,8 @@ struct nvmem_device *of_nvmem_device_get(struct device_node *np, const char *id)
> /**
> * nvmem_device_get() - Get nvmem device from a given id
> *
> - * @dev : Device that uses the nvmem device
> - * @id: nvmem name from nvmem-names property.
> + * @dev : Device that uses the nvmem device.
^
Drop this space?
> + * @dev_name: name of the requested nvmem device.
> *
> * Return: ERR_PTR() on error or a valid pointer to a struct nvmem_device
> * on success.
> @@ -674,6 +674,7 @@ static void devm_nvmem_device_release(struct device *dev, void *res)
> /**
> * devm_nvmem_device_put() - put alredy got nvmem device
> *
> + * @dev : Device that uses the nvmem device.
^
Drop this space?
> * @nvmem: pointer to nvmem device allocated by devm_nvmem_cell_get(),
> * that needs to be released.
> */
> @@ -702,8 +703,8 @@ void nvmem_device_put(struct nvmem_device *nvmem)
> /**
> * devm_nvmem_device_get() - Get nvmem cell of device form a given id
> *
> - * @dev node: Device tree node that uses the nvmem cell
> - * @id: nvmem name in nvmems property.
> + * @dev : Device that requests the nvmem device.
^
Drop this space?
> + * @id: name id for the requested nvmem device.
> *
> * Return: ERR_PTR() on error or a valid pointer to a struct nvmem_cell
> * on success. The nvmem_cell will be freed by the automatically once the
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-01-09 19:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-06 9:10 [PATCH 1/2] nvmem: core: Correct a bunch of function documentations Vivek Gautam
2017-01-06 9:10 ` [PATCH 2/2] nvmem: core: Allow getting nvmem cell with a NULL cell id Vivek Gautam
2017-01-09 19:53 ` Stephen Boyd
2017-01-10 7:59 ` Vivek Gautam
2017-01-09 19:52 ` Stephen Boyd [this message]
2017-01-10 7:58 ` [PATCH 1/2] nvmem: core: Correct a bunch of function documentations Vivek Gautam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170109195246.GP17126@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox