From: Stephen Boyd <sboyd@codeaurora.org>
To: Vivek Gautam <vivek.gautam@codeaurora.org>
Cc: srinivas.kandagatla@linaro.org, maxime.ripard@free-electrons.com,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 2/2] nvmem: core: Allow getting nvmem cell with a NULL cell id
Date: Mon, 9 Jan 2017 11:53:41 -0800 [thread overview]
Message-ID: <20170109195341.GQ17126@codeaurora.org> (raw)
In-Reply-To: <1483693823-8858-2-git-send-email-vivek.gautam@codeaurora.org>
On 01/06, Vivek Gautam wrote:
> The nvmem cell with a NULL cell name/id should be the one
> with no accompanying 'nvmem-cell-names' property, and thus
> will be the cell at index 0 in the device tree.
> So, we default to index 0 and update the cell index only when
> nvmem cell name id exists.
>
> Suggested-by: Stephen Boyd <sboyd@codeaurora.org>
> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
Except the typo below:
> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
> index 294cdef96277..d243dc6ad1a4 100644
> --- a/drivers/nvmem/core.c
> +++ b/drivers/nvmem/core.c
> @@ -747,7 +747,9 @@ static struct nvmem_cell *nvmem_cell_get_from_list(const char *cell_id)
> * of_nvmem_cell_get() - Get a nvmem cell from given device node and cell id
> *
> * @np: Device tree node that uses the nvmem cell.
> - * @name: nvmem cell name from nvmem-cell-names property.
> + * @name: nvmem cell name from nvmem-cell-names property, or NULL
> + * for the cell at index 0 (the lone cell with no acoompanying
s/acoompanying/accompanying/
> + * nvmem-cell-names property).
> *
> * Return: Will be an ERR_PTR() on error or a valid pointer
> * to a struct nvmem_cell. The nvmem_cell will be freed by the
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-01-09 19:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-06 9:10 [PATCH 1/2] nvmem: core: Correct a bunch of function documentations Vivek Gautam
2017-01-06 9:10 ` [PATCH 2/2] nvmem: core: Allow getting nvmem cell with a NULL cell id Vivek Gautam
2017-01-09 19:53 ` Stephen Boyd [this message]
2017-01-10 7:59 ` Vivek Gautam
2017-01-09 19:52 ` [PATCH 1/2] nvmem: core: Correct a bunch of function documentations Stephen Boyd
2017-01-10 7:58 ` Vivek Gautam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170109195341.GQ17126@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox