Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Andy Gross <andy.gross@linaro.org>
To: Stephen Boyd <stephen.boyd@linaro.org>
Cc: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
	"Bjorn Andersson" <bjorn.andersson@sonymobile.com>,
	"Peter Chen" <peter.chen@nxp.com>,
	linux-arm-msm@vger.kernel.org
Subject: Re: MSM8974: USB (gadget mode) broken in v4.11-rc1
Date: Wed, 8 Mar 2017 09:40:55 +0100	[thread overview]
Message-ID: <20170308084055.GA3093@hector> (raw)
In-Reply-To: <148890206102.8530.1859126261242834013@sboyd-linaro>

On Tue, Mar 07, 2017 at 07:54:21AM -0800, Stephen Boyd wrote:
> Quoting Jonathan Neuschäfer (2017-03-06 21:04:23)
> > Hi,
> > 
> > In Andy Gross' for-next branch (commit a844f941617c929b29, "Merge tag
> > 'qcom-arm64-for-4.11-2' into final-for-4.11"), USB support on my MSM8974
> > phone worked, but since the following merge by Linus (195849ea13549dc), it
> > does not work anymore. (I've only tested gadget mode so far. I don't know if
> > host mode works.)
> > 
> > I ran git bisect with the devicetree from Bjorn Andersson's commit
> > 769907ae6e6c28 ("ARM: dts: qcom: msm8974: Add USB gadget nodes"), and got
> 
> I have no idea why this was merged into v4.11-rc1. Andy?

This was one of the outstanding patches that I thought needed to be merged.

> 
> > this result:
> > 
> > e9f15a71f17b328be44767cb893576c7c838f996 is the first bad commit
> > commit e9f15a71f17b328be44767cb893576c7c838f996
> > Author: Stephen Boyd <stephen.boyd@linaro.org>
> > Date:   Wed Dec 28 14:57:01 2016 -0800
> > 
> >     usb: chipidea: msm: Add proper clk and reset support
> > 
> >     The msm chipidea controller uses two main clks, an AHB clk to
> >     read/write the MMIO registers and a core clk called the system
> >     clk that drives the controller itself. Add support for these clks
> >     as they're required in all designs.
> > 
> >     Also add support for an optional third clk that we need to turn
> >     on to reset the controller and wrapper logic and other
> >     "housekeeping" things. This clk was removed in later revisions of
> >     the hardware because the reset methodology no longer required
> >     clks to be enabled to propagate resets.
> > 
> >     Acked-by: Peter Chen <peter.chen@nxp.com>
> >     Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >     Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org>
> >     Signed-off-by: Peter Chen <peter.chen@nxp.com>
> > 
> > I can't see any potential error messages because the serial gadget driver is
> > the only console I have on this system.
> 
> Oh that's unfortunate.
> 
> > 
> > Is there something missing in qcom-msm8974.dtsi?
> 
> Yes. The DT side of the patches never merged into arm-soc, so you'll
> need this patch[1] to get things going. I thought the plan was to wait
> for the usb driver rewrite and never merge that dts patch you mentioned.

When I queued that into my set of patches I thought that it was safe.  I thought
wrong.  I can send a fixes pull request to fix the current mainline.


> [1] http://lkml.kernel.org/r/20170127004728.22490-4-stephen.boyd@linaro.org
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2017-03-08  8:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-07  5:04 MSM8974: USB (gadget mode) broken in v4.11-rc1 Jonathan Neuschäfer
2017-03-07 15:54 ` Stephen Boyd
2017-03-08  8:40   ` Andy Gross [this message]
2017-03-08 10:38     ` Bjorn Andersson
2017-03-22 15:17   ` Jonathan Neuschäfer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170308084055.GA3093@hector \
    --to=andy.gross@linaro.org \
    --cc=bjorn.andersson@sonymobile.com \
    --cc=j.neuschaefer@gmx.net \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=peter.chen@nxp.com \
    --cc=stephen.boyd@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox