* [PATCH] drm/msm: make a5xx_show and a5xx_gpu_state_put static
@ 2019-10-09 11:46 Ben Dooks
2019-10-09 15:44 ` Jordan Crouse
0 siblings, 1 reply; 3+ messages in thread
From: Ben Dooks @ 2019-10-09 11:46 UTC (permalink / raw)
To: linux-kernel
Cc: Ben Dooks, Rob Clark, Sean Paul, David Airlie, Daniel Vetter,
linux-arm-msm, dri-devel, freedreno
The a5xx_show and a5xx_gpu_state_put objects are not exported
outside of the file, so make them static to avoid the following
warnings from sparse:
drivers/gpu/drm/msm/adreno/a5xx_gpu.c:1292:5: warning: symbol 'a5xx_gpu_state_put' was not declared. Should it be static?
drivers/gpu/drm/msm/adreno/a5xx_gpu.c:1302:6: warning: symbol 'a5xx_show' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: linux-arm-msm@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org
---
drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c
index e9c55d1d6c04..7fdc9e2bcaac 100644
--- a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c
+++ b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c
@@ -1289,7 +1289,7 @@ static void a5xx_gpu_state_destroy(struct kref *kref)
kfree(a5xx_state);
}
-int a5xx_gpu_state_put(struct msm_gpu_state *state)
+static int a5xx_gpu_state_put(struct msm_gpu_state *state)
{
if (IS_ERR_OR_NULL(state))
return 1;
@@ -1299,8 +1299,8 @@ int a5xx_gpu_state_put(struct msm_gpu_state *state)
#if defined(CONFIG_DEBUG_FS) || defined(CONFIG_DEV_COREDUMP)
-void a5xx_show(struct msm_gpu *gpu, struct msm_gpu_state *state,
- struct drm_printer *p)
+static void a5xx_show(struct msm_gpu *gpu, struct msm_gpu_state *state,
+ struct drm_printer *p)
{
int i, j;
u32 pos = 0;
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/msm: make a5xx_show and a5xx_gpu_state_put static
2019-10-09 11:46 [PATCH] drm/msm: make a5xx_show and a5xx_gpu_state_put static Ben Dooks
@ 2019-10-09 15:44 ` Jordan Crouse
2019-10-11 13:31 ` Sean Paul
0 siblings, 1 reply; 3+ messages in thread
From: Jordan Crouse @ 2019-10-09 15:44 UTC (permalink / raw)
To: Ben Dooks
Cc: linux-kernel, Rob Clark, Sean Paul, David Airlie, Daniel Vetter,
linux-arm-msm, dri-devel, freedreno
On Wed, Oct 09, 2019 at 12:46:07PM +0100, Ben Dooks wrote:
> The a5xx_show and a5xx_gpu_state_put objects are not exported
> outside of the file, so make them static to avoid the following
> warnings from sparse:
>
> drivers/gpu/drm/msm/adreno/a5xx_gpu.c:1292:5: warning: symbol 'a5xx_gpu_state_put' was not declared. Should it be static?
> drivers/gpu/drm/msm/adreno/a5xx_gpu.c:1302:6: warning: symbol 'a5xx_show' was not declared. Should it be static?
Reviewed-by: Jordan Crouse <jcrouse@codeaurora.org>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: freedreno@lists.freedesktop.org
> ---
> drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c
> index e9c55d1d6c04..7fdc9e2bcaac 100644
> --- a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c
> +++ b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c
> @@ -1289,7 +1289,7 @@ static void a5xx_gpu_state_destroy(struct kref *kref)
> kfree(a5xx_state);
> }
>
> -int a5xx_gpu_state_put(struct msm_gpu_state *state)
> +static int a5xx_gpu_state_put(struct msm_gpu_state *state)
> {
> if (IS_ERR_OR_NULL(state))
> return 1;
> @@ -1299,8 +1299,8 @@ int a5xx_gpu_state_put(struct msm_gpu_state *state)
>
>
> #if defined(CONFIG_DEBUG_FS) || defined(CONFIG_DEV_COREDUMP)
> -void a5xx_show(struct msm_gpu *gpu, struct msm_gpu_state *state,
> - struct drm_printer *p)
> +static void a5xx_show(struct msm_gpu *gpu, struct msm_gpu_state *state,
> + struct drm_printer *p)
> {
> int i, j;
> u32 pos = 0;
> --
> 2.23.0
>
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/msm: make a5xx_show and a5xx_gpu_state_put static
2019-10-09 15:44 ` Jordan Crouse
@ 2019-10-11 13:31 ` Sean Paul
0 siblings, 0 replies; 3+ messages in thread
From: Sean Paul @ 2019-10-11 13:31 UTC (permalink / raw)
To: Ben Dooks, linux-kernel, Rob Clark, Sean Paul, David Airlie,
Daniel Vetter, linux-arm-msm, dri-devel, freedreno
On Wed, Oct 09, 2019 at 09:44:06AM -0600, Jordan Crouse wrote:
> On Wed, Oct 09, 2019 at 12:46:07PM +0100, Ben Dooks wrote:
> > The a5xx_show and a5xx_gpu_state_put objects are not exported
> > outside of the file, so make them static to avoid the following
> > warnings from sparse:
> >
> > drivers/gpu/drm/msm/adreno/a5xx_gpu.c:1292:5: warning: symbol 'a5xx_gpu_state_put' was not declared. Should it be static?
> > drivers/gpu/drm/msm/adreno/a5xx_gpu.c:1302:6: warning: symbol 'a5xx_show' was not declared. Should it be static?
>
> Reviewed-by: Jordan Crouse <jcrouse@codeaurora.org>
>
Applied to msm-next, thanks for the review and patch!
Sean
> > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> > ---
> > Cc: Rob Clark <robdclark@gmail.com>
> > Cc: Sean Paul <sean@poorly.run>
> > Cc: David Airlie <airlied@linux.ie>
> > Cc: Daniel Vetter <daniel@ffwll.ch>
> > Cc: linux-arm-msm@vger.kernel.org
> > Cc: dri-devel@lists.freedesktop.org
> > Cc: freedreno@lists.freedesktop.org
> > ---
> > drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c
> > index e9c55d1d6c04..7fdc9e2bcaac 100644
> > --- a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c
> > +++ b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c
> > @@ -1289,7 +1289,7 @@ static void a5xx_gpu_state_destroy(struct kref *kref)
> > kfree(a5xx_state);
> > }
> >
> > -int a5xx_gpu_state_put(struct msm_gpu_state *state)
> > +static int a5xx_gpu_state_put(struct msm_gpu_state *state)
> > {
> > if (IS_ERR_OR_NULL(state))
> > return 1;
> > @@ -1299,8 +1299,8 @@ int a5xx_gpu_state_put(struct msm_gpu_state *state)
> >
> >
> > #if defined(CONFIG_DEBUG_FS) || defined(CONFIG_DEV_COREDUMP)
> > -void a5xx_show(struct msm_gpu *gpu, struct msm_gpu_state *state,
> > - struct drm_printer *p)
> > +static void a5xx_show(struct msm_gpu *gpu, struct msm_gpu_state *state,
> > + struct drm_printer *p)
> > {
> > int i, j;
> > u32 pos = 0;
> > --
> > 2.23.0
> >
>
> --
> The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> a Linux Foundation Collaborative Project
--
Sean Paul, Software Engineer, Google / Chromium OS
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-11 13:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-09 11:46 [PATCH] drm/msm: make a5xx_show and a5xx_gpu_state_put static Ben Dooks
2019-10-09 15:44 ` Jordan Crouse
2019-10-11 13:31 ` Sean Paul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox