* [PATCH 26/30] iio: adc: qcom-pm8xxx-xoadc: Demote standard comment block and supply missing description
[not found] <20200717165538.3275050-1-lee.jones@linaro.org>
@ 2020-07-17 16:55 ` Lee Jones
2020-07-17 20:15 ` Bjorn Andersson
0 siblings, 1 reply; 3+ messages in thread
From: Lee Jones @ 2020-07-17 16:55 UTC (permalink / raw)
To: jic23, knaack.h, lars, pmeerw
Cc: linux-arm-kernel, linux-kernel, linux-iio, Lee Jones, Andy Gross,
Bjorn Andersson, Linus Walleij, linux-arm-msm
Kerneldoc is only suitable for documenting functions and struct/enums.
Fixes the following W=1 kernel build warning(s):
drivers/iio/adc/qcom-pm8xxx-xoadc.c:133: warning: Excess function parameter 'PM8XXX_CHANNEL_INTERNAL' description in 'PM8XXX_CHANNEL_INTERNAL'
drivers/iio/adc/qcom-pm8xxx-xoadc.c:133: warning: Excess function parameter 'PM8XXX_CHANNEL_125V' description in 'PM8XXX_CHANNEL_INTERNAL'
drivers/iio/adc/qcom-pm8xxx-xoadc.c:133: warning: Excess function parameter 'PM8XXX_CHANNEL_INTERNAL_2' description in 'PM8XXX_CHANNEL_INTERNAL'
drivers/iio/adc/qcom-pm8xxx-xoadc.c:133: warning: Excess function parameter 'PM8XXX_CHANNEL_MUXOFF' description in 'PM8XXX_CHANNEL_INTERNAL'
drivers/iio/adc/qcom-pm8xxx-xoadc.c:412: warning: Function parameter or member 'variant' not described in 'pm8xxx_xoadc'
Cc: Andy Gross <agross@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-arm-msm@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/iio/adc/qcom-pm8xxx-xoadc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/adc/qcom-pm8xxx-xoadc.c b/drivers/iio/adc/qcom-pm8xxx-xoadc.c
index c599ffa45a04c..cd5fa30e77df4 100644
--- a/drivers/iio/adc/qcom-pm8xxx-xoadc.c
+++ b/drivers/iio/adc/qcom-pm8xxx-xoadc.c
@@ -120,7 +120,7 @@
#define ADC_ARB_USRP_DATA0 0x19D
#define ADC_ARB_USRP_DATA1 0x19C
-/**
+/*
* Physical channels which MUST exist on all PM variants in order to provide
* proper reference points for calibration.
*
@@ -388,6 +388,7 @@ struct pm8xxx_chan_info {
* struct pm8xxx_xoadc - state container for the XOADC
* @dev: pointer to device
* @map: regmap to access registers
+ * @variant: XOADC variant characteristics
* @vref: reference voltage regulator
* characteristics of the channels, and sensible default settings
* @nchans: number of channels, configured by the device tree
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 26/30] iio: adc: qcom-pm8xxx-xoadc: Demote standard comment block and supply missing description
2020-07-17 16:55 ` [PATCH 26/30] iio: adc: qcom-pm8xxx-xoadc: Demote standard comment block and supply missing description Lee Jones
@ 2020-07-17 20:15 ` Bjorn Andersson
2020-07-18 16:06 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Bjorn Andersson @ 2020-07-17 20:15 UTC (permalink / raw)
To: Lee Jones
Cc: jic23, knaack.h, lars, pmeerw, linux-arm-kernel, linux-kernel,
linux-iio, Andy Gross, Linus Walleij, linux-arm-msm
On Fri 17 Jul 09:55 PDT 2020, Lee Jones wrote:
> Kerneldoc is only suitable for documenting functions and struct/enums.
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/iio/adc/qcom-pm8xxx-xoadc.c:133: warning: Excess function parameter 'PM8XXX_CHANNEL_INTERNAL' description in 'PM8XXX_CHANNEL_INTERNAL'
> drivers/iio/adc/qcom-pm8xxx-xoadc.c:133: warning: Excess function parameter 'PM8XXX_CHANNEL_125V' description in 'PM8XXX_CHANNEL_INTERNAL'
> drivers/iio/adc/qcom-pm8xxx-xoadc.c:133: warning: Excess function parameter 'PM8XXX_CHANNEL_INTERNAL_2' description in 'PM8XXX_CHANNEL_INTERNAL'
> drivers/iio/adc/qcom-pm8xxx-xoadc.c:133: warning: Excess function parameter 'PM8XXX_CHANNEL_MUXOFF' description in 'PM8XXX_CHANNEL_INTERNAL'
> drivers/iio/adc/qcom-pm8xxx-xoadc.c:412: warning: Function parameter or member 'variant' not described in 'pm8xxx_xoadc'
>
> Cc: Andy Gross <agross@kernel.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: linux-arm-msm@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> drivers/iio/adc/qcom-pm8xxx-xoadc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/qcom-pm8xxx-xoadc.c b/drivers/iio/adc/qcom-pm8xxx-xoadc.c
> index c599ffa45a04c..cd5fa30e77df4 100644
> --- a/drivers/iio/adc/qcom-pm8xxx-xoadc.c
> +++ b/drivers/iio/adc/qcom-pm8xxx-xoadc.c
> @@ -120,7 +120,7 @@
> #define ADC_ARB_USRP_DATA0 0x19D
> #define ADC_ARB_USRP_DATA1 0x19C
>
> -/**
> +/*
> * Physical channels which MUST exist on all PM variants in order to provide
> * proper reference points for calibration.
> *
> @@ -388,6 +388,7 @@ struct pm8xxx_chan_info {
> * struct pm8xxx_xoadc - state container for the XOADC
> * @dev: pointer to device
> * @map: regmap to access registers
> + * @variant: XOADC variant characteristics
> * @vref: reference voltage regulator
> * characteristics of the channels, and sensible default settings
> * @nchans: number of channels, configured by the device tree
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 26/30] iio: adc: qcom-pm8xxx-xoadc: Demote standard comment block and supply missing description
2020-07-17 20:15 ` Bjorn Andersson
@ 2020-07-18 16:06 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2020-07-18 16:06 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Lee Jones, knaack.h, lars, pmeerw, linux-arm-kernel, linux-kernel,
linux-iio, Andy Gross, Linus Walleij, linux-arm-msm
On Fri, 17 Jul 2020 13:15:25 -0700
Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
> On Fri 17 Jul 09:55 PDT 2020, Lee Jones wrote:
>
> > Kerneldoc is only suitable for documenting functions and struct/enums.
> >
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/iio/adc/qcom-pm8xxx-xoadc.c:133: warning: Excess function parameter 'PM8XXX_CHANNEL_INTERNAL' description in 'PM8XXX_CHANNEL_INTERNAL'
> > drivers/iio/adc/qcom-pm8xxx-xoadc.c:133: warning: Excess function parameter 'PM8XXX_CHANNEL_125V' description in 'PM8XXX_CHANNEL_INTERNAL'
> > drivers/iio/adc/qcom-pm8xxx-xoadc.c:133: warning: Excess function parameter 'PM8XXX_CHANNEL_INTERNAL_2' description in 'PM8XXX_CHANNEL_INTERNAL'
> > drivers/iio/adc/qcom-pm8xxx-xoadc.c:133: warning: Excess function parameter 'PM8XXX_CHANNEL_MUXOFF' description in 'PM8XXX_CHANNEL_INTERNAL'
> > drivers/iio/adc/qcom-pm8xxx-xoadc.c:412: warning: Function parameter or member 'variant' not described in 'pm8xxx_xoadc'
> >
> > Cc: Andy Gross <agross@kernel.org>
> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> > Cc: Linus Walleij <linus.walleij@linaro.org>
> > Cc: linux-arm-msm@vger.kernel.org
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.
Thanks,
Jonathan
> > ---
> > drivers/iio/adc/qcom-pm8xxx-xoadc.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/adc/qcom-pm8xxx-xoadc.c b/drivers/iio/adc/qcom-pm8xxx-xoadc.c
> > index c599ffa45a04c..cd5fa30e77df4 100644
> > --- a/drivers/iio/adc/qcom-pm8xxx-xoadc.c
> > +++ b/drivers/iio/adc/qcom-pm8xxx-xoadc.c
> > @@ -120,7 +120,7 @@
> > #define ADC_ARB_USRP_DATA0 0x19D
> > #define ADC_ARB_USRP_DATA1 0x19C
> >
> > -/**
> > +/*
> > * Physical channels which MUST exist on all PM variants in order to provide
> > * proper reference points for calibration.
> > *
> > @@ -388,6 +388,7 @@ struct pm8xxx_chan_info {
> > * struct pm8xxx_xoadc - state container for the XOADC
> > * @dev: pointer to device
> > * @map: regmap to access registers
> > + * @variant: XOADC variant characteristics
> > * @vref: reference voltage regulator
> > * characteristics of the channels, and sensible default settings
> > * @nchans: number of channels, configured by the device tree
> > --
> > 2.25.1
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-18 16:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20200717165538.3275050-1-lee.jones@linaro.org>
2020-07-17 16:55 ` [PATCH 26/30] iio: adc: qcom-pm8xxx-xoadc: Demote standard comment block and supply missing description Lee Jones
2020-07-17 20:15 ` Bjorn Andersson
2020-07-18 16:06 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox